SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #6141] [core]: tools.func: increase setup_php function #6398

New Issue
Open
opened 2025-11-20 07:10:26 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:10:26 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/6141

State: closed
Merged: Yes

✍️ Description

Refined the setup_php function to reduce redundant operations and handle PHP/Apache setup more intelligently.

🔧 Changes

  • Removed redundant base-package validation loop:
    Dropped unnecessary apt-cache show loop for the base PHP package.

  • Conditional Apache installation:
    Now installs apache2 and libapache2-mod-php only if PHP_APACHE=YES and they are not already installed.

  • Module validation improved:
    Checks availability of each requested module individually, logging a warning if a module is not found.

  • Avoid repeated Apache service manipulation:
    Ensures a2enmod and a2dismod are only called when necessary, prevents redundant restarts.

  • Explicitly enables mpm_prefork when setting up Apache:
    Guarantees correct MPM configuration for PHP.

  • Improved idempotency:
    Skips reinstallation of Apache/PHP if already installed and matches the requested version.

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/6141 **State:** closed **Merged:** Yes --- ## ✍️ Description Refined the `setup_php` function to reduce redundant operations and handle PHP/Apache setup more intelligently. --- ## 🔧 Changes - **Removed redundant base-package validation loop:** Dropped unnecessary `apt-cache show` loop for the base PHP package. - **Conditional Apache installation:** Now installs `apache2` and `libapache2-mod-php` only if `PHP_APACHE=YES` and they are not already installed. - **Module validation improved:** Checks availability of each requested module individually, logging a warning if a module is not found. - **Avoid repeated Apache service manipulation:** Ensures `a2enmod` and `a2dismod` are only called when necessary, prevents redundant restarts. - **Explicitly enables `mpm_prefork` when setting up Apache:** Guarantees correct MPM configuration for PHP. - **Improved idempotency:** Skips reinstallation of Apache/PHP if already installed and matches the requested version. ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.
saavagebueno added the pull-request label 2025-11-20 07:10:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#6398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?