SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-22 13:53:40 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #6152] [MERGED] Add GitHub Actions workflow to validate JSON files in the frontend directory #6410

New Issue
Closed
opened 2025-11-20 07:10:28 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:10:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/6152
Author: @BramSuurdje
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/22/2025
Merged by: @MickLesk

Base: main ← Head: add-json-testing

📝 Commits (10+)

  • 9c0c4da Add GitHub Actions workflow to validate JSON files in the frontend directory
  • ff45bd6 test new github workflow by invalidating script
  • 362d334 Revalidate json script to also test workflow
  • 878d107 Refactor GitHub Actions workflow to validate JSON files using Python.
  • 0a3f28c test github workflow
  • 4b9c007 Update description in apache-tomcat.json for clarity and consistency.
  • bdc96de Consolidate JSON validation workflow: Migrate test-jsons.yml functionality into frontend-cicd.yml, enhancing CI process by validating JSON files in the public directory with Python.
  • 955521e test to see if workflow fails
  • 4681abc test to see if workflow passes
  • 5af1aa3 testing

📊 Changes

1 file changed (+76 additions, -1 deletions)

View changed files

📝 .github/workflows/frontend-cicd.yml (+76 -1)

📄 Description

✍️ Description

This pull request introduces a new GitHub Actions workflow to validate the syntax of JSON files in the frontend/public/json directory. The workflow is triggered on pushes and pull requests that modify files in the frontend directory.

New GitHub Actions Workflow:

  • .github/workflows/test-jsons.yml: Added a workflow named "Test JSON Files" to validate the syntax of JSON files in the frontend/public/json directory. The workflow uses Python to parse and check all .json files in the directory, reporting any invalid files and their errors. It runs on ubuntu-latest and is triggered by changes to the frontend directory.

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/6152 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/22/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `add-json-testing` --- ### 📝 Commits (10+) - [`9c0c4da`](https://github.com/community-scripts/ProxmoxVE/commit/9c0c4da8819598432b10e29d1635f56621b350ae) Add GitHub Actions workflow to validate JSON files in the frontend directory - [`ff45bd6`](https://github.com/community-scripts/ProxmoxVE/commit/ff45bd69a7f5e0ac272afc84eac1b4c68f6a961b) test new github workflow by invalidating script - [`362d334`](https://github.com/community-scripts/ProxmoxVE/commit/362d3344f73b61d9f7c24e4707663e777843946c) Revalidate json script to also test workflow - [`878d107`](https://github.com/community-scripts/ProxmoxVE/commit/878d107e30853b01f9dabe123d087e6a51c92403) Refactor GitHub Actions workflow to validate JSON files using Python. - [`0a3f28c`](https://github.com/community-scripts/ProxmoxVE/commit/0a3f28c8f873916932497637dd60c53b8d53b28e) test github workflow - [`4b9c007`](https://github.com/community-scripts/ProxmoxVE/commit/4b9c00707de17957ba04aea690baae9acfa974ed) Update description in apache-tomcat.json for clarity and consistency. - [`bdc96de`](https://github.com/community-scripts/ProxmoxVE/commit/bdc96deec2f49c1cbd75e46920b0cb48f8d5d91c) Consolidate JSON validation workflow: Migrate test-jsons.yml functionality into frontend-cicd.yml, enhancing CI process by validating JSON files in the public directory with Python. - [`955521e`](https://github.com/community-scripts/ProxmoxVE/commit/955521e2728e89c996e4bb3ac775bd3e8183eda2) test to see if workflow fails - [`4681abc`](https://github.com/community-scripts/ProxmoxVE/commit/4681abc99ee3e7e3a90650ae13b40c4d33d5779d) test to see if workflow passes - [`5af1aa3`](https://github.com/community-scripts/ProxmoxVE/commit/5af1aa3f81230a9e1e504b5a2adc33457de8e011) testing ### 📊 Changes **1 file changed** (+76 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/frontend-cicd.yml` (+76 -1) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description This pull request introduces a new GitHub Actions workflow to validate the syntax of JSON files in the `frontend/public/json` directory. The workflow is triggered on pushes and pull requests that modify files in the `frontend` directory. ### New GitHub Actions Workflow: * [`.github/workflows/test-jsons.yml`](diffhunk://#diff-891c4a6f93043bff6e10297122a0a40959f44ac2cf555531d3cd458002f381a3R1-R82): Added a workflow named "Test JSON Files" to validate the syntax of JSON files in the `frontend/public/json` directory. The workflow uses Python to parse and check all `.json` files in the directory, reporting any invalid files and their errors. It runs on `ubuntu-latest` and is triggered by changes to the `frontend` directory. ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:10:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#6410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?