[PR #6313] [MERGED] Refactor: HiveMQ #6554

Closed
opened 2025-11-20 07:11:07 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/6313
Author: @tremor021
Created: 7/28/2025
Status: Merged
Merged: 7/28/2025
Merged by: @michelroegl-brunner

Base: mainHead: hivemq


📝 Commits (3)

📊 Changes

2 files changed (+8 additions, -16 deletions)

View changed files

📝 frontend/public/json/hivemq.json (+1 -1)
📝 install/hivemq-install.sh (+7 -15)

📄 Description

✍️ Description

  • Now uses helper functions to install the application
  • Updated documentation link

Link: #

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/6313 **Author:** [@tremor021](https://github.com/tremor021) **Created:** 7/28/2025 **Status:** ✅ Merged **Merged:** 7/28/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `hivemq` --- ### 📝 Commits (3) - [`6f94ac2`](https://github.com/community-scripts/ProxmoxVE/commit/6f94ac284dc04463091e3a49d6675c6b6b413a1a) Refactor - [`abb1739`](https://github.com/community-scripts/ProxmoxVE/commit/abb1739fe51f7850bb42b1f09117f1325dae07af) Update - [`cd3469d`](https://github.com/community-scripts/ProxmoxVE/commit/cd3469d812f444d32e41a9d819717601fc44e810) Update hivemq-install.sh ### 📊 Changes **2 files changed** (+8 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/public/json/hivemq.json` (+1 -1) 📝 `install/hivemq-install.sh` (+7 -15) </details> ### 📄 Description <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description - Now uses helper functions to install the application - Updated documentation link ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [x] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:11:07 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#6554