SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Use real/actual names in the script titles and descriptions #673

New Issue
Closed
opened 2025-11-20 04:51:58 -05:00 by saavagebueno · 4 comments
saavagebueno commented 2025-11-20 04:51:58 -05:00
Owner
Copy Link

Originally created by @geekuality on GitHub (Mar 7, 2025).

📌 Task summary

Rename and update descriptions of some existing scripts and issue/enforce similar rule for any future scripts

📋 Task details

There are scripts in the collection that are listed with a title differing from the actual software/package/etc being installed, and this causes confusion because of the misinformation in the title. IMO the community-scripts project should have clear rules/guidelines for naming the scripts, so that it is clear for the user what exactly is being installed by the script (and preferably also why).

Two examples of present issues (I'm quite sure that there are others, these are just the ones that I've very recently stumbled upon):

  • Trilium LXC installs a fork named TriliumNext instead of the original, now "discontinued" Trilium.
  • Nextcloud LXC installs nextcloudpi, which is a completely separate software/package built on top/around of Nextcloud itself, and for example has an extra GUI/app for managing settings that are not configurable through the base app.

Both of these scripts were originally in tteckster's (💔) repo and had better (albeit still not completely problem-free) naming and/or description of the scripts there.

Originally created by @geekuality on GitHub (Mar 7, 2025). ### 📌 Task summary Rename and update descriptions of some existing scripts and issue/enforce similar rule for any future scripts ### 📋 Task details There are scripts in the collection that are listed with a title differing from the actual software/package/etc being installed, and this causes confusion because of the misinformation in the title. IMO the community-scripts project should have clear rules/guidelines for naming the scripts, so that it is clear for the user what exactly is being installed by the script (and preferably also why). Two examples of present issues (I'm quite sure that there are others, these are just the ones that I've very recently stumbled upon): - **Trilium LXC** installs a fork named _TriliumNext_ instead of the original, now "discontinued" Trilium. - **Nextcloud LXC** installs _nextcloudpi_, which is a completely separate software/package built on top/around of Nextcloud itself, and for example has an extra GUI/app for managing settings that are not configurable through the base app. Both of these scripts were originally in tteckster's (💔) repo and had better (albeit still not completely problem-free) naming and/or description of the scripts there.
saavagebueno commented 2025-11-20 04:51:59 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Mar 7, 2025):

We have never renamed Scripts?

If you rename Scripts, all update functions of all users for exactly this Script are broken.

By the way, this both Scripts where you linked are exactly the Same in tteck repo 🤔

@MickLesk commented on GitHub (Mar 7, 2025): We have never renamed Scripts? If you rename Scripts, all update functions of all users for exactly this Script are broken. By the way, this both Scripts where you linked are exactly the Same in tteck repo 🤔
saavagebueno commented 2025-11-20 04:51:59 -05:00
Author
Owner
Copy Link

@geekuality commented on GitHub (Mar 7, 2025):

If you rename Scripts, all update functions of all users for exactly this Script are broken.

I don't see the issue being so significant if only the filename stays as-is, I'm referring specifically to the title and description shown on the website where the users are browsing the scripts.

By the way, this both Scripts where you linked are exactly the Same in tteck repo 🤔

Scripts may be, but not the information (title and description) shown.

Screenshots

"Trilium Next LXC" by tteckster:

Image

"Trilium LXC" by community-scripts:

Image

@geekuality commented on GitHub (Mar 7, 2025): > If you rename Scripts, all update functions of all users for exactly this Script are broken. I don't see the issue being so significant if only the filename stays as-is, I'm referring specifically to the title and description shown on the website where the users are browsing the scripts. > By the way, this both Scripts where you linked are exactly the Same in tteck repo 🤔 Scripts may be, but not the information (title and description) shown. <details><summary>Screenshots</summary> <p> "Trilium Next LXC" by tteckster: ![Image](https://github.com/user-attachments/assets/8d9f57e3-6586-4ee4-920d-e20cf2b0c5f6) "Trilium LXC" by community-scripts: ![Image](https://github.com/user-attachments/assets/f35a11a3-eb9d-45d5-b3cc-560836da0c86) </p> </details>
saavagebueno commented 2025-11-20 04:51:59 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Mar 7, 2025):

You can help us out anytime and open a PR to fix this if you think it is a issue.

@michelroegl-brunner commented on GitHub (Mar 7, 2025): You can help us out anytime and open a PR to fix this if you think it is a issue.
saavagebueno commented 2025-11-20 04:52:00 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Mar 7, 2025):

Done.

@michelroegl-brunner commented on GitHub (Mar 7, 2025): Done.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?