SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #6568] [CLOSED] fix(pulse): Update Pulse scripts to support v4 Go rewrite #6777

New Issue
Closed
opened 2025-11-20 07:12:19 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:12:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/6568
Author: @rcourtman
Created: 8/4/2025
Status: ❌ Closed

Base: main ← Head: pulse-v4-update

📝 Commits (2)

  • cdd4141 fix(pulse): Update Pulse scripts for v4 Go rewrite
  • 45ab529 refactor: remove comments per review feedback

📊 Changes

2 files changed (+41 additions, -54 deletions)

View changed files

📝 ct/pulse.sh (+26 -12)
📝 install/pulse-install.sh (+15 -42)

📄 Description

Description

This PR updates the Pulse installation and update scripts to properly support Pulse v4, which is a complete rewrite in Go.

Changes

install/pulse-install.sh

  • Detects if the latest release is v4+ (Go) or v3 (Node.js)
  • For v4+: Downloads the universal package and runs the included installer
  • For v3: Maintains existing Node.js installation process
  • Properly sets version tracking for update compatibility

ct/pulse.sh

  • Updated update_script() function to handle both v3 and v4
  • v4 updates preserve the data directory during updates
  • Maintains backward compatibility with v3 installations

Testing

  • v4 installations work correctly with the new script
  • v3 installations continue to work as before
  • Updates between v4 versions preserve configuration

Context

Pulse v4 is a complete rewrite from Node.js to Go, offering:

  • 87% less memory usage (10-12MB vs 90-150MB)
  • 3x faster startup
  • Single binary deployment
  • Better performance and stability

The scripts now automatically detect the version and use the appropriate installation method.

Fixes the issue where the current script tries to install v4 as a Node.js application, resulting in a broken installation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/6568 **Author:** [@rcourtman](https://github.com/rcourtman) **Created:** 8/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pulse-v4-update` --- ### 📝 Commits (2) - [`cdd4141`](https://github.com/community-scripts/ProxmoxVE/commit/cdd4141bb6a32f63088b41d6c8934b68cccce9af) fix(pulse): Update Pulse scripts for v4 Go rewrite - [`45ab529`](https://github.com/community-scripts/ProxmoxVE/commit/45ab5291d7affb57b891962aa19452e63e249ca2) refactor: remove comments per review feedback ### 📊 Changes **2 files changed** (+41 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `ct/pulse.sh` (+26 -12) 📝 `install/pulse-install.sh` (+15 -42) </details> ### 📄 Description ## Description This PR updates the Pulse installation and update scripts to properly support Pulse v4, which is a complete rewrite in Go. ## Changes ### `install/pulse-install.sh` - Detects if the latest release is v4+ (Go) or v3 (Node.js) - For v4+: Downloads the universal package and runs the included installer - For v3: Maintains existing Node.js installation process - Properly sets version tracking for update compatibility ### `ct/pulse.sh` - Updated `update_script()` function to handle both v3 and v4 - v4 updates preserve the data directory during updates - Maintains backward compatibility with v3 installations ## Testing - v4 installations work correctly with the new script - v3 installations continue to work as before - Updates between v4 versions preserve configuration ## Context Pulse v4 is a complete rewrite from Node.js to Go, offering: - 87% less memory usage (10-12MB vs 90-150MB) - 3x faster startup - Single binary deployment - Better performance and stability The scripts now automatically detect the version and use the appropriate installation method. Fixes the issue where the current script tries to install v4 as a Node.js application, resulting in a broken installation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:12:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#6777
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?