SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #6574] fix: update Pulse scripts for v4 Go rewrite support #6780

New Issue
Open
opened 2025-11-20 08:03:41 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:03:41 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/6574

State: closed
Merged: Yes

✍️ Description

Updates Pulse installation scripts to support v4, which is a complete rewrite in Go. The current scripts attempt to install v4 as a Node.js application, resulting in broken installations.

What this fixes:

  • Pulse v4 is now downloaded as a universal package (not Node.js)
  • Uses the built-in installer script included with v4
  • Preserves data directory during updates
  • Removes Node.js dependencies for v4 installations

Why this is critical:

  • Pulse v4.0.0 is already released
  • Current scripts create broken installations for all new users
  • v4 offers 87% less memory usage and 3x faster startup

🔗 Related PR / Issue

Link: #6568 (previous PR closed for template/formatting issues)

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Testing performed:

  • ✅ Fresh v4 installation works correctly
  • ✅ Updates between v4 versions preserve configuration
  • ✅ Data directory is preserved during updates
  • ✅ Service starts and runs properly after installation
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/6574 **State:** closed **Merged:** Yes --- ## ✍️ Description Updates Pulse installation scripts to support v4, which is a complete rewrite in Go. The current scripts attempt to install v4 as a Node.js application, resulting in broken installations. ### What this fixes: - Pulse v4 is now downloaded as a universal package (not Node.js) - Uses the built-in installer script included with v4 - Preserves data directory during updates - Removes Node.js dependencies for v4 installations ### Why this is critical: - Pulse v4.0.0 is already released - Current scripts create **broken installations** for all new users - v4 offers 87% less memory usage and 3x faster startup ## 🔗 Related PR / Issue Link: #6568 (previous PR closed for template/formatting issues) ## ✅ Prerequisites (**X** in brackets) - [X] **Self-review completed** – Code follows project standards. - [X] **Tested thoroughly** – Changes work as expected. - [X] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [X] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [ ] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs. ### Testing performed: - ✅ Fresh v4 installation works correctly - ✅ Updates between v4 versions preserve configuration - ✅ Data directory is preserved during updates - ✅ Service starts and runs properly after installation
saavagebueno added the pull-request label 2025-11-20 08:03:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#6780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?