SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #7174] FileBrowser Quantum: safer update (tmp download + atomic replace + arch autodetect) #7021

New Issue
Open
opened 2025-11-20 08:04:26 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:04:26 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/7174

State: closed
Merged: Yes

✍️ Description

Safer updater for FileBrowser Quantum addon in tools/addon/filebrowser-quantum.sh.

Before (problem)

  • Update path streamed curl directly into /usr/local/bin/filebrowser and printed success even if curl failed.
  • This led to errors like curl: (23) Failure writing output to destination and a false “Updated” message.

After (this PR)

  • Download to a temp file on the same filesystem, then atomic mv into INSTALL_PATH.
  • Print success only if curl and mv succeed.
  • (Also includes the missing fi to close the if [[ -f "$INSTALL_PATH" ]] block.)

No changes to defaults, service unit, or dependencies. amd64 asset unchanged.

🔗 Related PR / Issue

Link: N/A

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Verified on Debian/Proxmox host:
    • Success: downloads to temp and atomically replaces the binary.
    • Failure: forced bad URL → script reports error and does not claim success.
  • No security risks – No secrets; permissions set to 0755; atomic replace avoids partial writes.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves incorrect success message and fragile in-place write.
  • 🔧 Refactoring / Code Cleanup – Small robustness improvement.
  • ✨ New feature
  • 💥 Breaking change
  • 🆕 New script
  • 🌍 Website update
  • 📝 Documentation update
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/7174 **State:** closed **Merged:** Yes --- <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description Safer updater for **FileBrowser Quantum** addon in `tools/addon/filebrowser-quantum.sh`. **Before (problem)** - Update path streamed `curl` directly into `/usr/local/bin/filebrowser` and printed success even if `curl` failed. - This led to errors like `curl: (23) Failure writing output to destination` and a false “Updated” message. **After (this PR)** - Download to a **temp file on the same filesystem**, then **atomic `mv`** into `INSTALL_PATH`. - Print success **only if `curl` and `mv` succeed**. - (Also includes the missing `fi` to close the `if [[ -f "$INSTALL_PATH" ]]` block.) _No changes to defaults, service unit, or dependencies. amd64 asset unchanged._ --- ## 🔗 Related PR / Issue Link: N/A --- ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Verified on Debian/Proxmox host: - Success: downloads to temp and atomically replaces the binary. - Failure: forced bad URL → script reports error and does **not** claim success. - [x] **No security risks** – No secrets; permissions set to 0755; atomic replace avoids partial writes. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves incorrect success message and fragile in-place write. - [x] 🔧 **Refactoring / Code Cleanup** – Small robustness improvement. - [ ] ✨ **New feature** - [ ] 💥 **Breaking change** - [ ] 🆕 **New script** - [ ] 🌍 **Website update** - [ ] 📝 **Documentation update**
saavagebueno added the pull-request label 2025-11-20 08:04:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#7021
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?