SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-05-16 13:12:06 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #7820] ElementSynapse: add note for Bridge Install Methods #7293

New Issue
Open
opened 2025-11-20 08:05:17 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:05:17 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/7820

State: closed
Merged: Yes

✍️ Description

add an note for install bridges for element synapse, reason:
I just reviewed this request and I think integrating bridges directly into the Synapse script would massively bloat it. Each bridge has different dependencies, configs, and use cases, which would easily add 200–400 extra lines of code. That would make the script harder to maintain in the long run.
Instead, I’d suggest either writing a separate guide or adding a link on the website pointing to the official bridge documentation. This keeps the main script lean and maintainable, while still giving users a clear path if they want to set up bridges like WhatsApp, Signal, or Discord.

🔗 Related PR / Issue

Link: #7073

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/7820 **State:** closed **Merged:** Yes --- <!--🛑 New scripts must be submitted to [ProxmoxVED](https://github.com/community-scripts/ProxmoxVED) for testing. PRs without prior testing will be closed. --> ## ✍️ Description add an note for install bridges for element synapse, **reason**: _I just reviewed this request and I think integrating bridges directly into the Synapse script would massively bloat it. Each bridge has different dependencies, configs, and use cases, which would easily add 200–400 extra lines of code. That would make the script harder to maintain in the long run. Instead, I’d suggest either writing a separate guide or adding a link on the website pointing to the official bridge documentation. This keeps the main script lean and maintainable, while still giving users a clear path if they want to set up bridges like WhatsApp, Signal, or Discord._ ## 🔗 Related PR / Issue Link: #7073 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.
saavagebueno added the pull-request label 2025-11-20 08:05:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#7293
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?