SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

lldap - little error in update script #758

New Issue
Closed
opened 2025-11-20 04:53:35 -05:00 by saavagebueno · 2 comments
saavagebueno commented 2025-11-20 04:53:35 -05:00
Owner
Copy Link

Originally created by @FairTradeOrange on GitHub (Mar 21, 2025).

Originally assigned to: @tremor021 on GitHub.

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

lldap

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/lldap.sh)"

📝 Provide a clear and concise description of the issue.

The Update Script said: ✖️ No lldap Installation Found!.
So i looked into the script and it seems there is an error in the update function:
(https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/lldap.sh)

function update_script() {
    header_info
    check_container_storage
    check_container_resources
    if [[ ! -f /etc/systemd/system/lldap.service ]]; then      <-------X
        msg_error "No ${APP} Installation Found!"
        exit
    fi
    msg_info "Updating $APP"
    apt update
    apt upgrade -y lldap
    msg_ok "Updated $APP"
    exit
}

it should be /lib/systemd/system/lldap.service.
Or is it an error because of my old installation ( old repository )?

Here my running instance in /lib/systemd/system/lldap.service with default installation.

● lldap.service - Nitnelave LLDAP
Loaded: loaded (/lib/systemd/system/lldap.service; enabled; preset: enabled)
Active: active (running) since Sat 2025-03-22 00:11:49 CET; 5min ago
Docs: https://github.com/nitnelave/lldap
Main PID: 4450 (lldap)
Tasks: 4 (limit: 154340)
Memory: 2.7M
CPU: 70ms
CGroup: /system.slice/lldap.service
└─4450 /usr/bin/lldap run --config-file /etc/lldap/lldap_config.toml

Thank you all for supporting this wonderful project! ( :

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

🔄 Steps to reproduce the issue.

  • Default Install lldap
  • Update lldap with update or script

❌ Paste the full error output (if available).

✖️ No lldap Installation Found!.

🖼️ Additional context (optional).

No response

Originally created by @FairTradeOrange on GitHub (Mar 21, 2025). Originally assigned to: @tremor021 on GitHub. ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? lldap ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/lldap.sh)" ### 📝 Provide a clear and concise description of the issue. The Update Script said: ` ✖️ No lldap Installation Found!`. So i looked into the script and it seems there is an error in the update function: (https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/lldap.sh) ``` function update_script() { header_info check_container_storage check_container_resources if [[ ! -f /etc/systemd/system/lldap.service ]]; then <-------X msg_error "No ${APP} Installation Found!" exit fi msg_info "Updating $APP" apt update apt upgrade -y lldap msg_ok "Updated $APP" exit } ``` it should be `/lib/systemd/system/lldap.service`. Or is it an error because of my old installation ( old repository )? Here my running instance in `/lib/systemd/system/lldap.service` with default installation. ● lldap.service - Nitnelave LLDAP Loaded: loaded (/lib/systemd/system/lldap.service; enabled; preset: enabled) Active: active (running) since Sat 2025-03-22 00:11:49 CET; 5min ago Docs: https://github.com/nitnelave/lldap Main PID: 4450 (lldap) Tasks: 4 (limit: 154340) Memory: 2.7M CPU: 70ms CGroup: /system.slice/lldap.service └─4450 /usr/bin/lldap run --config-file /etc/lldap/lldap_config.toml Thank you all for supporting this wonderful project! ( : ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 🔄 Steps to reproduce the issue. - Default Install lldap - Update lldap with `update` or script ### ❌ Paste the full error output (if available). ` ✖️ No lldap Installation Found!`. ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 04:53:35 -05:00
saavagebueno commented 2025-11-20 04:53:36 -05:00
Author
Owner
Copy Link

@bvdberg01 commented on GitHub (Mar 22, 2025):

@tremor021 I already have PR :)

@bvdberg01 commented on GitHub (Mar 22, 2025): @tremor021 I already have PR :)
saavagebueno commented 2025-11-20 04:53:36 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Mar 22, 2025):

Fix merged.

@michelroegl-brunner commented on GitHub (Mar 22, 2025): Fix merged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#758
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?