SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

MQTT Helper Script uses always debian repos #770

New Issue
Closed
opened 2025-11-20 04:53:47 -05:00 by saavagebueno · 4 comments
saavagebueno commented 2025-11-20 04:53:47 -05:00
Owner
Copy Link

Originally created by @mutec on GitHub (Mar 23, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

MQTT

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/mqtt.sh)"

📝 Provide a clear and concise description of the issue.

When using the MQTT helper script with advanced settings you can choose whether to use Debian or Ubuntu.
In my case I'd want to use Ubuntu 24.04 which is accepted by the script and also successfully installed afterwards.

However during the installation script for Mosquitto a repository for APT is about to be added:

a0f393cb56/install/mqtt-install.sh (L27)

As you can see the url points statically to the debian repository, but reads the correct codename dynamically. In my case this would result in the following:
deb [arch= signed-by=/usr/share/keyrings/mosquitto-repo.gpg.key] http://repo.mosquitto.org/debian noble main
Since noble is a codename for Ubuntu, but not debian, this is about to fail.

According to the developer's site, it's not necessary to add an apt repository for Ubuntu, but for Debian:
https://mosquitto.org/download/
It is possible to add their dev PPA ppa:mosquitto-dev/mosquitto-ppa (see also https://launchpad.net/~mosquitto-dev/+archive/ubuntu/mosquitto-ppa) for more recent versions when using Ubuntu.
As you can see over here, it's truly available using the Ubuntu repositories:
https://packages.ubuntu.com/search?keywords=mosquitto&searchon=names&suite=all&section=all

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Ubuntu 24.04

🔄 Steps to reproduce the issue.

  • Use Advanced Settings
  • Set Distribution to Ubuntu
  • Set Ubuntu Version to 24.04
  • Run through the other settings (not relevant for this issue)

❌ Paste the full error output (if available).

n/a

🖼️ Additional context (optional).

No response

Originally created by @mutec on GitHub (Mar 23, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? MQTT ### 📂 What was the exact command used to execute the script? bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/mqtt.sh)" ### 📝 Provide a clear and concise description of the issue. When using the [MQTT helper script](https://community-scripts.github.io/ProxmoxVE/scripts?id=mqtt) with advanced settings you can choose whether to use Debian or Ubuntu. In my case I'd want to use Ubuntu 24.04 which is accepted by the script and also successfully installed afterwards. However during the installation script for Mosquitto a repository for APT is about to be added: https://github.com/community-scripts/ProxmoxVE/blob/a0f393cb568c84f1326f758d8110ef3df8b36dab/install/mqtt-install.sh#L27 As you can see the url points statically to the debian repository, but reads the correct codename dynamically. In my case this would result in the following: `deb [arch= signed-by=/usr/share/keyrings/mosquitto-repo.gpg.key] http://repo.mosquitto.org/debian noble main` Since noble is a codename for Ubuntu, but not debian, this is about to fail. According to the developer's site, it's not necessary to add an apt repository for Ubuntu, but for Debian: https://mosquitto.org/download/ It is possible to add their dev PPA `ppa:mosquitto-dev/mosquitto-ppa` (see also https://launchpad.net/~mosquitto-dev/+archive/ubuntu/mosquitto-ppa) for more recent versions when using Ubuntu. As you can see over here, it's truly available using the Ubuntu repositories: https://packages.ubuntu.com/search?keywords=mosquitto&searchon=names&suite=all&section=all ### ⚙️ What settings are you using? - [ ] Default Settings - [x] Advanced Settings ### 🖥️ Which Linux distribution are you using? Ubuntu 24.04 ### 🔄 Steps to reproduce the issue. - Use Advanced Settings - Set Distribution to Ubuntu - Set Ubuntu Version to 24.04 - Run through the other settings (not relevant for this issue) ### ❌ Paste the full error output (if available). n/a ### 🖼️ Additional context (optional). _No response_
saavagebueno commented 2025-11-20 04:53:48 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Mar 23, 2025):

As stated everywhere. we do for now offer the option to change the OS, but we only support the default OS, in this case debian.

@michelroegl-brunner commented on GitHub (Mar 23, 2025): As stated everywhere. we do for now offer the option to change the OS, but we only support the default OS, in this case debian.
saavagebueno commented 2025-11-20 04:53:48 -05:00
Author
Owner
Copy Link

@mutec commented on GitHub (Mar 24, 2025):

we do for now offer the option to change the OS, but we only support the default OS

What's the sense of the selection between both options if it's not supported at all?
I'd say Ubuntu would be more the "default OS" for mosquitto than Debian when reading phrases like "is now in Debian proper" or "available in the Ubuntu repositories so you can install as with any other package" on the developer's download instruction page.
In case you really won't fix the script (like it has already been done for MySQL in #3315), I'll have to set it up manually for our production containers.

@mutec commented on GitHub (Mar 24, 2025): > we do for now offer the option to change the OS, but we only support the default OS What's the sense of the selection between both options if it's not supported at all? I'd say Ubuntu would be more the "default OS" for mosquitto than Debian when reading phrases like "is now in Debian proper" or "available in the Ubuntu repositories so you can install as with any other package" on the developer's download instruction page. In case you really won't fix the script (like it has already been done for MySQL in #3315), I'll have to set it up manually for our production containers.
saavagebueno commented 2025-11-20 04:53:48 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Mar 24, 2025):

https://github.com/community-scripts/ProxmoxVE/discussions/3300

@MickLesk commented on GitHub (Mar 24, 2025): https://github.com/community-scripts/ProxmoxVE/discussions/3300
saavagebueno commented 2025-11-20 04:53:48 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Mar 24, 2025):

And feel free to create a PR that fixes this "problem".

@MickLesk commented on GitHub (Mar 24, 2025): And feel free to create a PR that fixes this "problem".
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label 🛑 Failure to comply with the guidelines not a script issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?