SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-22 13:53:40 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #9141] bump grafana to debian 13 #7779

New Issue
Open
opened 2025-11-20 08:06:46 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:06:46 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE/pull/9141

State: closed
Merged: Yes

Summary

This PR updates the default Debian version for the Grafana container template
to 13 and removes an obsolete package from the install script.

Background

When switching the Grafana CT to Debian 13, the install script fails because
the software-properties-common package cannot be found. According to the
discussion in grafana/grafana#110198, this package is no longer required for
installing Grafana on Debian 13, and the installation works fine without it.

I verified that Grafana installs and runs correctly on Debian 13 without this
package.

Changes

  • ct/grafana.sh

    • Update default var_version from 12 to 13 (Debian 13).

  • install/grafana-install.sh

    • Remove software-properties-common from the dependency list.
    • Keep apt-transport-https as the only extra package.

Testing

  • Created a Grafana LXC with Debian 13 using the updated script.
  • Ran the Grafana install script:
    • Dependencies installed without errors.
    • Repository configuration succeeded.
    • Grafana service started successfully.
    • Web UI is reachable and works as expected.

References

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE/pull/9141 **State:** closed **Merged:** Yes --- ## Summary This PR updates the default Debian version for the Grafana container template to 13 and removes an obsolete package from the install script. ## Background When switching the Grafana CT to Debian 13, the install script fails because the `software-properties-common` package cannot be found. According to the discussion in grafana/grafana#110198, this package is no longer required for installing Grafana on Debian 13, and the installation works fine without it. I verified that Grafana installs and runs correctly on Debian 13 without this package. ## Changes - `ct/grafana.sh` - Update default `var_version` from `12` to `13` (Debian 13). - `install/grafana-install.sh` - Remove `software-properties-common` from the dependency list. - Keep `apt-transport-https` as the only extra package. ## Testing - Created a Grafana LXC with Debian 13 using the updated script. - Ran the Grafana install script: - Dependencies installed without errors. - Repository configuration succeeded. - Grafana service started successfully. - Web UI is reachable and works as expected. ## References - grafana/grafana#110198 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [ ] 🆕 **New script** – A fully functional and tested script or script set. - [x] 🌍 **Website update** – Changes to website-related JSON files or metadata. - [ ] 🔧 **Refactoring / Code Cleanup** – Improves readability or maintainability without changing functionality. - [ ] 📝 **Documentation update** – Changes to `README`, `AppName.md`, `CONTRIBUTING.md`, or other docs.
saavagebueno added the pull-request label 2025-11-20 08:06:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#7779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?