[misc/post-pve-install.sh] Nag screen not disabled on Proxmox-VE 8.3.0 #99

@hautamik commented on GitHub (Nov 21, 2024):

Apparently proxmox-widget-toolkit has been updated so the current script isn't able to make the changes that were effective earlier. I can live with the reminder (nag, some might call) and wait.

@hautamik commented on GitHub (Nov 21, 2024): Apparently proxmox-widget-toolkit has been updated so the current script isn't able to make the changes that were effective earlier. I can live with the reminder (nag, some might call) and wait.

saavagebueno commented

@MickLesk commented on GitHub (Nov 21, 2024):

8.3 is accessible since today, it takes time to improve such scripts for the new version. ASAP

@MickLesk commented on GitHub (Nov 21, 2024): 8.3 is accessible since today, it takes time to improve such scripts for the new version. ASAP

saavagebueno commented

@Ajvdhoff commented on GitHub (Nov 21, 2024):

You can disable the nag by commenting out the Ext.Msg.show in the proxmoxlib.js file located in the /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js, like i did here (line 566 for me): check @derolli1976 comment for correct code
checked_command: function (orig_cmd) { Proxmox.Utils.API2Request( { url: '/nodes/localhost/subscription', method: 'GET', failure: function (response, opts) { Ext.Msg.alert(gettext('Error'), response.htmlStatus); }, success: function (response, opts) { let res = response.result; if (res === null || res === undefined || !res || res .data.status.toLowerCase() !== 'active') { // Ext.Msg.show({ // title: gettext('No valid subscription'), // icon: Ext.Msg.WARNING, // message: Proxmox.Utils.getNoSubKeyHtml(res.data.url), // buttons: Ext.Msg.OK, // callback: function(btn) { // if (btn !== 'ok') { // return; // } // orig_cmd(); // }, // }); } else { orig_cmd(); } }, }, ); },

@Ajvdhoff commented on GitHub (Nov 21, 2024): You can disable the nag by commenting out the Ext.Msg.show in the proxmoxlib.js file located in the /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js, like i did here (line 566 for me): check @derolli1976 comment for correct code ~~```checked_command: function (orig_cmd) { Proxmox.Utils.API2Request( { url: '/nodes/localhost/subscription', method: 'GET', failure: function (response, opts) { Ext.Msg.alert(gettext('Error'), response.htmlStatus); }, success: function (response, opts) { let res = response.result; if (res === null || res === undefined || !res || res .data.status.toLowerCase() !== 'active') { // Ext.Msg.show({ // title: gettext('No valid subscription'), // icon: Ext.Msg.WARNING, // message: Proxmox.Utils.getNoSubKeyHtml(res.data.url), // buttons: Ext.Msg.OK, // callback: function(btn) { // if (btn !== 'ok') { // return; // } // orig_cmd(); // }, // }); } else { orig_cmd(); } }, }, ); },```~~

saavagebueno commented

@newzealandpaul commented on GitHub (Nov 21, 2024):

@Ajvdhoff can you post or link to the original function without comments. I am trying to figure out why the existing script is not working.

Would also be helpful to post the output of this command:

dpkg -V proxmox-widget-toolkit

@newzealandpaul commented on GitHub (Nov 21, 2024): @Ajvdhoff can you post or link to the original function without comments. I am trying to figure out why the existing script is not working. Would also be helpful to post the output of this command: ``` dpkg -V proxmox-widget-toolkit ```

saavagebueno commented

@MickLesk commented on GitHub (Nov 22, 2024):

i fix the script at the moment. @hautamik can you share me the output of:

cat /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js | grep 'data.status'

@MickLesk commented on GitHub (Nov 22, 2024): i fix the script at the moment. @hautamik can you share me the output of: cat /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js | grep 'data.status'

saavagebueno commented

@cbrunnkvist commented on GitHub (Nov 22, 2024):

I just installed a fresh-off-the shelf 8.3 Proxmox VE ISO. Now I'm getting the following error the first time I ran post-pve-install.sh

Start the Proxmox VE Post Install Script (y/n)?y
 ✗ This version of Proxmox Virtual Environment is not supported
Requires Proxmox Virtual Environment Version 8.0 or later.
Exiting...
root@lemox:~# pveversion 
pve-manager/8.3.0/c1689ccb1065a83b (running kernel: 6.8.12-4-pve)

@cbrunnkvist commented on GitHub (Nov 22, 2024): I just installed a fresh-off-the shelf 8.3 Proxmox VE ISO. Now I'm getting the following error the first time I ran [post-pve-install.sh](https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/post-pve-install.sh) ``` Start the Proxmox VE Post Install Script (y/n)?y ✗ This version of Proxmox Virtual Environment is not supported Requires Proxmox Virtual Environment Version 8.0 or later. Exiting... root@lemox:~# pveversion pve-manager/8.3.0/c1689ccb1065a83b (running kernel: 6.8.12-4-pve) ```

saavagebueno commented

@MickLesk commented on GitHub (Nov 22, 2024):

thats already in PR state and need approved by 2 @community-scripts/contributor

@MickLesk commented on GitHub (Nov 22, 2024): thats already in PR state and need approved by 2 @community-scripts/contributor

saavagebueno commented

@derolli1976 commented on GitHub (Nov 22, 2024):

@Ajvdhoff

			Proxmox.Utils.API2Request(
				{
					url: '/nodes/localhost/subscription',
					method: 'GET',
					failure: function (response, opts) {
						Ext.Msg.alert(gettext('Error'), response.htmlStatus);
					},
					success: function (response, opts) {
						let res = response.result;
						if (res === null || res === undefined || !res || res
							.data.status.toLowerCase() !== 'active') {

  					 	orig_cmd();
  				} else {
  					orig_cmd();
  				}
  			},
  		},
  	);
  },```

You actually commented out a line too much. You need to leave to "orig_cmd();" in the if clause. Otherwise no commands (like "refresh" on the "Updates" page will actually do anything.

@derolli1976 commented on GitHub (Nov 22, 2024): @Ajvdhoff > ``` > Proxmox.Utils.API2Request( > { > url: '/nodes/localhost/subscription', > method: 'GET', > failure: function (response, opts) { > Ext.Msg.alert(gettext('Error'), response.htmlStatus); > }, > success: function (response, opts) { > let res = response.result; > if (res === null || res === undefined || !res || res > .data.status.toLowerCase() !== 'active') { > orig_cmd(); > } else { > orig_cmd(); > } > }, > }, > ); > },``` > ``` You actually commented out a line too much. You need to leave to "orig_cmd();" in the if clause. Otherwise no commands (like "refresh" on the "Updates" page will actually do anything.

saavagebueno commented

@Coffee0297 commented on GitHub (Nov 22, 2024):

I assume im bumping in to the same issue?

@Coffee0297 commented on GitHub (Nov 22, 2024): I assume im bumping in to the same issue? ![image](https://github.com/user-attachments/assets/0d41e5aa-13d3-4d31-9b8c-5743d0ae64da)

saavagebueno commented

@sammyke007 commented on GitHub (Jan 10, 2025):

It's still showing up, is this normal?

@sammyke007 commented on GitHub (Jan 10, 2025): It's still showing up, is this normal?

saavagebueno commented

@MickLesk commented on GitHub (Jan 10, 2025):

Which Script ?

@MickLesk commented on GitHub (Jan 10, 2025): Which Script ?

saavagebueno commented

From:
https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pve-install

@sammyke007 commented on GitHub (Jan 10, 2025):

Which Script ?

This script:
bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/post-pve-install.sh)"

I've said YES on every question while running the script.
The script confirms that he nag removal has been run, but the nag kept showing up.
Orrrrr could it have been a browser cache issue?
I've fixed it eventualy with

sed -Ezi.bak "s/(function$orig_cmd$ \{)/\1\n\torig_cmd;\n\treturn;/g" /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js && systemctl restart pveproxy.service

Brand new Proxmox v8.3.0 install.

@sammyke007 commented on GitHub (Jan 10, 2025): > Which Script ? This script: `bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/misc/post-pve-install.sh)"` From: [https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pve-install](https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pve-install) I've said YES on every question while running the script. The script confirms that he nag removal has been run, but the nag kept showing up. Orrrrr could it have been a browser cache issue? I've fixed it eventualy with ` sed -Ezi.bak "s/(function$orig_cmd$ \{)/\1\n\torig_cmd;\n\treturn;/g" /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js && systemctl restart pveproxy.service ` Brand new Proxmox v8.3.0 install.

saavagebueno commented

@MickLesk commented on GitHub (Jan 10, 2025):

Works fine for me and hundert Others ^^ Do you have more nodes

@MickLesk commented on GitHub (Jan 10, 2025): Works fine for me and hundert Others ^^ Do you have more nodes

saavagebueno commented

@sammyke007 commented on GitHub (Jan 10, 2025):

Works fine for me and hundert Others ^^ Do you have more nodes

I'll be installing a new one in 3 days. I'll report back!

@sammyke007 commented on GitHub (Jan 10, 2025): > Works fine for me and hundert Others ^^ Do you have more nodes I'll be installing a new one in 3 days. I'll report back!

saavagebueno commented

@MickLesk commented on GitHub (Jan 10, 2025):

Please then do an new issue. Because i get 100-200 notifications per day

@MickLesk commented on GitHub (Jan 10, 2025): Please then do an new issue. Because i get 100-200 notifications per day

saavagebueno commented