SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-10 09:22:09 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

How to add a sub router? #1170

New Issue
Closed
opened 2025-11-20 05:25:20 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:25:20 -05:00
Owner
Copy Link

Originally created by @BJorah on GitHub (Aug 22, 2024).

I want add a test router which without using the middleware , I add the code bellow in file netbird-0.28.6/management/server/http/handler.go

func APIHandler(ctx context.Context, accountManager s.AccountManager, LocationManager *geolocation.Geolocation, jwtValidator jwtclaims.JWTValidator, appMetrics telemetry.AppMetrics, authCfg AuthCfg, integratedValidator integrated_validator.IntegratedValidator) (http.Handler, error) {
//other code
.....

      noAuthRouter := rootRouter.PathPrefix("/test").Subrouter()
	      log.Println("working 2...")
	      noAuthRouter.HandleFunc("/hello", func(w http.ResponseWriter, r *http.Request) {
		      log.Println("responding helloworld...........")
		      w.Header().Set("Content-Type", "application/json")
		      response := map[string]string{
			      "test": "helloworld",
		      }
		      json.NewEncoder(w).Encode(response)
	      }).Methods("GET")

//other code
.....


}

and make a small change here:

func (apiHandler *apiHandler) addPeersEndpoint() {
	log.Println("working 3...")
	peersHandler := NewPeersHandler(apiHandler.AccountManager, apiHandler.AuthCfg)
       // it used to be "apiHandler.Router.HandleFunc("/peers", peersHandler.GetAllPeers).Methods("GET", "OPTIONS")"
	apiHandler.Router.HandleFunc("/hello222", peersHandler.GetAllPeers).Methods("GET", "OPTIONS")
	apiHandler.Router.HandleFunc("/peers/{peerId}", peersHandler.HandlePeer).
		Methods("GET", "PUT", "DELETE", "OPTIONS")
}

I only modified the above two places.
I rebuild it and I run this project locally.
I use postman send GET quests 127.0.0.1:80/test/hello 127.0.0.1:80/api/hello222, and they both reported 404 errors and with no logs were printed.
What is surprising is that the requet 127.0.0.1:80/api/peers is still working like it used to be !!?
I think that I must missing something important or making something wrong.
Would you like to tell me how to make it?

Originally created by @BJorah on GitHub (Aug 22, 2024). I want add a test router which without using the middleware , I add the code bellow in file netbird-0.28.6/management/server/http/handler.go ``` func APIHandler(ctx context.Context, accountManager s.AccountManager, LocationManager *geolocation.Geolocation, jwtValidator jwtclaims.JWTValidator, appMetrics telemetry.AppMetrics, authCfg AuthCfg, integratedValidator integrated_validator.IntegratedValidator) (http.Handler, error) { //other code ..... noAuthRouter := rootRouter.PathPrefix("/test").Subrouter() log.Println("working 2...") noAuthRouter.HandleFunc("/hello", func(w http.ResponseWriter, r *http.Request) { log.Println("responding helloworld...........") w.Header().Set("Content-Type", "application/json") response := map[string]string{ "test": "helloworld", } json.NewEncoder(w).Encode(response) }).Methods("GET") //other code ..... } ``` and make a small change here: ``` func (apiHandler *apiHandler) addPeersEndpoint() { log.Println("working 3...") peersHandler := NewPeersHandler(apiHandler.AccountManager, apiHandler.AuthCfg) // it used to be "apiHandler.Router.HandleFunc("/peers", peersHandler.GetAllPeers).Methods("GET", "OPTIONS")" apiHandler.Router.HandleFunc("/hello222", peersHandler.GetAllPeers).Methods("GET", "OPTIONS") apiHandler.Router.HandleFunc("/peers/{peerId}", peersHandler.HandlePeer). Methods("GET", "PUT", "DELETE", "OPTIONS") } ``` I only modified the above two places. I rebuild it and I run this project locally. I use postman send GET quests `127.0.0.1:80/test/hello` `127.0.0.1:80/api/hello222`, and they both reported 404 errors and with no logs were printed. What is surprising is that the requet `127.0.0.1:80/api/peers` is still working like it used to be !!? I think that I must missing something important or making something wrong. Would you like to tell me how to make it?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?