SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-18 06:02:14 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Service user with role User can view all setup keys via API #1231

New Issue
Open
opened 2025-11-20 05:26:40 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:26:40 -05:00
Owner
Copy Link

Originally created by @alexcupertme on GitHub (Sep 11, 2024).

Describe the problem

Service user with role User can view all setup keys via API. This is a huge critical problem, because it is a secret, which should be provisioned to the app using it once, and should be shown once we created it, not every time and EVEN WORSE - NOT all secrets created by other persons.

When we create secrets in UI, we receive this friendly message, unfortunately it is a lie because its not how system behaves, and takes you by surprise.

"Setup key created successfully!
This key will not be shown again, so be sure to copy it and store in a secure location."

And we also get these keys in browser while using admin console, we can see them raw in Networking tab DevTools

To Reproduce

Steps to reproduce the behavior:
0. Self-hosted Instance

  1. Create service user
  2. Assign User role to newly created user
  3. Create an API token
  4. curl -X GET https://netbird.example.com/api/setup-keys
    -H 'Accept: application/json'
    -H 'Authorization: Token '
  5. Can use fetched setup key

Expected behavior
Remove key field from response

Are you using NetBird Cloud?

no

NetBird version

netbird version

0.28.7

NetBird status -dA output:

Do you face any (non-mobile) client issues?

Screenshots

Additional context

Originally created by @alexcupertme on GitHub (Sep 11, 2024). **Describe the problem** Service user with role User can view all setup keys via API. This is a huge **critical** problem, because it is a secret, which should be provisioned to the app using it **once**, and should be shown once we created it, not every time and EVEN WORSE - NOT all secrets created by other persons. When we create secrets in UI, we receive this friendly message, unfortunately it is a lie because its not how system behaves, and takes you by surprise. "Setup key created successfully! This key will not be shown again, so be sure to copy it and store in a secure location." And we also get these keys in browser while using admin console, we can see them raw in Networking tab DevTools **To Reproduce** Steps to reproduce the behavior: 0. Self-hosted Instance 1. Create service user 2. Assign User role to newly created user 3. Create an API token 4. curl -X GET https://netbird.example.com/api/setup-keys \ -H 'Accept: application/json' \ -H 'Authorization: Token <token>' 5. Can use fetched setup key **Expected behavior** Remove key field from response **Are you using NetBird Cloud?** no **NetBird version** `netbird version` 0.28.7 **NetBird status -dA output:** - **Do you face any (non-mobile) client issues?** - **Screenshots** - **Additional context** -
saavagebueno added the waiting-feedbacktriage-needed labels 2025-11-20 05:26:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label triage-needed waiting-feedback
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1231
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?