SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-08-04 19:55:09 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Allow TLD-domains as match domains #1243

New Issue
Closed
opened 2025-11-20 05:26:49 -05:00 by saavagebueno · 5 comments
saavagebueno commented 2025-11-20 05:26:49 -05:00
Owner
Copy Link

Originally created by @kinafu on GitHub (Sep 13, 2024).

You can only set match domains in the format example.com and not in the form com.
So assume my internal domain is internal (example hostname fileserver.internal).
internal cannot be added as a match domain with netbird, so I will not be able to use the host name fileserver since there is no way to add internal as a search domain using netbird.

grafik

Originally created by @kinafu on GitHub (Sep 13, 2024). You can only set match domains in the format `example.com` and not in the form `com`. So assume my internal domain is `internal` (example hostname `fileserver.internal`). `internal` cannot be added as a match domain with netbird, so I will not be able to use the host name `fileserver` since there is no way to add `internal` as a search domain using netbird. ![grafik](https://github.com/user-attachments/assets/38b3da6f-0205-428b-af21-89f1bee80054)
saavagebueno added the feature-requestdns labels 2025-11-20 05:26:49 -05:00
saavagebueno commented 2025-11-20 05:26:49 -05:00
Author
Owner
Copy Link

@nazarewk commented on GitHub (Apr 28, 2025):

Hello @kinafu,

We're currently reviewing our open issues and would like to verify if this problem still exists in the latest NetBird version.

Could you please confirm if the issue is still there?

We may close this issue temporarily if we don't hear back from you within 2 weeks, but feel free to reopen it with updated information.

Thanks for your contribution to improving the project!

@nazarewk commented on GitHub (Apr 28, 2025): Hello @kinafu, We're currently reviewing our open issues and would like to verify if this problem still exists in the [latest NetBird version](https://github.com/netbirdio/netbird/releases). Could you please confirm if the issue is still there? We may close this issue temporarily if we don't hear back from you within **2 weeks**, but feel free to reopen it with updated information. Thanks for your contribution to improving the project!
saavagebueno commented 2025-11-20 05:26:50 -05:00
Author
Owner
Copy Link

@kinafu commented on GitHub (May 11, 2025):

I did not check it again, but @juju4 apparently encountered the same issue https://github.com/netbirdio/netbird/issues/3782.

@kinafu commented on GitHub (May 11, 2025): I did not check it again, but @juju4 apparently encountered the same issue https://github.com/netbirdio/netbird/issues/3782.
saavagebueno commented 2025-11-20 05:26:50 -05:00
Author
Owner
Copy Link

@kinafu commented on GitHub (May 11, 2025):

I also found issue https://github.com/netbirdio/netbird/issues/2921 that seems to ask for the same feature.

@kinafu commented on GitHub (May 11, 2025): I also found issue https://github.com/netbirdio/netbird/issues/2921 that seems to ask for the same feature.
saavagebueno commented 2025-11-20 05:26:50 -05:00
Author
Owner
Copy Link

@Hinara commented on GitHub (May 14, 2025):

@nazarewk can confirm this is still an issue under v0.43.3 of netbird management, relay and signal and v2.12.0 for dashboard
If bypassing the check in the dashboard I get the following message

**Code 422: Nameserver group got an invalid domain: home "domain should consists of only letters, numbers, and hyphens with no leading, trailing hyphens, or spaces"**

Check which is there in the backend
e520b64c6d/management/server/nameserver.go (L269)

The fail occurs because of the check
e520b64c6d/management/server/nameserver.go (L318)
with the regex
e520b64c6d/management/server/nameserver.go (L21)
But will also fail because of check
e520b64c6d/management/server/nameserver.go (L327)

@Hinara commented on GitHub (May 14, 2025): @nazarewk can confirm this is still an issue under `v0.43.3` of netbird management, relay and signal and `v2.12.0` for dashboard If bypassing the check in the dashboard I get the following message ``` **Code 422: Nameserver group got an invalid domain: home "domain should consists of only letters, numbers, and hyphens with no leading, trailing hyphens, or spaces"** ``` Check which is there in the backend https://github.com/netbirdio/netbird/blob/e520b64c6df4c81e45d914d9383acf0ca1468840/management/server/nameserver.go#L269 The fail occurs because of the check https://github.com/netbirdio/netbird/blob/e520b64c6df4c81e45d914d9383acf0ca1468840/management/server/nameserver.go#L318 with the regex https://github.com/netbirdio/netbird/blob/e520b64c6df4c81e45d914d9383acf0ca1468840/management/server/nameserver.go#L21 But will also fail because of check https://github.com/netbirdio/netbird/blob/e520b64c6df4c81e45d914d9383acf0ca1468840/management/server/nameserver.go#L327
saavagebueno commented 2025-11-20 05:26:50 -05:00
Author
Owner
Copy Link

@nazarewk commented on GitHub (May 15, 2025):

@Hinara thanks for a great piece of research! I have noted it as a comment in the "primary" issue.

I have found numerous mislabeled/disguised feature requests related to TLD feature and will be closing those on behalf of https://github.com/netbirdio/netbird/issues/2021 , where the discussion should continue (if at all)

@nazarewk commented on GitHub (May 15, 2025): @Hinara thanks for a great piece of research! I have noted it as a comment in the "primary" issue. I have found numerous mislabeled/disguised feature requests related to TLD feature and will be closing those on behalf of https://github.com/netbirdio/netbird/issues/2021 , where the discussion should continue (if at all)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label dns feature-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?