SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-11 01:41:55 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

v0.29.3 on Windows doesn't fix permissions for C:\ProgramData\Netbird directory/files permissions #1257

New Issue
Open
opened 2025-11-20 05:27:02 -05:00 by saavagebueno · 2 comments
saavagebueno commented 2025-11-20 05:27:02 -05:00
Owner
Copy Link

Originally created by @florian-obradovic on GitHub (Sep 17, 2024).

Describe the problem

The issue was already reported in the past _https://github.com/netbirdio/netbird/issues/661#issuecomment-2356404082 and partly fixed in PR #2568.
I also reported it as an security issue: GHSA-pjm7-gvv8-7xwr (https://github.com/netbirdio/netbird/security/advisories/GHSA-pjm7-gvv8-7xwr)

Unfortunately the new installer (MSI & EXE) only sets the permissions for new installations correctly, where %programdata%\Netbird doesn't exist.
For existing installations it leaves the permissions wide open so every unprivileged user on the machine can read config.json including private keys.

I can confirm this on two machines.

Github assigned a CVE number: CVE-2024-45814

NetBird version

netbird version 0.29.3

CleanShot 2024-09-17 at 19 39 14@2x

Expected Behaviour
Enforce permissions so only SYSTEM & Administrators can read %programdata%\Netbird on every install / update.

Originally created by @florian-obradovic on GitHub (Sep 17, 2024). **Describe the problem** The issue was already reported in the past _https://github.com/netbirdio/netbird/issues/661#issuecomment-2356404082 and partly fixed in PR #2568. I also reported it as an security issue: GHSA-pjm7-gvv8-7xwr (https://github.com/netbirdio/netbird/security/advisories/GHSA-pjm7-gvv8-7xwr) Unfortunately the new installer (MSI & EXE) only sets the permissions for new installations correctly, where **_%programdata%\Netbird_** doesn't exist. For existing installations it leaves the permissions wide open so every unprivileged user on the machine can read config.json including private keys. I can confirm this on two machines. Github assigned a CVE number: **CVE-2024-45814** **NetBird version** `netbird version 0.29.3` ![CleanShot 2024-09-17 at 19 39 14@2x](https://github.com/user-attachments/assets/b3a81d5e-c168-483d-aed8-7b54b7079943) **Expected Behaviour** Enforce permissions so only SYSTEM & Administrators can read **_%programdata%\Netbird_** on every install / update.
saavagebueno added the bugclientwindows labels 2025-11-20 05:27:02 -05:00
saavagebueno commented 2025-11-20 05:27:02 -05:00
Author
Owner
Copy Link

@GhaziTriki commented on GitHub (Apr 25, 2025):

It sill happens in the latest version of the client and the client is not able to connect. Should I share the debug logs?

@GhaziTriki commented on GitHub (Apr 25, 2025): It sill happens in the latest version of the client and the client is not able to connect. Should I share the debug logs?
saavagebueno commented 2025-11-20 05:27:02 -05:00
Author
Owner
Copy Link

@GhaziTriki commented on GitHub (Apr 25, 2025):

Here the debug logs coming from a Windows Server.

netbird.debug.1142459996.zip

@GhaziTriki commented on GitHub (Apr 25, 2025): Here the debug logs coming from a Windows Server. [netbird.debug.1142459996.zip](https://github.com/user-attachments/files/19905495/netbird.debug.1142459996.zip)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label bug client windows
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?