SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-27 18:42:22 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Security Issue: Setup keys are stored unencrypted in database table "setup_keys" #1351

New Issue
Closed
opened 2025-11-20 05:28:51 -05:00 by saavagebueno · 5 comments
saavagebueno commented 2025-11-20 05:28:51 -05:00
Owner
Copy Link

Originally created by @florian-obradovic on GitHub (Oct 20, 2024).

Describe the problem

The setup keys are stored unencrypted in the database (at least for sqlite3) which is very bad.
If the backend or storage (Cloud & Selfhosted) gets compromised, anyone can use the setup keys to provision new peers.

To Reproduce

  1. sudo sqlite3 /var/lib/docker/volumes/artifacts_netbird-mgmt/_data/store.db Adjust the path to your docker volume
  2. select * from setup_keys;

Expected behavior
Store the setup keys encrypted by using at least salted hashes (More infos: https://www.vaadata.com/blog/how-to-securely-store-passwords-in-database/)

Are you using NetBird Cloud?

Selfhsoted

NetBird version
0.30.2

Originally created by @florian-obradovic on GitHub (Oct 20, 2024). **Describe the problem** The setup keys are stored unencrypted in the database (at least for sqlite3) which is very bad. If the backend or storage (Cloud & Selfhosted) gets compromised, anyone can use the setup keys to provision new peers. **To Reproduce** 1. `sudo sqlite3 /var/lib/docker/volumes/artifacts_netbird-mgmt/_data/store.db` Adjust the path to your docker volume 2. `select * from setup_keys;` **Expected behavior** Store the setup keys encrypted by using at least salted hashes (More infos: https://www.vaadata.com/blog/how-to-securely-store-passwords-in-database/) **Are you using NetBird Cloud?** Selfhsoted **NetBird version** 0.30.2
saavagebueno added the serversecurity labels 2025-11-20 05:28:51 -05:00
saavagebueno commented 2025-11-20 05:28:52 -05:00
Author
Owner
Copy Link

@sudomoke commented on GitHub (Oct 21, 2024):

Setup keys should be set to expire, or limit the number of usage.

If you're using setup keys without any limits you should verify your rules are "very notrusty"

@sudomoke commented on GitHub (Oct 21, 2024): Setup keys should be set to expire, or limit the number of usage. If you're using setup keys without any limits you should verify your rules are "very notrusty"
saavagebueno commented 2025-11-20 05:28:52 -05:00
Author
Owner
Copy Link

@florian-obradovic commented on GitHub (Oct 21, 2024):

I generally agree, but there are use cases where you need keys with longer expiration dates (docker / kubernetes deployments, etc...).

On the other hand this discussing misses the point.
Unencrypted credentials in the database, especially high privileged credentials without second factor).

There is no good reason, why we should keep storing them unencrypted. No matter what short expiration time you choose.

@florian-obradovic commented on GitHub (Oct 21, 2024): I generally agree, but there are use cases where you need keys with longer expiration dates (docker / kubernetes deployments, etc...). On the other hand this discussing misses the point. Unencrypted credentials in the database, especially high privileged credentials without second factor). There is no good reason, why we should keep storing them unencrypted. No matter what short expiration time you choose.
saavagebueno commented 2025-11-20 05:28:52 -05:00
Author
Owner
Copy Link

@mgarces commented on GitHub (Oct 22, 2024):

hi @florian-obradovic, thank you for opening this issue.
Like previously discussed on Slack, we are currently working on the migration for these secrets, in the next few weeks, this should remove this security impact you mention here.

@mgarces commented on GitHub (Oct 22, 2024): hi @florian-obradovic, thank you for opening this issue. Like previously discussed on Slack, we are currently working on the migration for these secrets, in the next few weeks, this should remove this security impact you mention here.
saavagebueno commented 2025-11-20 05:28:52 -05:00
Author
Owner
Copy Link

@florian-obradovic commented on GitHub (Oct 22, 2024):

Thanks a lot!

@florian-obradovic commented on GitHub (Oct 22, 2024): Thanks a lot!
saavagebueno commented 2025-11-20 05:28:52 -05:00
Author
Owner
Copy Link

@heisbrot commented on GitHub (Oct 29, 2024):

Merged, see PR: https://github.com/netbirdio/netbird/pull/2775

@heisbrot commented on GitHub (Oct 29, 2024): Merged, see PR: https://github.com/netbirdio/netbird/pull/2775
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label security server
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?