SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-11 01:41:55 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Management fail to upgrade database from v0.35.2 to v0.36.1 with postgresql #1551

New Issue
Closed
opened 2025-11-20 05:32:41 -05:00 by saavagebueno · 3 comments
saavagebueno commented 2025-11-20 05:32:41 -05:00
Owner
Copy Link

Originally created by @MrBE4R on GitHub (Jan 16, 2025).

Describe the problem

Upgrading from v0.35.2 to v0.36.1 fail to upgrade schema with postgresql database.

management-1  | 2025-01-16T22:02:08Z INFO [context: SYSTEM] management/server/migration/migration.go:326: Column enabled does not exist in table network_resources, adding it
management-1  | Error: failed creating Store: /var/lib/netbird/: migrate: failed to find rows with empty enabled: ERROR: invalid input syntax for type boolean: "" (SQLSTATE 22P02)
management-1  | 2025-01-16T22:18:41Z INFO [context: SYSTEM] management/server/migration/migration.go:326: Column enabled does not exist in table network_routers, adding it
management-1  | Error: failed creating Store: /var/lib/netbird/: migrate: failed to find rows with empty enabled: ERROR: invalid input syntax for type boolean: "" (SQLSTATE 22P02)

To Reproduce

  • Deploy netbird v0.35.2 with postgresql
  • Upgrade to v0.36.1

Expected behavior

A clear and concise description of what you expected to happen.

Additional context

Manually adding the missing column allow the management to start.

alter table network_routers add column "enabled" text ;
alter table network_resources add column "enabled" text ;
Originally created by @MrBE4R on GitHub (Jan 16, 2025). **Describe the problem** Upgrading from v0.35.2 to v0.36.1 fail to upgrade schema with postgresql database. ``` management-1 | 2025-01-16T22:02:08Z INFO [context: SYSTEM] management/server/migration/migration.go:326: Column enabled does not exist in table network_resources, adding it management-1 | Error: failed creating Store: /var/lib/netbird/: migrate: failed to find rows with empty enabled: ERROR: invalid input syntax for type boolean: "" (SQLSTATE 22P02) management-1 | 2025-01-16T22:18:41Z INFO [context: SYSTEM] management/server/migration/migration.go:326: Column enabled does not exist in table network_routers, adding it management-1 | Error: failed creating Store: /var/lib/netbird/: migrate: failed to find rows with empty enabled: ERROR: invalid input syntax for type boolean: "" (SQLSTATE 22P02) ``` **To Reproduce** - Deploy netbird v0.35.2 with postgresql - Upgrade to v0.36.1 **Expected behavior** A clear and concise description of what you expected to happen. **Additional context** Manually adding the missing column allow the management to start. ``` alter table network_routers add column "enabled" text ; alter table network_resources add column "enabled" text ; ```
saavagebueno added the bugmanagement-serviceself-hostingstore labels 2025-11-20 05:32:41 -05:00
saavagebueno commented 2025-11-20 05:32:41 -05:00
Author
Owner
Copy Link

@bcmmbaga commented on GitHub (Jan 17, 2025):

Hi @MrBE4R , Thank you for reporting this issue.

Could you check the type of the enabled column in the network_routers and network_resources tables after starting the management service?

SELECT column_name, data_type
FROM information_schema.columns
WHERE table_name IN ('network_routers', 'network_resources') AND column_name = 'enabled';

If the enabled column is already of type BOOLEAN, no further action is needed. However, if it’s still TEXT, you may need to update it to BOOLEAN to prevent any issue(s) when creating/updating network resources and routers.

ALTER TABLE network_routers ALTER COLUMN "enabled" TYPE BOOLEAN USING ("enabled"::BOOLEAN);
ALTER TABLE network_resources ALTER COLUMN "enabled" TYPE BOOLEAN USING ("enabled"::BOOLEAN);
@bcmmbaga commented on GitHub (Jan 17, 2025): Hi @MrBE4R , Thank you for reporting this issue. Could you check the type of the `enabled` column in the `network_routers` and `network_resources` tables after starting the management service? ```sql SELECT column_name, data_type FROM information_schema.columns WHERE table_name IN ('network_routers', 'network_resources') AND column_name = 'enabled'; ``` If the `enabled` column is already of type `BOOLEAN`, no further action is needed. However, if it’s still `TEXT`, you may need to update it to `BOOLEAN` to prevent any issue(s) when creating/updating network resources and routers. ```sql ALTER TABLE network_routers ALTER COLUMN "enabled" TYPE BOOLEAN USING ("enabled"::BOOLEAN); ALTER TABLE network_resources ALTER COLUMN "enabled" TYPE BOOLEAN USING ("enabled"::BOOLEAN); ```
saavagebueno commented 2025-11-20 05:32:41 -05:00
Author
Owner
Copy Link

@MrBE4R commented on GitHub (Jan 17, 2025):

Hi @bcmmbaga ,

If I drop the column from the tables, management create them as a boolean (as expected) but won't start due to the check that you have corrected in #3198 .

I run two instances of netbird self-hosted, one with legacy network routes and one that have been migrated to the new networks resources.

On the one using legacy routes, manually adding the column as text allow me to start the management service and I can alter the column back to boolean afterward.

On the one using network resources, adding the column as text allow management to pass the check if column is null or empty but fail on setting the correct value due to mismatching type (as expected).

@MrBE4R commented on GitHub (Jan 17, 2025): Hi @bcmmbaga , If I drop the column from the tables, management create them as a boolean (as expected) but won't start due to the check that you have corrected in [#3198](https://github.com/netbirdio/netbird/pull/3198) . I run two instances of netbird self-hosted, one with legacy network routes and one that have been migrated to the new networks resources. On the one using legacy routes, manually adding the column as text allow me to start the management service and I can alter the column back to boolean afterward. On the one using network resources, adding the column as text allow management to pass the check if column is null or empty but fail on setting the correct value due to mismatching type (as expected).
saavagebueno commented 2025-11-20 05:32:42 -05:00
Author
Owner
Copy Link

@bcmmbaga commented on GitHub (Jan 17, 2025):

For the instance using legacy routes, it's expected to work fine since it doesn't involve the new network concept. For the instance using network resources, you'll need to wait for the upcoming release with the fix. Once the fix is applied, the management service should work as expected

@bcmmbaga commented on GitHub (Jan 17, 2025): For the instance using legacy routes, it's expected to work fine since it doesn't involve the new network concept. For the instance using network resources, you'll need to wait for the upcoming release with the fix. Once the fix is applied, the management service should work as expected
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label bug management-service self-hosting store
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?