SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-15 20:51:57 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[Kubernetes operator] add admission controller #1572

New Issue
Open
opened 2025-11-20 05:33:05 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:33:05 -05:00
Owner
Copy Link

Originally created by @mlsmaycon on GitHub (Jan 24, 2025).

Originally assigned to: @mohamed-essam on GitHub.

An admission controller is a piece of code that intercepts requests to the Kubernetes API server prior to the persistence of the resource but after the request is authenticated and authorized. This is particularly interesting when you want a certain action to be performed on your deployment or pods but want to keep your definition clean.

From the NetBird user and administrator perspective, using an admission controller pattern will allow individuals to define when to add a NetBird side-car container to their workloads with minimal template configuration. This way, they will be able to expose Kubernetes pods to remote users and systems.

Task:

Create a controller that will listen to deployments, pods, and daemon-set creation, and if they have a defined annotation, it will inject a NetBird sidecar into the resource. The controller will need a CRD to configure setup keys using secrets and optional custom management URLs, which, if missing, will default to https://api.netbird.io/.

In this first iteration, we won't need an API client, and the expectation is that the administrator will configure the CRDs on NetBird's management dashboard. We might add a CRD field to cover the expiration date of the key and issue log events to warn administrators when the time is near.

As part of this development, we need to add a helm chart with pre-defined RBAC and Service accounts and CI/CD workflows for testing.

Originally created by @mlsmaycon on GitHub (Jan 24, 2025). Originally assigned to: @mohamed-essam on GitHub. An admission controller is a piece of code that intercepts requests to the Kubernetes API server prior to the persistence of the resource but after the request is authenticated and authorized. This is particularly interesting when you want a certain action to be performed on your deployment or pods but want to keep your definition clean. From the NetBird user and administrator perspective, using an admission controller pattern will allow individuals to define when to add a NetBird side-car container to their workloads with minimal template configuration. This way, they will be able to expose Kubernetes pods to remote users and systems. Task: Create a controller that will listen to deployments, pods, and daemon-set creation, and if they have a defined annotation, it will inject a NetBird sidecar into the resource. The controller will need a CRD to configure setup keys using secrets and optional custom management URLs, which, if missing, will default to https://api.netbird.io/. In this first iteration, we won't need an API client, and the expectation is that the administrator will configure the CRDs on NetBird's management dashboard. We might add a CRD field to cover the expiration date of the key and issue log events to warn administrators when the time is near. As part of this development, we need to add a helm chart with pre-defined RBAC and Service accounts and CI/CD workflows for testing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#1572
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?