SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-10 01:12:51 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Seq in route message should be unique per action, or per route add/delete command #2034

New Issue
Closed
opened 2025-11-20 06:11:34 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 06:11:34 -05:00
Owner
Copy Link

Originally created by @hurricanehrndz on GitHub (Jun 30, 2025).

07d1ad35fc/client/internal/routemanager/systemops/systemops_unix.go (L111)

This should not be static, as per man 4 route,

int rtm_seq; /* for sender to identify action */

this should be unique for each action, please see libp2p-route
https://github.com/libp2p/go-netroute/blob/master/netroute_bsd.go#L151

Originally created by @hurricanehrndz on GitHub (Jun 30, 2025). https://github.com/netbirdio/netbird/blob/07d1ad35fc91729c43383950fc82365a6f057c76/client/internal/routemanager/systemops/systemops_unix.go#L111 This should not be static, as per man 4 route, int rtm_seq; /* for sender to identify action */ this should be unique for each action, please see libp2p-route https://github.com/libp2p/go-netroute/blob/master/netroute_bsd.go#L151
saavagebueno added the clientroutesnetworking labels 2025-11-20 06:11:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label client networking routes
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#2034
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?