SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-17 04:42:24 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

--management-url argument is ignored, reports success for invalid hosts #2440

New Issue
Open
opened 2025-11-20 07:09:50 -05:00 by saavagebueno · 1 comment
saavagebueno commented 2025-11-20 07:09:50 -05:00
Owner
Copy Link

Originally created by @tkloda on GitHub (Nov 4, 2025).

Describe the problem

When using the netbird CLI with the --management-url flag (e.g., netbird up --management-url https://netbird-instance.com), the client incorrectly reports success even when the provided URL is non-existent, arbitrary, or unreachable (e.g., https://foo.com, https://netbird-instance:8400).

The client returns messages like "Already connected" (for netbird up) or "Logging successfully" (for netbird login) without first validating that a connection to the specified management host was successfully established.

This behavior suggests the CLI is either:

1) Ignoring the --management-url argument entirely.

2) Relying on a cached local state that claims "connected" without re-validating.

3) Not performing any connectivity or authentication checks before reporting success.

To Reproduce

  1. Run the up command with the correct management URL:
    netbird up --management-url https://netbird-instance

Expected: client connects and displays connected state (or errors if unreachable).
Observed: "Already connected"

  1. Repeat with bogus/non-existent hosts:
    netbird up --management-url https://foo.example.invalid
    netbird up -- management-url https://foo2.com
    netbird up --management-url https://netbird-instance:8400
    All returned “Already connected”.

Expected behavior

  1. Fail fast & report errors: If the supplied --management-url is unreachable or fails TLS validation, the CLI must return a descriptive error and a non-zero exit code. Do not print “Already connected” or “Logging successfully” unless a successful connection/authentication is confirmed.

  2. Use management URL param: Ensure CLI logic actually uses the --management-url argument for the attempted connection (no silent ignore). Add unit tests covering argument parsing make sure host is used.

Are you using NetBird Cloud?

NetBird self-hosted

NetBird version

0.59.11

Originally created by @tkloda on GitHub (Nov 4, 2025). **Describe the problem** When using the netbird CLI with the --management-url flag (e.g., netbird up --management-url https://netbird-instance.com), the client incorrectly reports success even when the provided URL is non-existent, arbitrary, or unreachable (e.g., https://foo.com, https://netbird-instance:8400). The client returns messages like "Already connected" (for netbird up) or "Logging successfully" (for netbird login) without first validating that a connection to the specified management host was successfully established. This behavior suggests the CLI is either: 1) Ignoring the --management-url argument entirely. 2) Relying on a cached local state that claims "connected" without re-validating. 3) Not performing any connectivity or authentication checks before reporting success. **To Reproduce** 1) Run the up command with the correct management URL: netbird up --management-url https://netbird-instance Expected: client connects and displays connected state (or errors if unreachable). Observed: "Already connected" 2) Repeat with bogus/non-existent hosts: netbird up --management-url https://foo.example.invalid netbird up -- management-url https://foo2.com netbird up --management-url https://netbird-instance:8400 All returned “Already connected”. **Expected behavior** 1) Fail fast & report errors: If the supplied --management-url is unreachable or fails TLS validation, the CLI must return a descriptive error and a non-zero exit code. Do not print “Already connected” or “Logging successfully” unless a successful connection/authentication is confirmed. 2) Use management URL param: Ensure CLI logic actually uses the --management-url argument for the attempted connection (no silent ignore). Add unit tests covering argument parsing make sure host is used. **Are you using NetBird Cloud?** NetBird self-hosted **NetBird version** 0.59.11
saavagebueno added the triage-needed label 2025-11-20 07:09:50 -05:00
saavagebueno commented 2025-11-20 07:09:52 -05:00
Author
Owner
Copy Link

@lixmal commented on GitHub (Nov 4, 2025):

You need to run netbird down first; the setting takes no effect if it is "already connected" just like it says

@lixmal commented on GitHub (Nov 4, 2025): You need to run `netbird down` first; the setting takes no effect if it is "already connected" just like it says
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label triage-needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#2440
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?