[PR #179] [MERGED] Management - add serial to Network reflecting network updates #2591

New Issue

saavagebueno · 2025-11-20T07:11:47-05:00

saavagebueno commented

2025-11-20 07:11:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/179
Author: @braginini
Created: 1/1/2022
Status: ✅ Merged
Merged: 1/14/2022
Merged by: @braginini

Base: main ← Head: add-modification-id

📝 Commits (10+)

9619e66 chore: [management] - add account modification ID
65f32c7 Merge remote-tracking branch 'origin/main' into add-modification-id
a5b23d9 Fix concurrency on the client (#183)
e8e4038 chore: move ModificationId to Network from Account
3a07eaf feature: increment Network modification ID when adding/removing peers
2281d5b chore: extract network struct init to network.go
effbe7a chore: add modificationId test when adding peer to the account
fdc0e20 test: add ModificationID test on AddPeer and DeletePeer
e25b813 refactor: rename modificationId to lastChangeId
a7ab823 refactor: rename lastChangeId to serial - a better fitting name

📊 Changes

31 files changed (+1346 additions, -919 deletions)

View changed files

➕ .github/workflows/golang-test-build.yml (+44 -0)
📝 .github/workflows/golang-test.yml (+14 -40)
📝 client/cmd/up.go (+1 -0)
📝 client/cmd/up_test.go (+1 -1)
➖ client/internal/cond.go (+0 -32)
➖ client/internal/connection.go (+0 -425)
📝 client/internal/engine.go (+154 -166)
➕ client/internal/engine_test.go (+208 -0)
➕ client/internal/peer/conn.go (+421 -0)
➕ client/internal/peer/error.go (+56 -0)
➕ client/internal/peer/status.go (+25 -0)
➕ client/internal/proxy/dummy.go (+68 -0)
➕ client/internal/proxy/proxy.go (+24 -0)
➕ client/internal/proxy/wireguard.go (+121 -0)
➖ client/internal/wgproxy.go (+0 -131)
📝 client/testdata/management.json (+34 -34)
📝 client/testdata/store.json (+12 -1)
📝 iface/iface.go (+3 -6)
📝 iface/iface_darwin.go (+1 -1)
📝 iface/iface_linux.go (+3 -25)

...and 11 more files

📄 Description

Just adds ModificationId property to the Network struct.
it is incremented on:

AddPeer
DeletePeer

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/179 **Author:** [@braginini](https://github.com/braginini) **Created:** 1/1/2022 **Status:** ✅ Merged **Merged:** 1/14/2022 **Merged by:** [@braginini](https://github.com/braginini) **Base:** `main` ← **Head:** `add-modification-id` --- ### 📝 Commits (10+) - [`9619e66`](https://github.com/netbirdio/netbird/commit/9619e66df558c124715ba2a9bed95f287d7a5628) chore: [management] - add account modification ID - [`65f32c7`](https://github.com/netbirdio/netbird/commit/65f32c7b970637e7dd1a08b044df7a2614ab88a5) Merge remote-tracking branch 'origin/main' into add-modification-id - [`a5b23d9`](https://github.com/netbirdio/netbird/commit/a5b23d9b953eb045279294c286ade4273ca6c8bf) Fix concurrency on the client (#183) - [`e8e4038`](https://github.com/netbirdio/netbird/commit/e8e4038d580b516390aba4047915db9f17396498) chore: move ModificationId to Network from Account - [`3a07eaf`](https://github.com/netbirdio/netbird/commit/3a07eaff793d35351ca627ad7abb081530063f49) feature: increment Network modification ID when adding/removing peers - [`2281d5b`](https://github.com/netbirdio/netbird/commit/2281d5beedbe32e823299a6da20af5e4fcb64e41) chore: extract network struct init to network.go - [`effbe7a`](https://github.com/netbirdio/netbird/commit/effbe7a06cacc43b5fb87f2e3cd142184fc5c2e6) chore: add modificationId test when adding peer to the account - [`fdc0e20`](https://github.com/netbirdio/netbird/commit/fdc0e202f471513dbdc71a6d94461fc4489424b3) test: add ModificationID test on AddPeer and DeletePeer - [`e25b813`](https://github.com/netbirdio/netbird/commit/e25b8136b8f6be5ba919ccdea0e554b2e214a1ef) refactor: rename modificationId to lastChangeId - [`a7ab823`](https://github.com/netbirdio/netbird/commit/a7ab8239ee261a52b520469fe2710b9ef04f9073) refactor: rename lastChangeId to serial - a better fitting name ### 📊 Changes **31 files changed** (+1346 additions, -919 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/golang-test-build.yml` (+44 -0) 📝 `.github/workflows/golang-test.yml` (+14 -40) 📝 `client/cmd/up.go` (+1 -0) 📝 `client/cmd/up_test.go` (+1 -1) ➖ `client/internal/cond.go` (+0 -32) ➖ `client/internal/connection.go` (+0 -425) 📝 `client/internal/engine.go` (+154 -166) ➕ `client/internal/engine_test.go` (+208 -0) ➕ `client/internal/peer/conn.go` (+421 -0) ➕ `client/internal/peer/error.go` (+56 -0) ➕ `client/internal/peer/status.go` (+25 -0) ➕ `client/internal/proxy/dummy.go` (+68 -0) ➕ `client/internal/proxy/proxy.go` (+24 -0) ➕ `client/internal/proxy/wireguard.go` (+121 -0) ➖ `client/internal/wgproxy.go` (+0 -131) 📝 `client/testdata/management.json` (+34 -34) 📝 `client/testdata/store.json` (+12 -1) 📝 `iface/iface.go` (+3 -6) 📝 `iface/iface_darwin.go` (+1 -1) 📝 `iface/iface_linux.go` (+3 -25) _...and 11 more files_ </details> ### 📄 Description Just adds ModificationId property to the Network struct. it is incremented on: - AddPeer - DeletePeer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 07:11:47 -05:00

saavagebueno closed this issue

2025-11-20 07:11:47 -05:00

Sign in to join this conversation.

Branches Tags

main

embedded-vnc

fix-dns-fallback-self-loop

claude/webtransport-relay-wasm-mUjY9

claude/vnc-udp-feasibility-6KB1U

readme-cleanup

client/capture-dns-forwarder-port

fix-ssh-authorized-users-multi-rule

fix/wireguard-port-zero

windows-dns-firewall

ui-refactor

fix/wgport-config

feature/refactor-clusters

fix/rosenpass

drop-candidateviaroutes-filter

e2e-windows-dns-combined

refactor-combined

wasm-websocket-dial

feature/affected-peers

dependabot/go_modules/github.com/Azure/go-ntlmssp-0.1.1

debug-logs

reduce-embed-wg-pool

dependabot/go_modules/github.com/jackc/pgx/v5-5.9.2

fix/login-cmd-root-flags

feat/reseller-openapi-spec

github-issue-resolver

add-steamos-support

fix-darwin-uninstaller

flutter-test

dependabot/npm_and_yarn/proxy/web/postcss-8.5.12

ci/freebsd-pkg-bootstrap

cached-serial-check-on-sync

fix-mgmt-cache-bypass-overlay

revert-easyjson-5938

revert-ice-5820

revert-firewalld-5928

refactor/permissions-manager

wasm-js-func-release

revert-dns-5935-systemd-resolved

revert-dns-5935-5945

revert-dns-5945-mgmt-cache

feature/log-most-busy-peers

prototype/ui-wails

coderabbitai/utg/8ae8f20

feature/use-peer-fqdn-on-https

dependabot/go_modules/golang.org/x/image-0.38.0

feature/metrics-push-management-control

release/0.68.3

dependabot/go_modules/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream-1.7.8

dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.97.3

add-slack-channel

claude/rdp-token-passthrough-eNcqW

transparent-proxy

fix/macos-stale-route-eexist

crowdsec-selfhosted

fix/remove-otel-units

entire/checkpoints/v1

dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.4

fix/getting-started

feat/static-connectors-combined-server

feature/use-local-keys-embedded

feature/fleetdm

set-env-only-if-not-fork

feature/expose-has-channel

fix/connection-status-race

fix/filter-cgnat-cni-ice-candidates

feature/check-cert-locker-before-acme

test/proxy-fixes

test/proxy-mtu

prototype/ui-tauri

test/proxy-speed

fix-reused-ports

feat/migrate-to-embedded-idp

feature/add-serial-to-proxy-merged

deploy/proxy-serial

test/connection

feature/disable-legacy-port

feature/flag-to-disable-legacy-port

test/perftest

dependabot/go_modules/github.com/pion/dtls/v3-3.0.11

fix/http-redirect

poc-token-command

dn-reverse-proxy

prototype/reverse-proxy-rename

prototype/reverse-proxy-logs-pagination

feature/client-metrics

prototype/reverse-proxy-clusters

debug-dns-route

fix/win-dns-batch

add-extra-route-logs

job-stream-notify-disconnection-eof

deploy/secrets-manager

trigger-proxy-update

bug/update-ios-client-code-build-tags

sync-client-netmap-serial

log/conn-disconn

nmap/compaction-deploy

ci-win-test

feature/disk-encryption-check

wasm-debug

swap-dns-prio

fix/dex-config

feature/migrate-auto-groups-to-table

dependabot/go_modules/github.com/quic-go/quic-go-0.57.0

nmap/compaction

dex-nocgo-stub

feature/exclude-terraform-from-rate-limiting

test-freebsd

retries-refactor

coderabbitai/docstrings/b7e98ac

feat/integrate-zitadel

bug/ios-hanging-reconection

zitadel-idp

feat/network-map-serial

refactor/get-account-no-users

feat/auto-upgrade

feature/report-high-pat-id

feature/temporary-access-for-resource

fix/nmap-fwrules

dont-restart-dns

prototype/ui

update-gomobile

go-dns-for-ice

wasm-ldflags

test-ldflags

wasmbuild-test

feature/networks-s2s

vk/compare-nmaps

dbg/bothmaps

feature/changeset

reorder-dns-shutdown

fix/relay-reconnection-race

fix/nmap-exitnodes

vk/debug/nmap-both

move-licensed-code

feat/better-daemon-connection-lost-message

feat/auto-update-2

test/timings

refactor/getaccount-raw

tests/nmap-getaccount

refactor/nmap

refactor/nmap-limit-buffer

feature/detect-mac-wakeup

feature/extract-modules

quick-setings

feat/sync-limiter

feature/store-cache-impl

fix-install-version

feature/store-metrics

feature/metrics-on-store

feature/use-gorm-cache

loadtest-signal

unsymmetrical-squash

refactor/reducate-signaling

test/update-reduce

feature/store-cache

feature/remote-debug

cli-ws-proxy-backend-addr

feat/mgmt-map-serial

snyk-fix-d9d0081a4c7f9137bdb59d0d50a141a2

snyk-fix-7415cea5a11acd66753540ca2c598c63

job-yml-update

feature/android-allow-selecting-routes

fix/up-sequence

fix/dns-hash-update

snyk-fix-967adae9863f17f108ce8948d9117b8d

log/getaccount-by-peer

signal-suppressor

dns-exit-node

feature/auto-updates

feature/cache-srv-key

merged-fixes

fix/missed-offers-and-debug

debug-and-fixes

poc-wasm-clean-backend-s2s

test/remote-debug

debug-api

dependabot/go_modules/github.com/docker/docker-28.0.0incompatible

fix/remove-gpo-if-empty

fix/test-freebsd

fix/mysql-setup

fix/remove-logout-btn

handle-existing-domain-user

chore/unify-domain-validation

snyk-fix-c5fafc8a50ce1f29046e25a1fc346185

feat/profile-edit-btn

snyk-fix-a54966211e18d4cf67e5a2757cc006d1

log-short-id

feat/logout-ephemeral

log-checks

batch-wg-ops

nb-interface-default

feat/aws-integration

add/race-test

feature/relay-feature-versioning

fix/systemd-service-logs

poc/preprocessed-map

add-account-onboarding

bind-ipv6

fix/merge-main

logs/peerlogs-addpeer

feature/net-297-network-migration

feature/support-skip-auto-apply-exit-node-routes

set-cmd

set-command-with-cursor

feature/limit-update-channel

stop-using-locking-share

feature/poc-lazy-detection

feature/net-248-removal-of-sync-mutex-locks

test/multiple-peer-logging

preresolve

add-ns-punnycode-support

apply-routes-early

windows-search-domains

fix/connecting-route-filter

feature/management/rest-client/impersonate

debug-local-records

resource-fields-snake-case

test/grpc-rate-limit

traffic-correlation-policy

feature/rest-client-options

feat/events-metrics

feature/buf-cli

test/add-ratelimiter

test/remove-write-lock-on-add-peer

fix/add-peer-semaphore

feature/users-roles-endpoint

mlsmaycon-patch-1

debug-user-role

chore/primary-key-on-networks

feature/update-account-peers-buffer-startup

remove-ubuntu2004-runners

refactor/permissions-no-pat-allowed

ref/logrus-factory

use-conntrack-zone

deploy/permissions-account

feature/lazy-connection-idle

ref/improve-test-cov

restore-pr-3440

test/increase-grpc-timeouts

feat/buffer-account-peers-update

test/networkmapgeneration-changes

feature/base-manager

feature/flow-receiver

chore/benchmark-with-large-runner

refactor/handshake-initiator

client/ui-update-systray-icons

userspace-router

wgwatcher-test

output-if-key-already-exists

fix/relay-reconnection

feature/port-forwarding-client-codecleaning

detached2

test/callbacks-nil-iceconninfo

refactor/optimize-peer-expiration

enable-udp-port-for-docker-template

fix/relay-update

feature/apply-posture-netmap

fix/group-update-existing-resource

conntrack-stats

upgrade-okta-sdk

multi-price

test/conn-stat

set-min-parallel-tests-for-management

dns-interceptor

debug-dns

router-dns

add-static-system-info

debug-0.29.4

debug-0.33.0

account-refactoring

relay/2800_quic

route-get-account-refactoring

test/seed-random-routes

feature/get-account-refactoring

test/reconnect-race-condition

refactor/get-account-usage

feature/add-session-id-to-update-channel

improve-ipv4conn

fix/async-pion-event-handling

debug

add-offload

feature/validate-group-association-debug

fix/limit-conn-for-sqlite

test/engine-iface

test/transaction-for-jwt-sync

fix/engine-stop-in-foreground

feature/add-mysql-support

test-migration

refactor/header-size-values

relay/eliminate-gob

test/signal-dispatcher-with-relay

relay/debug

validate-icon

feature/ipv6-support

use-pre-expanded-peers-map

feature/use-signal-dispatcher

validate/peer-status

add-read-write-times

fix/sync-peer-race

feature/relay-status

netmap

evaluate/network-map-hash

fix/lower-dns-resolve-interval-on-fail

feature/relay

fix/go-mod-version

upgrade-nftables

synology-userspace-mode

fix/use-ip-for-default-routes-on-darwin

fix/proxy_close

enable-release-workflow-on-pr

deploy/peer-performance

feature/permanent-turn

feature/permanent-turn-proxy

deploy/posture-check-sqlite

feature/optimize_sqlite_save

debug-ios-behavior

fix/delete-route-only-after-adding

tshoot/windows-logger

remove-new-routing

refactor/eliminate-repo-dependency

add-arm-to-ci

refactor-demo-account-object

test/abc2

test/abc

send-ssh-rosenpass-config-meta

refactor-demo

ensure-schedule-never-runs-non-positive

feature/peer-validator-groupmgm

feature/peer-validator-fix

fix/include-active-dashboard-users

fix/handle-canceling-schedule

fix/geo-download

debug-google-workspace

yury/resolve-ip-to-location

feature/extend-sysinfo

sqlite-async-peer-status

yury/add-postgresql-store

fix/route

test-build

posture-checks-poc

debug-keycloak-idp

poc/netstack

for-pascal-tmp

peer-logout-management

manual-peer-logout

detached

chore/refactor-management

test/dns-bind

fix/enforce-acl-for-containers

yury/use-sync-map-in-updatechannel

fix/events-key-handling

filter-cache-on-load-account

fix/user-expiration

handle-user-context-cancellation

nb-client-k8s-statefulset

fake-addr

fix/iptables_in_docker

ebpf-debug

update-getting-started-flow-use-postgres

fix/peer_list_notification

feature/device-authentication-with-client-secret

feature/keep_alive

feat-groups-from-jwt

separate_proxy_from_wgconfig

fix/wg_conn

wg_conn_fix

wg_bind_parallel_processing

fix-rollback-get-acls

proxy_cfg_cleanup

performance-improvement-rego

update-lock-log-level

feat-client-side-acl

refactor/move_grpcserver_logic_to_account_manager

feature/event-storage

feature/update-idp-redeeming-invite

feature/api-peer-info

return-groupminimum-setupkey

feature/interface-bind

documentation_enhancement

fix-peer-registration

ssh

users_cache

pass-client-caller

client_caller_type

revert-283-feat-fix-windows-installer

periodic-peer-updates

ebpf

braginini/wasm

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SVI/netbird#2591