[PR #191] [MERGED] Change Management Sync protocol to support incremental (serial) network changes #2598

New Issue

saavagebueno · 2025-11-20T07:11:49-05:00

saavagebueno commented

2025-11-20 07:11:49 -05:00

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/191
Author: @braginini
Created: 1/14/2022
Status: ✅ Merged
Merged: 1/16/2022
Merged by: @braginini

Base: main ← Head: pass-network-serial-to-cleints

📝 Commits (10+)

282d633 feature: introduce NetworkMap to the management protocol with a Serial ID
ecc66af test: add Management Sync method protocol test
b76198b test: add Management Sync method NetworkMap field check [FAILING]
fb6e6f6 test: add Management Sync method NetworkMap field check [FAILING]
fff0618 feature: fill NetworkMap property to when Deleting peer
0696137 feature: fill NetworkMap in the Sync protocol
c082b5c test: code review mentions - GeneratePrivateKey() in the test
d568173 fix: wiretrustee client use wireguard GeneratePrivateKey() instead of GenerateKey()
80abe29 test: add NetworkMap test
12cdad9 fix: management_proto test remove store.json on test finish

📊 Changes

9 files changed (+777 additions, -152 deletions)

View changed files

📝 client/internal/config.go (+1 -1)
📝 management/proto/management.pb.go (+277 -134)
📝 management/proto/management.proto (+29 -0)
📝 management/server/account_test.go (+3 -3)
📝 management/server/grpcserver.go (+15 -8)
➕ management/server/management_proto_test.go (+348 -0)
📝 management/server/network.go (+5 -0)
📝 management/server/peer.go (+23 -6)
➕ management/server/peer_test.go (+76 -0)

📄 Description

Only Management Service changes + Protocol.
Client will be done in the following PR

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/191 **Author:** [@braginini](https://github.com/braginini) **Created:** 1/14/2022 **Status:** ✅ Merged **Merged:** 1/16/2022 **Merged by:** [@braginini](https://github.com/braginini) **Base:** `main` ← **Head:** `pass-network-serial-to-cleints` --- ### 📝 Commits (10+) - [`282d633`](https://github.com/netbirdio/netbird/commit/282d63301a0bc09131ca65625aaffa8a415f260a) feature: introduce NetworkMap to the management protocol with a Serial ID - [`ecc66af`](https://github.com/netbirdio/netbird/commit/ecc66afc1ac7ffc0f0b73adda18ac75fef1faf7c) test: add Management Sync method protocol test - [`b76198b`](https://github.com/netbirdio/netbird/commit/b76198b5849a882e0aa67475da77f412a1575941) test: add Management Sync method NetworkMap field check [FAILING] - [`fb6e6f6`](https://github.com/netbirdio/netbird/commit/fb6e6f625c2388239d06d5c2440747a6b4ec1a3f) test: add Management Sync method NetworkMap field check [FAILING] - [`fff0618`](https://github.com/netbirdio/netbird/commit/fff061817e854bd1982aacebd070af4ed3cfa3ea) feature: fill NetworkMap property to when Deleting peer - [`0696137`](https://github.com/netbirdio/netbird/commit/0696137c943c88f18c58eecf3bc0f80a66710d8e) feature: fill NetworkMap in the Sync protocol - [`c082b5c`](https://github.com/netbirdio/netbird/commit/c082b5c81ca9f83fdfbdb38df3efe8bffa51acce) test: code review mentions - GeneratePrivateKey() in the test - [`d568173`](https://github.com/netbirdio/netbird/commit/d5681734513b0d33ff51fd56e9df295cb43b21db) fix: wiretrustee client use wireguard GeneratePrivateKey() instead of GenerateKey() - [`80abe29`](https://github.com/netbirdio/netbird/commit/80abe291d1814403c52715731e3af0e7d6711db5) test: add NetworkMap test - [`12cdad9`](https://github.com/netbirdio/netbird/commit/12cdad97eb0d24f06b7bf4ac9b703c4f8dc6b7ce) fix: management_proto test remove store.json on test finish ### 📊 Changes **9 files changed** (+777 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `client/internal/config.go` (+1 -1) 📝 `management/proto/management.pb.go` (+277 -134) 📝 `management/proto/management.proto` (+29 -0) 📝 `management/server/account_test.go` (+3 -3) 📝 `management/server/grpcserver.go` (+15 -8) ➕ `management/server/management_proto_test.go` (+348 -0) 📝 `management/server/network.go` (+5 -0) 📝 `management/server/peer.go` (+23 -6) ➕ `management/server/peer_test.go` (+76 -0) </details> ### 📄 Description Only Management Service changes + Protocol. Client will be done in the following PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 07:11:49 -05:00

saavagebueno closed this issue

2025-11-20 07:11:49 -05:00

saavagebueno referenced this issue

2025-11-20 08:06:02 -05:00

[PR #2598] Change heartbeat timeout #3438

Sign in to join this conversation.

Branches Tags

main

feature/affected-peers

dependabot/go_modules/github.com/Azure/go-ntlmssp-0.1.1

debug-logs

ui-refactor

drop-dns-probes

improve-usp-fw

reduce-embed-wg-pool

dns-skip-failover-on-ede

feat/byod-proxy

windows-dns-firewall

fix/relay-healthcheck-non-standard-port

fix/login-persist-url-flags

ssh-config-tmp-cleanup

dependabot/go_modules/github.com/jackc/pgx/v5-5.9.2

fix/login-cmd-root-flags

feat/reseller-openapi-spec

github-issue-resolver

add-steamos-support

fix-darwin-uninstaller

flutter-test

dependabot/npm_and_yarn/proxy/web/postcss-8.5.12

ci/freebsd-pkg-bootstrap

cached-serial-check-on-sync

fix-mgmt-cache-bypass-overlay

revert-easyjson-5938

revert-ice-5820

revert-firewalld-5928

refactor/permissions-manager

wasm-js-func-release

wasm-websocket-dial

revert-dns-5935-systemd-resolved

revert-dns-5935-5945

revert-dns-5945-mgmt-cache

feature/log-most-busy-peers

prototype/ui-wails

vnc-server

coderabbitai/utg/8ae8f20

feature/use-peer-fqdn-on-https

dependabot/go_modules/golang.org/x/image-0.38.0

feature/metrics-push-management-control

release/0.68.3

dependabot/go_modules/github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream-1.7.8

dependabot/go_modules/github.com/aws/aws-sdk-go-v2/service/s3-1.97.3

add-slack-channel

claude/rdp-token-passthrough-eNcqW

transparent-proxy

fix/macos-stale-route-eexist

crowdsec-selfhosted

fix/remove-otel-units

entire/checkpoints/v1

dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.4

fix/getting-started

feat/static-connectors-combined-server

feature/use-local-keys-embedded

feature/fleetdm

set-env-only-if-not-fork

feature/expose-has-channel

fix/connection-status-race

fix/filter-cgnat-cni-ice-candidates

feature/check-cert-locker-before-acme

test/proxy-fixes

test/proxy-mtu

prototype/ui-tauri

test/proxy-speed

fix-reused-ports

feat/migrate-to-embedded-idp

feature/add-serial-to-proxy-merged

deploy/proxy-serial

test/connection

feature/disable-legacy-port

feature/flag-to-disable-legacy-port

test/perftest

dependabot/go_modules/github.com/pion/dtls/v3-3.0.11

fix/http-redirect

poc-token-command

dn-reverse-proxy

prototype/reverse-proxy-rename

prototype/reverse-proxy-logs-pagination

feature/client-metrics

prototype/reverse-proxy-clusters

debug-dns-route

fix/win-dns-batch

add-extra-route-logs

job-stream-notify-disconnection-eof

deploy/secrets-manager

trigger-proxy-update

bug/update-ios-client-code-build-tags

sync-client-netmap-serial

log/conn-disconn

nmap/compaction-deploy

ci-win-test

feature/disk-encryption-check

wasm-debug

swap-dns-prio

fix/dex-config

feature/migrate-auto-groups-to-table

dependabot/go_modules/github.com/quic-go/quic-go-0.57.0

nmap/compaction

dex-nocgo-stub

feature/exclude-terraform-from-rate-limiting

test-freebsd

retries-refactor

coderabbitai/docstrings/b7e98ac

feat/integrate-zitadel

bug/ios-hanging-reconection

zitadel-idp

feat/network-map-serial

refactor/get-account-no-users

feat/auto-upgrade

feature/report-high-pat-id

feature/temporary-access-for-resource

fix/nmap-fwrules

dont-restart-dns

prototype/ui

update-gomobile

go-dns-for-ice

wasm-ldflags

test-ldflags

wasmbuild-test

feature/networks-s2s

vk/compare-nmaps

dbg/bothmaps

feature/changeset

reorder-dns-shutdown

fix/relay-reconnection-race

fix/nmap-exitnodes

vk/debug/nmap-both

move-licensed-code

feat/better-daemon-connection-lost-message

feat/auto-update-2

test/timings

refactor/getaccount-raw

tests/nmap-getaccount

refactor/nmap

refactor/nmap-limit-buffer

feature/detect-mac-wakeup

feature/extract-modules

quick-setings

feat/sync-limiter

feature/store-cache-impl

fix-install-version

feature/store-metrics

feature/metrics-on-store

feature/use-gorm-cache

loadtest-signal

unsymmetrical-squash

refactor/reducate-signaling

test/update-reduce

feature/store-cache

feature/remote-debug

cli-ws-proxy-backend-addr

feat/mgmt-map-serial

snyk-fix-d9d0081a4c7f9137bdb59d0d50a141a2

snyk-fix-7415cea5a11acd66753540ca2c598c63

job-yml-update

feature/android-allow-selecting-routes

fix/up-sequence

fix/dns-hash-update

snyk-fix-967adae9863f17f108ce8948d9117b8d

log/getaccount-by-peer

signal-suppressor

dns-exit-node

feature/auto-updates

feature/cache-srv-key

merged-fixes

fix/missed-offers-and-debug

debug-and-fixes

poc-wasm-clean-backend-s2s

test/remote-debug

debug-api

dependabot/go_modules/github.com/docker/docker-28.0.0incompatible

fix/remove-gpo-if-empty

fix/test-freebsd

fix/mysql-setup

fix/remove-logout-btn

handle-existing-domain-user

chore/unify-domain-validation

snyk-fix-c5fafc8a50ce1f29046e25a1fc346185

feat/profile-edit-btn

snyk-fix-a54966211e18d4cf67e5a2757cc006d1

log-short-id

feat/logout-ephemeral

log-checks

batch-wg-ops

nb-interface-default

feat/aws-integration

add/race-test

feature/relay-feature-versioning

fix/systemd-service-logs

poc/preprocessed-map

add-account-onboarding

bind-ipv6

fix/merge-main

logs/peerlogs-addpeer

feature/net-297-network-migration

feature/support-skip-auto-apply-exit-node-routes

set-cmd

set-command-with-cursor

feature/limit-update-channel

stop-using-locking-share

feature/poc-lazy-detection

feature/net-248-removal-of-sync-mutex-locks

test/multiple-peer-logging

preresolve

add-ns-punnycode-support

apply-routes-early

windows-search-domains

fix/connecting-route-filter

feature/management/rest-client/impersonate

debug-local-records

resource-fields-snake-case

test/grpc-rate-limit

traffic-correlation-policy

feature/rest-client-options

feat/events-metrics

feature/buf-cli

test/add-ratelimiter

test/remove-write-lock-on-add-peer

fix/add-peer-semaphore

feature/users-roles-endpoint

mlsmaycon-patch-1

debug-user-role

chore/primary-key-on-networks

feature/update-account-peers-buffer-startup

remove-ubuntu2004-runners

refactor/permissions-no-pat-allowed

ref/logrus-factory

use-conntrack-zone

deploy/permissions-account

feature/lazy-connection-idle

ref/improve-test-cov

restore-pr-3440

test/increase-grpc-timeouts

feat/buffer-account-peers-update

test/networkmapgeneration-changes

feature/base-manager

feature/flow-receiver

chore/benchmark-with-large-runner

refactor/handshake-initiator

client/ui-update-systray-icons

userspace-router

wgwatcher-test

output-if-key-already-exists

fix/relay-reconnection

feature/port-forwarding-client-codecleaning

detached2

test/callbacks-nil-iceconninfo

refactor/optimize-peer-expiration

enable-udp-port-for-docker-template

fix/relay-update

feature/apply-posture-netmap

fix/group-update-existing-resource

conntrack-stats

upgrade-okta-sdk

multi-price

test/conn-stat

set-min-parallel-tests-for-management

dns-interceptor

debug-dns

router-dns

add-static-system-info

debug-0.29.4

debug-0.33.0

account-refactoring

relay/2800_quic

route-get-account-refactoring

test/seed-random-routes

feature/get-account-refactoring

test/reconnect-race-condition

refactor/get-account-usage

feature/add-session-id-to-update-channel

improve-ipv4conn

fix/async-pion-event-handling

debug

add-offload

feature/validate-group-association-debug

fix/limit-conn-for-sqlite

test/engine-iface

test/transaction-for-jwt-sync

fix/engine-stop-in-foreground

feature/add-mysql-support

test-migration

refactor/header-size-values

relay/eliminate-gob

test/signal-dispatcher-with-relay

relay/debug

validate-icon

feature/ipv6-support

use-pre-expanded-peers-map

feature/use-signal-dispatcher

validate/peer-status

add-read-write-times

fix/sync-peer-race

feature/relay-status

netmap

evaluate/network-map-hash

fix/lower-dns-resolve-interval-on-fail

feature/relay

fix/go-mod-version

upgrade-nftables

synology-userspace-mode

fix/use-ip-for-default-routes-on-darwin

fix/proxy_close

enable-release-workflow-on-pr

deploy/peer-performance

feature/permanent-turn

feature/permanent-turn-proxy

deploy/posture-check-sqlite

feature/optimize_sqlite_save

debug-ios-behavior

fix/delete-route-only-after-adding

tshoot/windows-logger

remove-new-routing

refactor/eliminate-repo-dependency

add-arm-to-ci

refactor-demo-account-object

test/abc2

test/abc

send-ssh-rosenpass-config-meta

refactor-demo

ensure-schedule-never-runs-non-positive

feature/peer-validator-groupmgm

feature/peer-validator-fix

fix/include-active-dashboard-users

fix/handle-canceling-schedule

fix/geo-download

debug-google-workspace

yury/resolve-ip-to-location

feature/extend-sysinfo

sqlite-async-peer-status

yury/add-postgresql-store

fix/route

test-build

posture-checks-poc

debug-keycloak-idp

poc/netstack

for-pascal-tmp

peer-logout-management

manual-peer-logout

detached

chore/refactor-management

test/dns-bind

fix/enforce-acl-for-containers

yury/use-sync-map-in-updatechannel

fix/events-key-handling

filter-cache-on-load-account

fix/user-expiration

handle-user-context-cancellation

nb-client-k8s-statefulset

fake-addr

fix/iptables_in_docker

ebpf-debug

update-getting-started-flow-use-postgres

fix/peer_list_notification

feature/device-authentication-with-client-secret

feature/keep_alive

feat-groups-from-jwt

separate_proxy_from_wgconfig

fix/wg_conn

wg_conn_fix

wg_bind_parallel_processing

fix-rollback-get-acls

proxy_cfg_cleanup

performance-improvement-rego

update-lock-log-level

feat-client-side-acl

refactor/move_grpcserver_logic_to_account_manager

feature/event-storage

feature/update-idp-redeeming-invite

feature/api-peer-info

return-groupminimum-setupkey

feature/interface-bind

documentation_enhancement

fix-peer-registration

ssh

users_cache

pass-client-caller

client_caller_type

revert-283-feat-fix-windows-installer

periodic-peer-updates

ebpf

braginini/wasm

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SVI/netbird#2598