SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-10 17:31:53 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[PR #252] [MERGED] Handle category change with provided Acc Id #2653

New Issue
Closed
opened 2025-11-20 07:12:07 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 07:12:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/252
Author: @mlsmaycon
Created: 3/9/2022
Status: ✅ Merged
Merged: 3/9/2022
Merged by: @mlsmaycon

Base: main ← Head: handle-unclassified-to-private-case

📝 Commits (1)

  • b542a99 Handle category change with provided Acc Id

📊 Changes

2 files changed (+64 additions, -30 deletions)

View changed files

📝 management/server/account.go (+9 -1)
📝 management/server/account_test.go (+55 -29)

📄 Description

When an account id supplied via a claim, we should handle the change of the domain classification.

If the category of domain changes to private, we should re-evaluate the private account

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/252 **Author:** [@mlsmaycon](https://github.com/mlsmaycon) **Created:** 3/9/2022 **Status:** ✅ Merged **Merged:** 3/9/2022 **Merged by:** [@mlsmaycon](https://github.com/mlsmaycon) **Base:** `main` ← **Head:** `handle-unclassified-to-private-case` --- ### 📝 Commits (1) - [`b542a99`](https://github.com/netbirdio/netbird/commit/b542a994ae4421346c8a83af054ccb32d42ca823) Handle category change with provided Acc Id ### 📊 Changes **2 files changed** (+64 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `management/server/account.go` (+9 -1) 📝 `management/server/account_test.go` (+55 -29) </details> ### 📄 Description When an account id supplied via a claim, we should handle the change of the domain classification. If the category of domain changes to private, we should re-evaluate the private account --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 07:12:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#2653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?