SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-14 04:01:55 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[PR #680] Mobile prerefactor #2833

New Issue
Open
opened 2025-11-20 08:04:07 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:04:07 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/netbirdio/netbird/pull/680

State: closed
Merged: Yes

Describe your changes

Small code cleaning in the iface package. These changes necessary to get a clean code in case if we involve more platforms.
The OS related functions has been distributed into separate files and it has been mixed with not OS related logic. The goal is to get a clear picture of the layer between Wirequard and business logic.

Main problem

Unfortunately the Android implementation of Wrieguard tool does not fit with the original Wireguard approach.
Until now the service communicated with the wireguard device via wgctrl package on every OS. In Android it is not possible so we have to create some new function what doing almost the same what the wgctrl did. I would like to provide a well layered solution.

Changes

  • Remove unused variables
  • Set to private some variables what is not used externally
  • We have OS related implementations so remove the 'if runtime.GOOS != "windows"' expression
  • Eliminate spagetti style function calls inside WGIface struct across several files.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary
**Original Pull Request:** https://github.com/netbirdio/netbird/pull/680 **State:** closed **Merged:** Yes --- ## Describe your changes Small code cleaning in the iface package. These changes necessary to get a clean code in case if we involve more platforms. The OS related functions has been distributed into separate files and it has been mixed with not OS related logic. The goal is to get a clear picture of the layer between Wirequard and business logic. ## Main problem Unfortunately the Android implementation of Wrieguard tool does not fit with the original Wireguard approach. Until now the service communicated with the wireguard device via wgctrl package on every OS. In Android it is not possible so we have to create some new function what doing almost the same what the wgctrl did. I would like to provide a well layered solution. ## Changes - Remove unused variables - Set to private some variables what is not used externally - We have OS related implementations so remove the 'if runtime.GOOS != "windows"' expression - Eliminate spagetti style function calls inside WGIface struct across several files. ## Issue ticket number and link ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [x] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
saavagebueno added the pull-request label 2025-11-20 08:04:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#2833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?