[PR #1660] Send terminal notification on peer session expiry #3186

Open
opened 2025-11-20 08:05:14 -05:00 by saavagebueno · 0 comments
Owner

Original Pull Request: https://github.com/netbirdio/netbird/pull/1660

State: closed
Merged: Yes


Describe your changes

Upon expiration of the user session in Linux and macOS, a notification will be sent via the active terminal. However, if the UI application is installed, the terminal notification will not be sent, as the UI application will handle the notification instead.

Screenshot 2024-03-04 at 19 58 58

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary
**Original Pull Request:** https://github.com/netbirdio/netbird/pull/1660 **State:** closed **Merged:** Yes --- ## Describe your changes Upon expiration of the user session in Linux and macOS, a notification will be sent via the active terminal. However, if the UI application is installed, the terminal notification will not be sent, as the UI application will handle the notification instead. ![Screenshot 2024-03-04 at 19 58 58](https://github.com/netbirdio/netbird/assets/8535888/7a51ab45-e244-4c7c-89f3-718394fe87f8) ## Issue ticket number and link ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
saavagebueno added the pull-request label 2025-11-20 08:05:14 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#3186