SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-11 18:51:53 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[PR #1847] Add account locks to getAccountWithAuthorizationClaims method #3229

New Issue
Open
opened 2025-11-20 08:05:22 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:05:22 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/netbirdio/netbird/pull/1847

State: closed
Merged: Yes

Describe your changes

There was a race condition within the getAccountWithAuthorizationClaims method which was causing some operations to not store the updated data properly in the backend because it was overwriting with an old state. This PR adds account locks to this method to avoid overwriting.

How I reproduced:

  • make sure you reach line 1782 in account.go (either remove the top conditions or use single account mode and change your env)
  • add a random sleep between 0 and 2 seconds either in the updateAccountDomainAttributes right before the SaveAccount (line 1420) or within the SaveAccount method itself like
time.Sleep(time.Duration(rand.Float64() * float64(time.Second)))
  • add a process querying any api endpoint so that the domain attributes get updated with a small enough frequency like
while true; do
 curl --request GET --url http://localhost/api/setup-keys --header 'Authorization: Token <PAT>' >/dev/null 2>&1
 sleep 0.2
done
  • try to create a setup key
curl --request POST --url http://localhost/api/setup-keys --header 'Accept: application/json' --header 'Authorization: Token <PAT>' --header 'Content-Type: application/json' --data '{"name":"key1","type":"one-off","expires_in":604800,"revoked":false,"auto_groups":[],"usage_limit":1,"ephemeral":false}'

For the majority of attempts, this will not work and the key is not persistent in the database even though the API returns with success.

Issue ticket number and link

https://github.com/netbirdio/dashboard/issues/371

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary
**Original Pull Request:** https://github.com/netbirdio/netbird/pull/1847 **State:** closed **Merged:** Yes --- ## Describe your changes There was a race condition within the `getAccountWithAuthorizationClaims` method which was causing some operations to not store the updated data properly in the backend because it was overwriting with an old state. This PR adds account locks to this method to avoid overwriting. How I reproduced: - make sure you reach line 1782 in account.go (either remove the top conditions or use single account mode and change your env) - add a random sleep between 0 and 2 seconds either in the `updateAccountDomainAttributes` right before the `SaveAccount` (line 1420) or within the `SaveAccount` method itself like ``` time.Sleep(time.Duration(rand.Float64() * float64(time.Second))) ``` - add a process querying any api endpoint so that the domain attributes get updated with a small enough frequency like ``` while true; do curl --request GET --url http://localhost/api/setup-keys --header 'Authorization: Token <PAT>' >/dev/null 2>&1 sleep 0.2 done ``` - try to create a setup key ``` curl --request POST --url http://localhost/api/setup-keys --header 'Accept: application/json' --header 'Authorization: Token <PAT>' --header 'Content-Type: application/json' --data '{"name":"key1","type":"one-off","expires_in":604800,"revoked":false,"auto_groups":[],"usage_limit":1,"ephemeral":false}' ``` For the majority of attempts, this will not work and the key is not persistent in the database even though the API returns with success. ## Issue ticket number and link https://github.com/netbirdio/dashboard/issues/371 ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
saavagebueno added the pull-request label 2025-11-20 08:05:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#3229
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?