SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-07-22 05:53:39 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[PR #2298] Add network route access control on client #3347

New Issue
Open
opened 2025-11-20 08:05:44 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:05:44 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/netbirdio/netbird/pull/2298

State: closed
Merged: Yes

Describe your changes

Add:

  • Methods to set up forward rules for routed traffic (network ACLs) according to the network map
    Modify:
  • Apply ACLs in engine as early as possible to avoid security issues
  • Insert instead of append all netbird rules in existing input/output/forward chains
  • Rename existing ACLs to "peer ACLs"
  • Use dedicated type for route ID where possible
  • Use netip.Prefix instead of string where possible

Fix:

  • Management proto and network map:
    • Add default return traffic permit when there's no ACL applied to the network route
    • Fix missing protocol in default rules
    • Partically add IPv6 rules to DNS routes

Remove:

  • Default accept in forward chains
  • Rules in prerouting chains
  • Fwmark accept rules in output chains
  • Src addresses in output chains
  • Dst addresses in input chains
  • Dysfunctional rule in output chains
  • Accept traffic initiated by routed networks behind routing peers in input chains

The prerouting/fwmark parts were used as substitutes for route ACLs to prevent locally routed networks (e.g. containers) from bypassing the input rules (because forward rules match the traffic).

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary
**Original Pull Request:** https://github.com/netbirdio/netbird/pull/2298 **State:** closed **Merged:** Yes --- ## Describe your changes Add: - Methods to set up forward rules for routed traffic (network ACLs) according to the network map Modify: - Apply ACLs in engine as early as possible to avoid security issues - Insert instead of append all netbird rules in existing input/output/forward chains - Rename existing ACLs to "peer ACLs" - Use dedicated type for route ID where possible - Use `netip.Prefix` instead of `string` where possible Fix: - Management proto and network map: - Add default return traffic permit when there's no ACL applied to the network route - Fix missing protocol in default rules - Partically add IPv6 rules to DNS routes Remove: - Default accept in forward chains - Rules in prerouting chains - Fwmark accept rules in output chains - Src addresses in output chains - Dst addresses in input chains - Dysfunctional rule in output chains - Accept traffic initiated by routed networks behind routing peers in input chains The prerouting/fwmark parts were used as substitutes for route ACLs to prevent locally routed networks (e.g. containers) from bypassing the input rules (because forward rules match the traffic). ## Issue ticket number and link ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [x] It is a refactor - [x] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
saavagebueno added the pull-request label 2025-11-20 08:05:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#3347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?