SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-07-27 16:32:34 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[PR #2798] [client] Fix multiple peer name filtering in netbird status command #3492

New Issue
Open
opened 2025-11-20 08:06:11 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:06:11 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/netbirdio/netbird/pull/2798

State: closed
Merged: Yes

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Description

The current implementation of peer name filtering in the skipDetailByFilters function has a logic issue that prevents filtering by multiple peer names. This PR fixes the issue by:

Changing the initial value of nameEval to true (meaning skip by default)
Inverting the logic to look for matches instead of non-matches
Setting nameEval = false when a match is found (meaning don't skip)

Before the fix:

  • When using --filter-by-names peer-01,peer-02.netbird.cloud, the command would fail to show both peers because:
  1. The function would set nameEval = true if ANY name didn't match
  2. This caused peers to be skipped even if they matched one of the filters

After the fix:

  • The new logic starts with nameEval = true (skip by default)
  • When a peer's FQDN matches ANY of the provided filters, nameEval is set to false
  • This allows the command to properly show all peers that match any of the provided name filters

Example:

Bash

netbird status -d --filter-by-names peer-01,peer-02.netbird.cloud

Now correctly shows both peers that match either name.

Testing:

  • Tested with single peer name filter
  • Tested with multiple peer name filters
  • Tested in combination with other filters (status, IPs)

This fix maintains compatibility with existing functionality while correctly implementing the intended multiple peer name filtering behavior.

**Original Pull Request:** https://github.com/netbirdio/netbird/pull/2798 **State:** closed **Merged:** Yes --- ## Describe your changes ## Issue ticket number and link ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary ## Description The current implementation of peer name filtering in the `skipDetailByFilters` function has a logic issue that prevents filtering by multiple peer names. This PR fixes the issue by: Changing the initial value of `nameEval` to `true` (meaning skip by default) Inverting the logic to look for matches instead of non-matches Setting `nameEval = false` when a match is found (meaning don't skip) ### Before the fix: - When using `--filter-by-names peer-01,peer-02.netbird.cloud`, the command would fail to show both peers because: 1) The function would set nameEval = true if **ANY** name didn't match 2) This caused peers to be skipped even if they matched one of the filters ### After the fix: - The new logic starts with `nameEval = true` (skip by default) - When a peer's FQDN matches **ANY** of the provided filters, `nameEval` is set to false - This allows the command to properly show all peers that match any of the provided name filters ## Example: **Bash** ``` netbird status -d --filter-by-names peer-01,peer-02.netbird.cloud ``` Now correctly shows both peers that match either name. ## Testing: - Tested with single peer name filter - Tested with multiple peer name filters - Tested in combination with other filters (status, IPs) This fix maintains compatibility with existing functionality while correctly implementing the intended multiple peer name filtering behavior.
saavagebueno added the pull-request label 2025-11-20 08:06:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#3492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?