SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-10 17:31:53 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

[PR #4241] [client] Disable the dns host manager properly if disabled through management #4157

New Issue
Open
opened 2025-11-20 08:07:50 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 08:07:50 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/netbirdio/netbird/pull/4241

State: closed
Merged: Yes

Describe your changes

This PR fixes several DNS manager cleanup issues:

  1. DNS not cleaned up when disabled via management
  • Start with DNS enabled in management
  • Run netbird up
  • Disable DNS in management
  • Result: Host DNS still points to NetBird's IP instead of being restored (e.g., /etc/resolv.conf on Linux, but varies by system)
  1. Invalid IP in host DNS when starting with DNS disabled
  • Start with DNS disabled in management
  • Run netbird up
  • Result: Host DNS configuration gets an invalid IP address
  1. Deadlock during shutdown after DNS disable/enable cycle
  • Start with DNS disabled in management
  • Run netbird up
  • Enable DNS, then disable it again via management
  • Run netbird down
  • Result: DNS cleanup hangs and blocks shutdown
  1. Client DNS flags ignored after management DNS toggle
  • Start with DNS disabled on client (via --disable-dns flag or netstack mode)
  • Management has DNS enabled
  • Run netbird up - correctly no host DNS changes
  • Toggle DNS off then on again in management
  • Result: Client DNS becomes active, ignoring the client-side disable flag

Issue ticket number and link

#4236

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

**Original Pull Request:** https://github.com/netbirdio/netbird/pull/4241 **State:** closed **Merged:** Yes --- ## Describe your changes This PR fixes several DNS manager cleanup issues: 1. DNS not cleaned up when disabled via management - Start with DNS enabled in management - Run netbird up - Disable DNS in management - Result: Host DNS still points to NetBird's IP instead of being restored (e.g., /etc/resolv.conf on Linux, but varies by system) 2. Invalid IP in host DNS when starting with DNS disabled - Start with DNS disabled in management - Run netbird up - Result: Host DNS configuration gets an invalid IP address 3. Deadlock during shutdown after DNS disable/enable cycle - Start with DNS disabled in management - Run netbird up - Enable DNS, then disable it again via management - Run netbird down - Result: DNS cleanup hangs and blocks shutdown 4. Client DNS flags ignored after management DNS toggle - Start with DNS disabled on client (via --disable-dns flag or netstack mode) - Management has DNS enabled - Run netbird up - correctly no host DNS changes - Toggle DNS off then on again in management - Result: Client DNS becomes active, ignoring the client-side disable flag ## Issue ticket number and link #4236 ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md).
saavagebueno added the pull-request label 2025-11-20 08:07:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#4157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?