[PR #4774] [management] move network map logic into new design #4398

Open
opened 2025-11-20 08:08:18 -05:00 by saavagebueno · 0 comments
Owner

Original Pull Request: https://github.com/netbirdio/netbird/pull/4774

State: closed
Merged: Yes


Describe your changes

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • New Features

    • Central network-map controller with buffered per-peer update channels and an account request buffer for more reliable, debounced peer syncs.
  • Improvements

    • Unified gRPC server and auth plumbing; sync payloads now include DNS-forwarder port.
    • Reduced redundant network-map recalculations — updates now trigger targeted peer updates for faster propagation.
    • DNS conversion and name-server group caching optimized for repeated lookups.
  • Tests

    • Expanded coverage for buffering strategies, DNS conversion/caching, and sync flows.
**Original Pull Request:** https://github.com/netbirdio/netbird/pull/4774 **State:** closed **Merged:** Yes --- ## Describe your changes ## Issue ticket number and link ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [x] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Central network-map controller with buffered per-peer update channels and an account request buffer for more reliable, debounced peer syncs. * **Improvements** * Unified gRPC server and auth plumbing; sync payloads now include DNS-forwarder port. * Reduced redundant network-map recalculations — updates now trigger targeted peer updates for faster propagation. * DNS conversion and name-server group caching optimized for repeated lookups. * **Tests** * Expanded coverage for buffering strategies, DNS conversion/caching, and sync flows. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
saavagebueno added the pull-request label 2025-11-20 08:08:18 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#4398