SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-11 18:51:53 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

allow_netbird_windows.go is language dependend #484

New Issue
Closed
opened 2025-11-20 05:12:13 -05:00 by saavagebueno · 7 comments
saavagebueno commented 2025-11-20 05:12:13 -05:00
Owner
Copy Link

Originally created by @moserpjm on GitHub (Oct 25, 2023).

Describe the problem
Adding a firewall rule under windows to allow traffic from wireguard interface only works if the system language is set to english.

To Reproduce
Steps to reproduce the behavior:

  • Set your system language to e.g German
  • Install Netbird
  • Connect
  • Log file contains an error, no firewall rule is created

Expected behavior
No error in log, firewall rule is created

The problem is the hardcoded noRulesMatchCriteria in client/firewall/uspfilter/allow_netbird_windows.go

Originally created by @moserpjm on GitHub (Oct 25, 2023). **Describe the problem** Adding a firewall rule under windows to allow traffic from wireguard interface only works if the system language is set to english. **To Reproduce** Steps to reproduce the behavior: * Set your system language to e.g German * Install Netbird * Connect * Log file contains an error, no firewall rule is created **Expected behavior** No error in log, firewall rule is created The problem is the hardcoded noRulesMatchCriteria in client/firewall/uspfilter/allow_netbird_windows.go
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@mlsmaycon commented on GitHub (Oct 25, 2023):

Hello @moserpjm thanks for reporting the issue. To help us troubleshoot the can you run the following commands on your Powershell with administrator privileges and then share the output?

netsh advfirewall firewall add rule name=Netbird dir=in enable=yes action=allow  profile=any localip=127.0.0.1
netsh advfirewall firewall show rule name=Netbird
netsh advfirewall firewall delete rule name=Netbird

We will validate in our end too with a operating system in another language.

@mlsmaycon commented on GitHub (Oct 25, 2023): Hello @moserpjm thanks for reporting the issue. To help us troubleshoot the can you run the following commands on your Powershell with administrator privileges and then share the output? ```shell netsh advfirewall firewall add rule name=Netbird dir=in enable=yes action=allow profile=any localip=127.0.0.1 netsh advfirewall firewall show rule name=Netbird netsh advfirewall firewall delete rule name=Netbird ``` We will validate in our end too with a operating system in another language.
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@moserpjm commented on GitHub (Oct 25, 2023):

Sure. Here you go:
image

@moserpjm commented on GitHub (Oct 25, 2023): Sure. Here you go: ![image](https://github.com/netbirdio/netbird/assets/137904805/2a5b4962-073b-4f8a-9f73-d17489d3fe06)
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@mlsmaycon commented on GitHub (Oct 25, 2023):

Thanks, can you also share the logs from your netbird client? They are located at C:\Programadata\netbird\client.log

@mlsmaycon commented on GitHub (Oct 25, 2023): Thanks, can you also share the logs from your netbird client? They are located at `C:\Programadata\netbird\client.log`
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@moserpjm commented on GitHub (Oct 25, 2023):

That's the relevant part:

2023-10-23T19:11:18+02:00 ERRO client/internal/routemanager/manager.go:41: server router is not supported: firewall not supported on windows
2023-10-23T19:11:18+02:00 INFO client/internal/engine.go:249: using userspace bind mode 0.0.0.0:51820
2023-10-23T19:11:18+02:00 ERRO client/internal/acl/manager_create.go:23: failed to allow netbird interface traffic: exit status 1
2023-10-23T19:11:18+02:00 INFO signal/client/grpc.go:157: connected to the Signal Service stream
2023-10-23T19:11:18+02:00 INFO client/internal/connect.go:179: Netbird engine started, my IP is: 100.86.222.2/16
2023-10-23T19:11:18+02:00 INFO management/client/grpc.go:143: connected to the Management Service stream```
@moserpjm commented on GitHub (Oct 25, 2023): That's the relevant part: ```2023-10-23T19:11:17+02:00 INFO client/internal/config.go:207: new Admin Panel URL provided, updated to https://netbird.xxx.xxx (old value https://netbird.xxx.xxx:443) 2023-10-23T19:11:18+02:00 ERRO client/internal/routemanager/manager.go:41: server router is not supported: firewall not supported on windows 2023-10-23T19:11:18+02:00 INFO client/internal/engine.go:249: using userspace bind mode 0.0.0.0:51820 2023-10-23T19:11:18+02:00 ERRO client/internal/acl/manager_create.go:23: failed to allow netbird interface traffic: exit status 1 2023-10-23T19:11:18+02:00 INFO signal/client/grpc.go:157: connected to the Signal Service stream 2023-10-23T19:11:18+02:00 INFO client/internal/connect.go:179: Netbird engine started, my IP is: 100.86.222.2/16 2023-10-23T19:11:18+02:00 INFO management/client/grpc.go:143: connected to the Management Service stream```
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@Fantu commented on GitHub (Oct 25, 2023):

I also saw issue with netsh commands in the past dependent on the operating system language.
I have major of windows peers with italian system language and looking for the rule "Netbird" with:
netsh advfirewall firewall show rule name=Netbird
seems missed
anyway netbird is working except https://github.com/netbirdio/netbird/issues/1195 on some of them (probably not related)

EDIT:
I tried to do the commands of https://github.com/netbirdio/netbird/issues/1249#issuecomment-1779104655 on a windows 2019 standard italian if can be useful:

PS C:\Users\administrator.M2R> netsh advfirewall firewall add rule name=Netbird dir=in enable=yes action=allow  profile=any localip=127.0.0.1
OK.

PS C:\Users\administrator.M2R> netsh advfirewall firewall show rule name=Netbird

Nome regola:                          Netbird
----------------------------------------------------------------------
Attivata:                             Sì
Direzione:                            In
Profili:                              Dominio,Privato,Pubblico
Raggruppamento:
LocalIP:                              127.0.0.1/32
RemoteIP:                             Qualsiasi
Protocollo:                           Qualsiasi
Attraversamento confini:              No
Azione:                               Consenti
OK.

PS C:\Users\administrator.M2R> netsh advfirewall firewall delete rule name=Netbird

Regole eliminate 1.
OK.

in the client log I saw this I suppose can be related:
2023-10-25T15:44:31+02:00 ERRO client/internal/acl/manager_create.go:23: failed to allow netbird interface traffic: exit status 1

@Fantu commented on GitHub (Oct 25, 2023): I also saw issue with netsh commands in the past dependent on the operating system language. I have major of windows peers with italian system language and looking for the rule "Netbird" with: `netsh advfirewall firewall show rule name=Netbird` seems missed anyway netbird is working except https://github.com/netbirdio/netbird/issues/1195 on some of them (probably not related) EDIT: I tried to do the commands of https://github.com/netbirdio/netbird/issues/1249#issuecomment-1779104655 on a windows 2019 standard italian if can be useful: ``` PS C:\Users\administrator.M2R> netsh advfirewall firewall add rule name=Netbird dir=in enable=yes action=allow profile=any localip=127.0.0.1 OK. PS C:\Users\administrator.M2R> netsh advfirewall firewall show rule name=Netbird Nome regola: Netbird ---------------------------------------------------------------------- Attivata: Sì Direzione: In Profili: Dominio,Privato,Pubblico Raggruppamento: LocalIP: 127.0.0.1/32 RemoteIP: Qualsiasi Protocollo: Qualsiasi Attraversamento confini: No Azione: Consenti OK. PS C:\Users\administrator.M2R> netsh advfirewall firewall delete rule name=Netbird Regole eliminate 1. OK. ``` in the client log I saw this I suppose can be related: `2023-10-25T15:44:31+02:00 ERRO client/internal/acl/manager_create.go:23: failed to allow netbird interface traffic: exit status 1`
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@Fantu commented on GitHub (Oct 26, 2023):

@mlsmaycon I did a fast test and instead check the output string that change with language and with S.O. != english fails can be checked $? instead

netsh advfirewall firewall show rule name=Netbird
if($?)
{
   echo "rule found"
} else {
   echo "rule missed"
}

from a test on both missed and present seems working:

PS C:\WINDOWS\system32> netsh advfirewall firewall show rule name=Netbird

Nome regola:                          Netbird
----------------------------------------------------------------------
Attivata:                             Sì
Direzione:                            In
Profili:                              Dominio,Privato,Pubblico
Raggruppamento:
LocalIP:                              127.0.0.1/32
RemoteIP:                             Qualsiasi
Protocollo:                           Qualsiasi
Attraversamento confini:              No
Azione:                               Consenti
OK.

PS C:\WINDOWS\system32> if($?)
>> {
>>    echo "rule found"
>> } else {
>>    echo "rule missed"
>> }
rule found
PS C:\WINDOWS\system32> netsh advfirewall firewall delete rule name=Netbird

Regole eliminate 1.
OK.

PS C:\WINDOWS\system32> netsh advfirewall firewall show rule name=Netbird

Nessuna regola corrispondente al criterio specificato.

PS C:\WINDOWS\system32> if($?)
>> {
>>    echo "rule found"
>> } else {
>>    echo "rule missed"
>> }
rule missed

about the rules that try to set netbird seems to me wrong as accept any external source to any protocol and don't restrict to specific destination port or executable

@Fantu commented on GitHub (Oct 26, 2023): @mlsmaycon I did a fast test and instead check the output string that change with language and with S.O. != english fails can be checked $? instead ``` netsh advfirewall firewall show rule name=Netbird if($?) { echo "rule found" } else { echo "rule missed" } ``` from a test on both missed and present seems working: ``` PS C:\WINDOWS\system32> netsh advfirewall firewall show rule name=Netbird Nome regola: Netbird ---------------------------------------------------------------------- Attivata: Sì Direzione: In Profili: Dominio,Privato,Pubblico Raggruppamento: LocalIP: 127.0.0.1/32 RemoteIP: Qualsiasi Protocollo: Qualsiasi Attraversamento confini: No Azione: Consenti OK. PS C:\WINDOWS\system32> if($?) >> { >> echo "rule found" >> } else { >> echo "rule missed" >> } rule found PS C:\WINDOWS\system32> netsh advfirewall firewall delete rule name=Netbird Regole eliminate 1. OK. PS C:\WINDOWS\system32> netsh advfirewall firewall show rule name=Netbird Nessuna regola corrispondente al criterio specificato. PS C:\WINDOWS\system32> if($?) >> { >> echo "rule found" >> } else { >> echo "rule missed" >> } rule missed ``` about the rules that try to set netbird seems to me wrong as accept any external source to any protocol and don't restrict to specific destination port or executable
saavagebueno commented 2025-11-20 05:12:14 -05:00
Author
Owner
Copy Link

@mlsmaycon commented on GitHub (Jan 29, 2024):

I believe this has been fixed.

@mlsmaycon commented on GitHub (Jan 29, 2024): I believe this has been fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?