SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-07-29 17:32:35 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

netbird gui improvement for URL sanitization / user feedback #657

New Issue
Open
opened 2025-11-20 05:15:29 -05:00 by saavagebueno · 1 comment
saavagebueno commented 2025-11-20 05:15:29 -05:00
Owner
Copy Link

Originally created by @TSJasonH on GitHub (Feb 27, 2024).

Describe the problem

Management URLs are not sanitized against user input. If the user enters invalid characters nothing happens when they click connect and they are left scratching their heads. Users copy/paste the Management URL. Sometimes they get extra characters in the clipboard.

To Reproduce

Steps to reproduce the behavior:

In this example, a carriage return was included by the user over-selecting during copy/paste. To reproduce simply over-copy a URL to the next line so a '/r' gets invisibly added to the clipboard entry and paste it into the gui management URL field.

Expected behavior

The gui should sanitize user inputs against this type of obvious error
or
provide an error pop-up for the user without having to dig into the client.log

Are you using NetBird Cloud?

Self-hosted

NetBird version

0.26

Context

From the client.log (domain masked):
2024-02-27T15:27:46+04:00 ERRO client/internal/config.go:337: failed parsing Management URL URL https://netbird.domain.com:33073
: [parse "https://netbird.domain.com:33073\r ": net/url: invalid control character in URL]

Originally created by @TSJasonH on GitHub (Feb 27, 2024). **Describe the problem** Management URLs are not sanitized against user input. If the user enters invalid characters nothing happens when they click connect and they are left scratching their heads. Users copy/paste the Management URL. Sometimes they get extra characters in the clipboard. **To Reproduce** Steps to reproduce the behavior: In this example, a carriage return was included by the user over-selecting during copy/paste. To reproduce simply over-copy a URL to the next line so a '/r' gets invisibly added to the clipboard entry and paste it into the gui management URL field. **Expected behavior** The gui should sanitize user inputs against this type of obvious error or provide an error pop-up for the user without having to dig into the client.log **Are you using NetBird Cloud?** Self-hosted **NetBird version** 0.26 **Context** From the client.log (domain masked): 2024-02-27T15:27:46+04:00 ERRO client/internal/config.go:337: failed parsing Management URL URL https://netbird.domain.com:33073 : [parse "https://netbird.domain.com:33073\r ": net/url: invalid control character in URL]
saavagebueno added the bugclientUX labels 2025-11-20 05:15:29 -05:00
saavagebueno commented 2025-11-20 05:15:30 -05:00
Author
Owner
Copy Link

@pascal-fischer commented on GitHub (Feb 27, 2024):

Hi @TSJasonH,

thanks for pointing this out. We will work on improving the validation of the fields in the desktop client UI.

@pascal-fischer commented on GitHub (Feb 27, 2024): Hi @TSJasonH, thanks for pointing this out. We will work on improving the validation of the fields in the desktop client UI.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label bug client UX
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?