SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-07-27 16:32:34 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Don't create PrivateKey on install #774

New Issue
Open
opened 2025-11-20 05:17:17 -05:00 by saavagebueno · 4 comments
saavagebueno commented 2025-11-20 05:17:17 -05:00
Owner
Copy Link

Originally created by @euh2 on GitHub (Apr 4, 2024).

Problem

I struggled with a weird issue. I deployed several machines from one base image. In the base image I have Netbird preinstalled. From all machines only one would connect to the Netbird Network. When checking the machines, all of them would have the same /etc/netbird/config.json, i.e. the same PrivateKey.

Since Netbird is installed at Image build time, the keys are the same for all deployed instances. That does of course not work.

To Reproduce

See above

Expected behavior

Create the PrivateKey when first running netbird up.

Are you using NetBird Cloud?
No

NetBird version

0.27.0

Originally created by @euh2 on GitHub (Apr 4, 2024). **Problem** I struggled with a weird issue. I deployed several machines from one base image. In the base image I have Netbird preinstalled. From all machines _only one_ would connect to the Netbird Network. When checking the machines, all of them would have the same `/etc/netbird/config.json`, i.e. the same **PrivateKey**. Since Netbird is installed at Image build time, the keys are the same for all deployed instances. That does of course not work. **To Reproduce** See above **Expected behavior** Create the **PrivateKey** when first running `netbird up`. **Are you using NetBird Cloud?** No **NetBird version** 0.27.0
saavagebueno added the feature-request label 2025-11-20 05:17:17 -05:00
saavagebueno commented 2025-11-20 05:17:18 -05:00
Author
Owner
Copy Link

@sbrw commented on GitHub (Jan 21, 2025):

Is there a workaround for this?
What is used for creation of the private key? Machine ID, SSH key...?

@sbrw commented on GitHub (Jan 21, 2025): Is there a workaround for this? What is used for creation of the private key? Machine ID, SSH key...?
saavagebueno commented 2025-11-20 05:17:18 -05:00
Author
Owner
Copy Link

@0xSeb commented on GitHub (Jun 4, 2025):

We face the exact same issue running multiple EC2 instances from our base AMI where we baked the install of netbird. Anything planned for this or a workaround ?

@0xSeb commented on GitHub (Jun 4, 2025): We face the exact same issue running multiple EC2 instances from our base AMI where we baked the install of netbird. Anything planned for this or a workaround ?
saavagebueno commented 2025-11-20 05:17:18 -05:00
Author
Owner
Copy Link

@0xSeb commented on GitHub (Jun 4, 2025):

We just found a workaround in our base AMI

  • install netbird
  • rm /etc/netbird/config.json

When we start netbird with a setup key, this file gets generated with a new private key and all.

@0xSeb commented on GitHub (Jun 4, 2025): We just found a workaround in our base AMI - install netbird - rm /etc/netbird/config.json When we start netbird with a setup key, this file gets generated with a new private key and all.
saavagebueno commented 2025-11-20 05:17:18 -05:00
Author
Owner
Copy Link

@nazarewk commented on GitHub (Jun 4, 2025):

How did you guys end up with NetBird client started while building the images?

Generally, those should be cleared (like A LOT of other dynamic data) before dumping the system image for reuse.

What is used for creation of the private key? Machine ID, SSH key...?

It's a random key depending on nothing specific.

We just found a workaround in our base AMI

* install netbird

* rm /etc/netbird/config.json

When we start netbird with a setup key, this file gets generated with a new private key and all.

You have the right idea. This should be in a post-baking/wrapup step for any kind of AMI/base image before storing it anywhere for reuse.

It's probably not easy in the current codebase, but a feature that would generate the keys upon first connection attempt would make some sense in the future.

@nazarewk commented on GitHub (Jun 4, 2025): How did you guys end up with NetBird client started while building the images? Generally, those should be cleared (like A LOT of other dynamic data) before dumping the system image for reuse. --- > What is used for creation of the private key? Machine ID, SSH key...? It's a random key depending on nothing specific. --- > We just found a workaround in our base AMI > > * install netbird > > * rm /etc/netbird/config.json > > > When we start netbird with a setup key, this file gets generated with a new private key and all. You have the right idea. This should be in a post-baking/wrapup step for any kind of AMI/base image before storing it anywhere for reuse. --- It's probably not easy in the current codebase, but a feature that would generate the keys upon first connection attempt would make some sense in the future.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label feature-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?