SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-05 06:52:00 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Userspace implementation of RemoveAllowedIP recreates wireguard iface #838

New Issue
Closed
opened 2025-11-20 05:18:26 -05:00 by saavagebueno · 3 comments
saavagebueno commented 2025-11-20 05:18:26 -05:00
Owner
Copy Link

Originally created by @hurricanehrndz on GitHub (May 2, 2024).

Describe the problem

RemoveAllowedIP is not an update operation. Because of this when this function is called on platforms depending on the user space implementation of wireguard it results in all connections being dropped because it tries to use a port that is already in use.

To Reproduce

Steps to reproduce the behavior:
Deselect one of the routes from the new "Network Routes" menu

Expected behavior

Expect removing an IP from peer ACL does not recreate wireguard interface

Are you using NetBird Cloud?
NA

NetBird version

main

NetBird status -d output:

Not applicable

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

Originally created by @hurricanehrndz on GitHub (May 2, 2024). **Describe the problem** [RemoveAllowedIP](https://github.com/netbirdio/netbird/blob/main/iface/wg_configurer_usp.go#L121C35-L121C40) is not an update operation. Because of this when this function is called on platforms depending on the user space implementation of wireguard it results in all connections being dropped because it tries to use a port that is already in use. **To Reproduce** Steps to reproduce the behavior: Deselect one of the routes from the new "Network Routes" menu **Expected behavior** Expect removing an IP from peer ACL does not recreate wireguard interface **Are you using NetBird Cloud?** NA **NetBird version** main **NetBird status -d output:** Not applicable **Screenshots** If applicable, add screenshots to help explain your problem. **Additional context** Add any other context about the problem here.
saavagebueno added the triage-needed label 2025-11-20 05:18:26 -05:00
saavagebueno commented 2025-11-20 05:18:26 -05:00
Author
Owner
Copy Link

@hurricanehrndz commented on GitHub (May 2, 2024):

@mlsmaycon latency base routing will not work without fixing this bug, because routes need to be successfully removed from allowed list without recreating wg iface

@hurricanehrndz commented on GitHub (May 2, 2024): @mlsmaycon latency base routing will not work without fixing this bug, because routes need to be successfully removed from allowed list without recreating wg iface
saavagebueno commented 2025-11-20 05:18:27 -05:00
Author
Owner
Copy Link

@hurricanehrndz commented on GitHub (May 2, 2024):

I have a patch that fixes this

@hurricanehrndz commented on GitHub (May 2, 2024): I have a patch that fixes this
saavagebueno commented 2025-11-20 05:18:27 -05:00
Author
Owner
Copy Link

@mlsmaycon commented on GitHub (May 2, 2024):

Ok, thanks @hurricanehrndz we will review it soon after you open the PR.

@mlsmaycon commented on GitHub (May 2, 2024): Ok, thanks @hurricanehrndz we will review it soon after you open the PR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label triage-needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?