SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-05-31 04:22:11 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

client/server/server.go->Status() returns connected when WiFi Dropouts #851

New Issue
Closed
opened 2025-11-20 05:18:37 -05:00 by saavagebueno · 5 comments
saavagebueno commented 2025-11-20 05:18:37 -05:00
Owner
Copy Link

Originally created by @hurricanehrndz on GitHub (May 6, 2024).

Describe the problem

client/server/server.go->Status() returns a status connected when WiFi is suddenly disconnected this contradicts the output of netbird status that accurately reflects the connection state

This results in the menubar/systray item inaccurately reflecting the connection state, is this oversight or an actual design decission?

To Reproduce

Steps to reproduce the behavior:
On macOS

  1. Connect
  2. Turn off WiFi
  3. Icon indicates I am successfully connected when it is impossible

Expected behavior

Icon should accurately reflect the connection state

Are you using NetBird Cloud?
Nope

NetBird version
0.27.3

NetBird status -d output:

NA

Originally created by @hurricanehrndz on GitHub (May 6, 2024). **Describe the problem** [client/server/server.go->Status() ](https://github.com/netbirdio/netbird/blob/main/client/server/server.go#L597) returns a status connected when WiFi is suddenly disconnected this contradicts the output of `netbird status` that accurately reflects the connection state This results in the menubar/systray item inaccurately reflecting the connection state, is this oversight or an actual design decission? **To Reproduce** Steps to reproduce the behavior: On macOS 1. Connect 2. Turn off WiFi 3. Icon indicates I am successfully connected when it is impossible **Expected behavior** Icon should accurately reflect the connection state **Are you using NetBird Cloud?** Nope **NetBird version** 0.27.3 **NetBird status -d output:** NA
saavagebueno added the triage-needed label 2025-11-20 05:18:37 -05:00
saavagebueno commented 2025-11-20 05:18:37 -05:00
Author
Owner
Copy Link

@mlsmaycon commented on GitHub (May 7, 2024):

@hurricanehrndz, the connected status has the following behavior:

  1. connection to the management and signal servers: they are handled by the grpc client and have a 10s timeout; this may cause an invalid status during this timeout
  2. P2P connections are not considered in the status response; they are additional to the management/signal status

If the status is not updating after a few seconds, that's an issue.

We are working on a network monitor, https://github.com/netbirdio/netbird/pull/1904, which will respond to network changes, especially the ones that touch the default gateway.

@mlsmaycon commented on GitHub (May 7, 2024): @hurricanehrndz, the connected status has the following behavior: 1. connection to the management and signal servers: they are handled by the grpc client and have a 10s timeout; this may cause an invalid status during this timeout 2. P2P connections are not considered in the status response; they are additional to the management/signal status If the status is not updating after a few seconds, that's an issue. We are working on a network monitor, https://github.com/netbirdio/netbird/pull/1904, which will respond to network changes, especially the ones that touch the default gateway.
saavagebueno commented 2025-11-20 05:18:38 -05:00
Author
Owner
Copy Link

@hurricanehrndz commented on GitHub (May 8, 2024):

Thanks for the info, internal state is in server is never updated when connection to Signal or Management endpoint is terminated. Not sure if it should though

@hurricanehrndz commented on GitHub (May 8, 2024): Thanks for the info, internal state is in server is never updated when connection to Signal or Management endpoint is terminated. Not sure if it should though
saavagebueno commented 2025-11-20 05:18:38 -05:00
Author
Owner
Copy Link

@hurricanehrndz commented on GitHub (May 13, 2024):

I will attempt to test with the network monitor and report my findings

@hurricanehrndz commented on GitHub (May 13, 2024): I will attempt to test with the network monitor and report my findings
saavagebueno commented 2025-11-20 05:18:38 -05:00
Author
Owner
Copy Link

@hurricanehrndz commented on GitHub (May 14, 2024):

Network monitor will not work in our testing. It does too much and creates more issues than it helps solves. I maybe able to work around it, if I can change https://github.com/netbirdio/netbird/blob/main/client/server/server.go#L615 to optionally run probes.

@hurricanehrndz commented on GitHub (May 14, 2024): Network monitor will not work in our testing. It does too much and creates more issues than it helps solves. I maybe able to work around it, if I can change https://github.com/netbirdio/netbird/blob/main/client/server/server.go#L615 to optionally run probes.
saavagebueno commented 2025-11-20 05:18:38 -05:00
Author
Owner
Copy Link

@hurricanehrndz commented on GitHub (May 17, 2024):

Never mind, network monitor does help

@hurricanehrndz commented on GitHub (May 17, 2024): Never mind, network monitor does help
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label triage-needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#851
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?