SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-07-28 08:52:37 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Nameserver cannot be scoped to TLD #913

New Issue
Closed
opened 2025-11-20 05:19:47 -05:00 by saavagebueno · 5 comments
saavagebueno commented 2025-11-20 05:19:47 -05:00
Owner
Copy Link

Originally created by @ednxzu on GitHub (May 20, 2024).

Describe the problem

Netbird currently does not allow you to pass a top level domain to resolve.

Example: one cannot have a match domain scoped to consul., that would allow to resolve anything under *.consul

I believe this is only a GUI issue in the dashboard, and the feature should (???) work, it just cannot be set because of some UI input filter.

To Reproduce

Steps to reproduce the behavior:

  1. Go to DNS settings
  2. Try adding a domain match that is a TLD (com, fr, eu, etc..)

Expected behavior

match domain should support TLD scope

Are you using NetBird Cloud?

No

NetBird version

0.27.3

Originally created by @ednxzu on GitHub (May 20, 2024). **Describe the problem** Netbird currently does not allow you to pass a top level domain to resolve. Example: one cannot have a match domain scoped to `consul.`, that would allow to resolve anything under *.consul I believe this is only a GUI issue in the dashboard, and the feature should (???) work, it just cannot be set because of some UI input filter. **To Reproduce** Steps to reproduce the behavior: 1. Go to DNS settings 2. Try adding a domain match that is a TLD (com, fr, eu, etc..) **Expected behavior** match domain should support TLD scope **Are you using NetBird Cloud?** No **NetBird version** 0.27.3
saavagebueno added the feature-requestdns labels 2025-11-20 05:19:47 -05:00
saavagebueno commented 2025-11-20 05:19:48 -05:00
Author
Owner
Copy Link

@pascal-fischer commented on GitHub (May 21, 2024):

Hi @ednxzu, yes that seems to be a limitation of the front end right now. We are going to fix that. Till then if you need this earlier you can try setting the domain by calling the API directly.

@pascal-fischer commented on GitHub (May 21, 2024): Hi @ednxzu, yes that seems to be a limitation of the front end right now. We are going to fix that. Till then if you need this earlier you can try setting the domain by calling the API directly.
saavagebueno commented 2025-11-20 05:19:48 -05:00
Author
Owner
Copy Link

@taylorwilsdon commented on GitHub (May 21, 2024):

Hey @pascal-fischer, also very curious about this one but I tried via api (route /api/dns/nameservers/{nameserverid}) and when including any of the following:

consul
.consul
consul.

in the body payload under "domains", it will return a 422 (Unprocessable content) - if you change that to abc.consul with nothing else different it goes through. The message in the response is:
{"message":"nameserver group got an invalid domain: consul \"domain should consists of only letters, numbers, and hyphens with no leading, trailing hyphens, or spaces\"","code":422}

So it does appear the same format checks present in the UI are also present in the backend.
The regex used to dictate this is declared here: https://github.com/netbirdio/netbird/blob/main/management/server/nameserver.go#L17

You can confirm at regex101.com that for the current regular expression ^(?i)[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,}$ the test string "consul.com" validates but simply "consul" or "consul." does not.

@taylorwilsdon commented on GitHub (May 21, 2024): Hey @pascal-fischer, also very curious about this one but I tried via api (route `/api/dns/nameservers/{nameserverid}`) and when including any of the following: `consul` `.consul` `consul.` in the body payload under "domains", it will return a 422 (Unprocessable content) - if you change that to `abc.consul` with nothing else different it goes through. The message in the response is: `{"message":"nameserver group got an invalid domain: consul \"domain should consists of only letters, numbers, and hyphens with no leading, trailing hyphens, or spaces\"","code":422}` So it does appear the same format checks present in the UI are also present in the backend. The regex used to dictate this is declared here: https://github.com/netbirdio/netbird/blob/main/management/server/nameserver.go#L17 You can confirm at regex101.com that for the current regular expression `^(?i)[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,}$` the test string "consul.com" validates but simply "consul" or "consul." does not.
saavagebueno commented 2025-11-20 05:19:48 -05:00
Author
Owner
Copy Link

@pascal-fischer commented on GitHub (May 21, 2024):

Ah you are right, my bad. Then we need to update and test this on the backend as well.

@pascal-fischer commented on GitHub (May 21, 2024): Ah you are right, my bad. Then we need to update and test this on the backend as well.
saavagebueno commented 2025-11-20 05:19:48 -05:00
Author
Owner
Copy Link

@nazarewk commented on GitHub (May 15, 2025):

Aggregation of TLD-related feature requests:

This https://github.com/netbirdio/netbird/issues/2593#issuecomment-2881634381 lists some implementation details worth noting when we finally decide to implement the feature fully

@nazarewk commented on GitHub (May 15, 2025): Aggregation of TLD-related feature requests: - https://github.com/netbirdio/netbird/issues/2496 - https://github.com/netbirdio/netbird/issues/2593 - https://github.com/netbirdio/netbird/issues/2227 - https://github.com/netbirdio/netbird/issues/2921 (this is about Network Routes, not Nameservers, so not really related) --- This https://github.com/netbirdio/netbird/issues/2593#issuecomment-2881634381 lists some implementation details worth noting when we finally decide to implement the feature fully
saavagebueno commented 2025-11-20 05:19:48 -05:00
Author
Owner
Copy Link

@Cyberbeni commented on GitHub (Jul 23, 2025):

Hi, I think this should also be changed for Settings > Networks > DNS Domain.

I want to have a setup where people can use the same address whether they are at home or connected through NetBird. iOS/macOS devices don't resolve server to server.local out of the box (and typing server into your browser will search for it, so people would have to type http://server/ instead, so using server.local would be preferred).

In my test setup, I currently also have AdGuard Home to direct server.local to the NetBird address (With NetBird set up to use it as a DNS), which almost works as expected. It adds a noticeable delay compared to using server.netbird.cloud and if I want to use it as a DNS at home without NetBird running then server.local doesn't work.

@mlsmaycon Should I open a separate issue for this?

@Cyberbeni commented on GitHub (Jul 23, 2025): Hi, I think this should also be changed for `Settings > Networks > DNS Domain`. I want to have a setup where people can use the same address whether they are at home or connected through NetBird. iOS/macOS devices don't resolve `server` to `server.local` out of the box (and typing `server` into your browser will search for it, so people would have to type `http://server/` instead, so using `server.local` would be preferred). In my test setup, I currently also have AdGuard Home to direct `server.local` to the NetBird address (With NetBird set up to use it as a DNS), which almost works as expected. It adds a noticeable delay compared to using `server.netbird.cloud` and if I want to use it as a DNS at home without NetBird running then `server.local` doesn't work. @mlsmaycon Should I open a separate issue for this?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label dns feature-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#913
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?