SVI/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-06-09 17:02:09 -04:00
Code Issues 3.0k Packages Projects Releases 10 Wiki Activity

Single Socket ICE #99

New Issue
Closed
opened 2025-11-20 05:06:15 -05:00 by saavagebueno · 1 comment
saavagebueno commented 2025-11-20 05:06:15 -05:00
Owner
Copy Link

Originally created by @braginini on GitHub (Jan 12, 2022).

What?
Support a single socket mode (or reduced number of sockets) in the client app.

We use pion/ice library for NAT traversal (discovering connection candidates for establishing p2p connections).
Currently, the library creates multiple sockets for each candidate type (around 5 per connection). Having many peers causes too many open files on the system which is not very efficient (e.g. 5 x 100 peers = 500 sockets).
The pion/ice library supports UDPMux which allows for a single socket to be reused between candidates. However, it is only used for HOST candidates.

This implementation should support all the candidate types (server reflexive and relayed).
Why?
Having many peers causes too many open files on the system which is not very efficient. On some systems, it causes errors (too many open files).
On top of those 5 sockets, we also open a socket per peer to connect to Wireguard and proxy connection.

How?
Fork pion/ice -> wiretrustee/ice and support SRFLX and RELAY candidates in the UDPMux.
There was some effort done in this branch already https://github.com/wiretrustee/ice/tree/singleport
The idea here is to have a separate UDPMux for each candidate. E.g. UDPMuxSrflx, UDPMuxRelay, etc.

It is important to run tests over 200 peers to check the result.

Originally created by @braginini on GitHub (Jan 12, 2022). **What?** Support a single socket mode (or reduced number of sockets) in the client app. We use [pion/ice](https://github.com/pion/ice) library for NAT traversal (discovering connection candidates for establishing p2p connections). Currently, the library creates multiple sockets for each candidate type (around 5 per connection). Having many peers causes too many open files on the system which is not very efficient (e.g. 5 x 100 peers = 500 sockets). The pion/ice library supports [UDPMux](https://github.com/pion/ice/blob/master/udp_mux.go) which allows for a single socket to be reused between candidates. However, it is only used for HOST candidates. This implementation should support all the candidate types (server reflexive and relayed). **Why?** Having many peers causes too many open files on the system which is not very efficient. On some systems, it causes errors (too many open files). On top of those 5 sockets, we also open a socket per peer to connect to Wireguard and proxy connection. **How?** Fork pion/ice -> wiretrustee/ice and support SRFLX and RELAY candidates in the UDPMux. There was some effort done in this branch already https://github.com/wiretrustee/ice/tree/singleport The idea here is to have a separate UDPMux for each candidate. E.g. UDPMuxSrflx, UDPMuxRelay, etc. It is important to run tests over 200 peers to check the result.
saavagebueno added the enhancementclientneeds-review2022 Q1 labels 2025-11-20 05:06:15 -05:00
saavagebueno commented 2025-11-20 05:06:16 -05:00
Author
Owner
Copy Link

@stv0g commented on GitHub (Jun 16, 2023):

Hi @mlsmaycon,

I am curious, how have you resolved this issue? Do you have a single socket for Host, Srflx and Relay candidates?
Upstream pion/ice still needs multiple using UDPMux and UniversalUDPMux

@stv0g commented on GitHub (Jun 16, 2023): Hi @mlsmaycon, I am curious, how have you resolved this issue? Do you have a single socket for Host, Srflx and Relay candidates? Upstream pion/ice still needs multiple using `UDPMux` and `UniversalUDPMux`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2022 Q1
2022 Q1
accessibility
acl
agent
agent
Android
Android
api
authentik
automation
azure
battery-usage
bug
cache
client
client-ui
cloud
cloud-only
cloudflare
community
compatibility
config-idp
config-issue
connection
contribution
coturn
cross-vpn
dashboard
data-usage
distribution
dns
docker
documentation
duplicate
enhancement
enhancement
event-stream
feature-request
freebsd
getting-started
go
good first issue
gui
help wanted
home-assistant
idp
inconsistency
integration
integrations
ios
ipv6
jwt
k8s
keycloak
linux
login
macos
management-service
missing-docs
mobile
moved-internal
needs-review
netbird-ui
networking
new-platform
nginx
notification
okta
openwrt
packaging
peer-management
peer-management
peer-management
performance
postgres
posture-checks
psk
pull-request
Mirrored from GitHub Pull Request
 question
refactor
relay
release
rfc
routes
security
security-related
self-hosting
server
signal
sleep-issue
ssh
ssl
status
store
synology
system-compatibility-issue
test-suite
third-party-integration
triage
triage-needed
troubleshooting
UX
waiting-feedback
windows
wontfix
zitadel
No Label 2022 Q1 client enhancement needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/netbird#99
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?