saavagebueno/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:24:01 -04:00
Code Issues 78 Packages Projects Releases 7 Wiki Activity

[PR #164] [MERGED] fix: add loading modal for container operations #230

New Issue
Closed
opened 2025-11-20 04:15:55 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:15:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/164
Author: @michelroegl-brunner
Created: 10/16/2025
Status: ✅ Merged
Merged: 10/16/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/show_modal_during_operation

📝 Commits (1)

  • 962e287 feat: add loading modal for container operations

📊 Changes

2 files changed (+58 additions, -0 deletions)

View changed files

📝 src/app/_components/InstalledScriptsTab.tsx (+21 -0)
➕ src/app/_components/LoadingModal.tsx (+37 -0)

📄 Description

Summary

Add a loading modal with spinning circle that displays during start/stop/destroy container operations to provide clear visual feedback to users.

Changes

  • New LoadingModal component with full-screen overlay and spinning animation
  • Enhanced user experience during container operations with action-specific messages
  • Consistent modal styling matching existing ConfirmationModal and ErrorModal patterns

User Flow

  1. User clicks start/stop/destroy → confirmation modal shows
  2. User confirms → loading modal shows with spinning circle + action description
  3. Operation completes → loading modal closes, success/error modal shows

Technical Details

  • Uses icon from lucide-react for spinning animation
  • Integrates with existing mutation handlers in InstalledScriptsTab
  • Shows descriptive messages like 'Starting container 101...', 'Destroying container 102...'
  • Automatically closes on operation completion (success or error)

Fixes the issue where users had no visual feedback during background operations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/164 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/16/2025 **Status:** ✅ Merged **Merged:** 10/16/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/show_modal_during_operation` --- ### 📝 Commits (1) - [`962e287`](https://github.com/community-scripts/ProxmoxVE-Local/commit/962e2877e33a3f8d19acba0e73c6260cf1f513a5) feat: add loading modal for container operations ### 📊 Changes **2 files changed** (+58 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/InstalledScriptsTab.tsx` (+21 -0) ➕ `src/app/_components/LoadingModal.tsx` (+37 -0) </details> ### 📄 Description ## Summary Add a loading modal with spinning circle that displays during start/stop/destroy container operations to provide clear visual feedback to users. ## Changes - **New LoadingModal component** with full-screen overlay and spinning animation - **Enhanced user experience** during container operations with action-specific messages - **Consistent modal styling** matching existing ConfirmationModal and ErrorModal patterns ## User Flow 1. User clicks start/stop/destroy → confirmation modal shows 2. User confirms → **loading modal shows** with spinning circle + action description 3. Operation completes → loading modal closes, success/error modal shows ## Technical Details - Uses icon from lucide-react for spinning animation - Integrates with existing mutation handlers in InstalledScriptsTab - Shows descriptive messages like 'Starting container 101...', 'Destroying container 102...' - Automatically closes on operation completion (success or error) Fixes the issue where users had no visual feedback during background operations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:15:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saavagebueno/ProxmoxVE-Local#230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?