saavagebueno/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:24:01 -04:00
Code Issues 78 Packages Projects Releases 7 Wiki Activity

[PR #237] [MERGED] fix: Container ID display not showing after whiptail input and update tools.func #287

New Issue
Closed
opened 2025-11-20 04:16:12 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:16:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/237
Author: @michelroegl-brunner
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @michelroegl-brunner

Base: main ← Head: update/tools.func

📝 Commits (2)

  • bc52256 fix: Container ID display not showing after whiptail input
  • 5faa7f3 remove debian

📊 Changes

2 files changed (+2929 additions, -1386 deletions)

View changed files

📝 scripts/core/build.func (+1 -4)
📝 scripts/core/tools.func (+2928 -1382)

📄 Description

🐛 Bug Fix

Problem

The Container ID display was not showing after the whiptail input dialog, regardless of whether the user entered a custom ID or left it empty.

Root Cause

The echo statement was inside the whiptail output capture block where the output redirection was interfering with the display.

Solution

  • Moved the echo statement outside the whiptail output capture block
  • Consolidated duplicate echo statements into a single display
  • Ensured Container ID is properly displayed after whiptail dialog completion

Changes

  • File:
  • Lines: 442-449
  • Impact: Container ID now displays correctly in the build process

Testing

  • ✅ Container ID displays when user enters custom ID
  • ✅ Container ID displays when user leaves field empty (uses default)
  • ✅ No duplicate echo statements
  • ✅ Consistent with other similar sections (hostname, etc.)

Feature Flag

This fix is ready for immediate deployment and does not require a feature flag as it's a bug fix that improves existing functionality.

Type: Bug Fix
Priority: Medium
Breaking Changes: None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/237 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `update/tools.func` --- ### 📝 Commits (2) - [`bc52256`](https://github.com/community-scripts/ProxmoxVE-Local/commit/bc52256301a25c198f147b6c2bfbda68d4745746) fix: Container ID display not showing after whiptail input - [`5faa7f3`](https://github.com/community-scripts/ProxmoxVE-Local/commit/5faa7f3646011383d45b7f836fe746506ac1b2b7) remove debian ### 📊 Changes **2 files changed** (+2929 additions, -1386 deletions) <details> <summary>View changed files</summary> 📝 `scripts/core/build.func` (+1 -4) 📝 `scripts/core/tools.func` (+2928 -1382) </details> ### 📄 Description ## 🐛 Bug Fix ### Problem The Container ID display was not showing after the whiptail input dialog, regardless of whether the user entered a custom ID or left it empty. ### Root Cause The echo statement was inside the whiptail output capture block where the output redirection was interfering with the display. ### Solution - Moved the echo statement outside the whiptail output capture block - Consolidated duplicate echo statements into a single display - Ensured Container ID is properly displayed after whiptail dialog completion ### Changes - **File**: - **Lines**: 442-449 - **Impact**: Container ID now displays correctly in the build process ### Testing - ✅ Container ID displays when user enters custom ID - ✅ Container ID displays when user leaves field empty (uses default) - ✅ No duplicate echo statements - ✅ Consistent with other similar sections (hostname, etc.) ### Feature Flag This fix is ready for immediate deployment and does not require a feature flag as it's a bug fix that improves existing functionality. --- **Type**: Bug Fix **Priority**: Medium **Breaking Changes**: None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:16:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saavagebueno/ProxmoxVE-Local#287
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?