saavagebueno/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:24:01 -04:00
Code Issues 78 Packages Projects Releases 7 Wiki Activity

[PR #277] [MERGED] Fix Install button not appearing for VM and tools scripts #309

New Issue
Closed
opened 2025-11-20 04:16:17 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:16:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/277
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/251

📝 Commits (2)

  • 2ee5f73 Fix Install button not appearing for VM and tools scripts
  • 7f1ef91 Fix vitest dependency version mismatch

📊 Changes

3 files changed (+554 additions, -71 deletions)

View changed files

📝 package-lock.json (+411 -49)
📝 package.json (+1 -1)
📝 src/server/services/scriptDownloader.js (+142 -21)

📄 Description

Problem

When downloading VM scripts or tools scripts (including tools/addon and tools/pve), only the "Load Script" button appeared, but the "Install" button didn't show up.

Solution

  • Updated checkScriptExists to preserve subdirectory structure for tools and VM scripts (e.g., tools/pve/script.sh now correctly checks tools/pve/script.sh)
  • Set ctExists=true for tools and VM scripts when their files exist (not just CT scripts)
  • Added missing compareScriptContent method to JavaScript version (was causing runtime errors)
  • Removed all VW script references as they don't exist

Changes

  • src/server/services/scriptDownloader.js: Updated checkScriptExists method and added compareScriptContent method

Fixes the issue where the Install button was missing after downloading VM or tools scripts.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/277 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/251` --- ### 📝 Commits (2) - [`2ee5f73`](https://github.com/community-scripts/ProxmoxVE-Local/commit/2ee5f73117f8812282be49571f6d0dda89a3f633) Fix Install button not appearing for VM and tools scripts - [`7f1ef91`](https://github.com/community-scripts/ProxmoxVE-Local/commit/7f1ef91db998a2509467d907f48cdadae0aab95e) Fix vitest dependency version mismatch ### 📊 Changes **3 files changed** (+554 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+411 -49) 📝 `package.json` (+1 -1) 📝 `src/server/services/scriptDownloader.js` (+142 -21) </details> ### 📄 Description ## Problem When downloading VM scripts or tools scripts (including `tools/addon` and `tools/pve`), only the "Load Script" button appeared, but the "Install" button didn't show up. ## Solution - Updated `checkScriptExists` to preserve subdirectory structure for tools and VM scripts (e.g., `tools/pve/script.sh` now correctly checks `tools/pve/script.sh`) - Set `ctExists=true` for tools and VM scripts when their files exist (not just CT scripts) - Added missing `compareScriptContent` method to JavaScript version (was causing runtime errors) - Removed all VW script references as they don't exist ## Changes - `src/server/services/scriptDownloader.js`: Updated `checkScriptExists` method and added `compareScriptContent` method Fixes the issue where the Install button was missing after downloading VM or tools scripts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:16:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saavagebueno/ProxmoxVE-Local#309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?