[PR #45] [MERGED] More generic rewrite #123

New Issue

saavagebueno · 2025-11-20T04:17:17-05:00

saavagebueno commented

2025-11-20 04:17:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/kiranshila/Doplarr/pull/45
Author: @kiranshila
Created: 1/11/2022
Status: ✅ Merged
Merged: 1/12/2022
Merged by: @kiranshila

Base: main ← Head: develop

📝 Commits (10+)

d5220ae Off by one of requesting all seasons from overseerr
b65a0bc Changed API version for sonarr
3fff7f6 Spec-ing out everything and codifying interfaces
6c8be30 More generalizations
cf78430 General layout now making sense
e21e2bf Everything but actually performing the requests works now
fec2058 Brought in orchestra for instrumentation, requesting in radarr almost works
d83b191 Sonarr almost works
222e731 Sonarr works now
285e0de Working on Readarr

📊 Changes

22 files changed (+972 additions, -815 deletions)

View changed files

📝 README.md (+30 -33)
📝 config.edn (+17 -6)
📝 deps.edn (+11 -8)
➖ doplarr.xml (+0 -58)
➖ resources/logback.xml (+0 -12)
➖ src/doplarr/arr_utils.clj (+0 -45)
➕ src/doplarr/backends/overseerr.clj (+64 -0)
➕ src/doplarr/backends/overseerr/impl.clj (+116 -0)
➕ src/doplarr/backends/radarr.clj (+48 -0)
➕ src/doplarr/backends/radarr/impl.clj (+46 -0)
➕ src/doplarr/backends/sonarr.clj (+76 -0)
➕ src/doplarr/backends/sonarr/impl.clj (+109 -0)
📝 src/doplarr/config.clj (+41 -17)
➕ src/doplarr/config/specs.clj (+64 -0)
📝 src/doplarr/core.clj (+45 -27)
📝 src/doplarr/discord.clj (+81 -122)
📝 src/doplarr/interaction_state_machine.clj (+131 -133)
➖ src/doplarr/overseerr.clj (+0 -143)
➖ src/doplarr/radarr.clj (+0 -61)
➖ src/doplarr/sonarr.clj (+0 -150)

...and 2 more files

📄 Description

The goal here is to:

Provide much better logging so errors make sense
Make the whole interaction lifecycle generic to any type of media request to make the bot more extensible to other backends and media types
Provide support for more customization of default settings
To fix some dangling bugs

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kiranshila/Doplarr/pull/45 **Author:** [@kiranshila](https://github.com/kiranshila) **Created:** 1/11/2022 **Status:** ✅ Merged **Merged:** 1/12/2022 **Merged by:** [@kiranshila](https://github.com/kiranshila) **Base:** `main` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`d5220ae`](https://github.com/kiranshila/Doplarr/commit/d5220ae75596dd1c401a5a48ac3a9a454e97be13) Off by one of requesting all seasons from overseerr - [`b65a0bc`](https://github.com/kiranshila/Doplarr/commit/b65a0bc67cce5c1e9c09cd65e194e8d14dbf4e9e) Changed API version for sonarr - [`3fff7f6`](https://github.com/kiranshila/Doplarr/commit/3fff7f624c052cae5d84e3ddea57fc32f2f54eca) Spec-ing out everything and codifying interfaces - [`6c8be30`](https://github.com/kiranshila/Doplarr/commit/6c8be304fdcfe37f6154d507bced9d4eaddcdc19) More generalizations - [`cf78430`](https://github.com/kiranshila/Doplarr/commit/cf7843005b060d0338d3c060e8ca02b4b8e36c63) General layout now making sense - [`e21e2bf`](https://github.com/kiranshila/Doplarr/commit/e21e2bf764b1bc9b6d649e6065a83b21e10136f0) Everything but actually performing the requests works now - [`fec2058`](https://github.com/kiranshila/Doplarr/commit/fec2058500a3188e2650798016388e83aa3fc3f8) Brought in orchestra for instrumentation, requesting in radarr almost works - [`d83b191`](https://github.com/kiranshila/Doplarr/commit/d83b1918bc609564526cb28f7cee6cd8c86ebb7c) Sonarr almost works - [`222e731`](https://github.com/kiranshila/Doplarr/commit/222e7317a25a05a9801665d4bf79dfdd7e453282) Sonarr works now - [`285e0de`](https://github.com/kiranshila/Doplarr/commit/285e0dedd014a1d41b18fcd80ab4970eb161e634) Working on Readarr ### 📊 Changes **22 files changed** (+972 additions, -815 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+30 -33) 📝 `config.edn` (+17 -6) 📝 `deps.edn` (+11 -8) ➖ `doplarr.xml` (+0 -58) ➖ `resources/logback.xml` (+0 -12) ➖ `src/doplarr/arr_utils.clj` (+0 -45) ➕ `src/doplarr/backends/overseerr.clj` (+64 -0) ➕ `src/doplarr/backends/overseerr/impl.clj` (+116 -0) ➕ `src/doplarr/backends/radarr.clj` (+48 -0) ➕ `src/doplarr/backends/radarr/impl.clj` (+46 -0) ➕ `src/doplarr/backends/sonarr.clj` (+76 -0) ➕ `src/doplarr/backends/sonarr/impl.clj` (+109 -0) 📝 `src/doplarr/config.clj` (+41 -17) ➕ `src/doplarr/config/specs.clj` (+64 -0) 📝 `src/doplarr/core.clj` (+45 -27) 📝 `src/doplarr/discord.clj` (+81 -122) 📝 `src/doplarr/interaction_state_machine.clj` (+131 -133) ➖ `src/doplarr/overseerr.clj` (+0 -143) ➖ `src/doplarr/radarr.clj` (+0 -61) ➖ `src/doplarr/sonarr.clj` (+0 -150) _...and 2 more files_ </details> ### 📄 Description The goal here is to: - Provide much better logging so errors make sense - Make the whole interaction lifecycle generic to any type of media request to make the bot more extensible to other backends and media types - Provide support for more customization of default settings - To fix some dangling bugs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

saavagebueno added the pull-request label 2025-11-20 04:17:17 -05:00

saavagebueno closed this issue

2025-11-20 04:17:17 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Doplarr#123