starred/UpSnap-seriousm4x-4
1
0
Fork 0
mirror of https://github.com/seriousm4x/UpSnap.git synced 2026-03-31 06:24:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow users with create permissions to scan for devices (#1611)

Browse Source 
* fix: allow users with create permissions to scan for devices

* fix: show scan tab in frontend
This commit is contained in:
Joshua Higgins
2026-02-12 18:00:54 -05:00
committed by GitHub
parent 8ae36d61cc
commit 5440ab3b25
4 changed files with 60 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
backend/pb/middlewares.go
View File

@@ -7,6 +7,32 @@ import (
"github.com/pocketbase/pocketbase/tools/hook"
)
func RequireScanDevicesPermission() *hook.Handler[*core.RequestEvent] {
return &hook.Handler[*core.RequestEvent]{
Func: func(e *core.RequestEvent) error {
if e.HasSuperuserAuth() {
return e.Next()
}
user := e.Auth
if user == nil {
return apis.NewUnauthorizedError("The request requires superuser or record authorization token to be set.", nil)
}
res, err := e.App.FindFirstRecordByFilter(
"permissions",
"user.id = {:userId} && create = true",
dbx.Params{"userId": user.Id},
)
if res == nil || err != nil {
return apis.NewForbiddenError("You are not allowed to perform this request.", nil)
}
return e.Next()
},
}
}
func RequireUpSnapPermission() *hook.Handler[*core.RequestEvent] {
return &hook.Handler[*core.RequestEvent]{
Func: func(e *core.RequestEvent) error {

2
backend/pb/pb.go
View File

@@ -75,7 +75,7 @@ func StartPocketBase(distDirFS fs.FS) {
se.Router.GET("/api/upsnap/sleep/{id}", HandlerSleep).Bind(RequireUpSnapPermission())
se.Router.GET("/api/upsnap/reboot/{id}", HandlerReboot).Bind(RequireUpSnapPermission())
se.Router.GET("/api/upsnap/shutdown/{id}", HandlerShutdown).Bind(RequireUpSnapPermission())
se.Router.GET("/api/upsnap/scan", HandlerScan).Bind(apis.RequireSuperuserAuth())
se.Router.GET("/api/upsnap/scan", HandlerScan).Bind(RequireScanDevicesPermission())
se.Router.POST("/api/upsnap/init-superuser", HandlerInitSuperuser) // https://github.com/pocketbase/pocketbase/discussions/6198
se.Router.POST("/api/upsnap/validate-cron", HandlerValidateCron)
se.Router.GET("/api/upsnap/manifest.webmanifest", HandlerWebsiteManifest)