starred/big-bear-scripts
1
0
Fork 0
mirror of https://github.com/bigbeartechworld/big-bear-scripts.git synced 2026-05-11 18:32:24 -04:00
Code Issues 22 Packages Projects Releases Wiki Activity

[PR #29] [MERGED] setup-pterodactyl-wings-full-setup-and-quick-setup #31

New Issue
Closed
opened 2025-11-20 04:14:22 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bigbeartechworld/big-bear-scripts/pull/29
Author: @dragonfire1119
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @dragonfire1119

Base: master ← Head: setup-pterodactyl-wings-full-setup-and-quick-setup

📝 Commits (2)

  • 7cf1125 ✨ feat: Implement robust network configuration for Pterodactyl
  • d81d6c5 🔧 feat(setup-pterodactyl-wings): Improve network configuration and

📊 Changes

1 file changed (+199 additions, -82 deletions)

View changed files

📝 setup-pterodactyl-wings/run.sh (+199 -82)

📄 Description

This pull request introduces a comprehensive network configuration process for the Pterodactyl setup, as well as improvements to the overall setup experience.

The key changes include:

  1. Implementing a function to find an available subnet that is not already in use by the system or other Docker networks. This helps ensure the Pterodactyl network does not conflict with existing network configurations.
  2. Calculating the gateway IP address for the selected subnet, which is then used when creating the Docker network.
  3. Enhancing the create_pterodactyl_network() function to handle network creation with proper error checking and verification.
  4. Refactoring the configure_network() function to orchestrate the entire network configuration process, including subnet discovery, gateway calculation, and network creation.
  5. Adding detailed comments to explain the purpose and flow of the network configuration logic.
  6. Providing better error handling and feedback when finding an available subnet fails.
  7. Displaying a success message when the Docker network is created successfully.
  8. Enhancing the quick setup option by using a spinner to show the progress of chown commands.
  9. Improving the formatting and messaging throughout the script for better readability and user experience.

These changes improve the reliability and robustness of the Pterodactyl setup by ensuring the network is properly configured and does not interfere with existing network resources. Additionally, the improvements to the setup process provide a more user-friendly experience for the end-user.

Summary by CodeRabbit

  • New Features

    • Enhanced script with improved user interaction
    • Added colored output and spinner for long-running operations
    • Expanded welcome message with support links

  • Bug Fixes

    • Improved input validation
    • Updated network configuration logic
    • Enhanced error handling and feedback messages

  • Documentation

    • Added clearer comments for network configuration functions
    • Improved script readability and user guidance

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bigbeartechworld/big-bear-scripts/pull/29 **Author:** [@dragonfire1119](https://github.com/dragonfire1119) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@dragonfire1119](https://github.com/dragonfire1119) **Base:** `master` ← **Head:** `setup-pterodactyl-wings-full-setup-and-quick-setup` --- ### 📝 Commits (2) - [`7cf1125`](https://github.com/bigbeartechworld/big-bear-scripts/commit/7cf1125568b10e7775f00fa2018239726b594afb) ✨ feat: Implement robust network configuration for Pterodactyl - [`d81d6c5`](https://github.com/bigbeartechworld/big-bear-scripts/commit/d81d6c5a8e528679890940badc4b8fd1de616e99) 🔧 feat(setup-pterodactyl-wings): Improve network configuration and ### 📊 Changes **1 file changed** (+199 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `setup-pterodactyl-wings/run.sh` (+199 -82) </details> ### 📄 Description This pull request introduces a comprehensive network configuration process for the Pterodactyl setup, as well as improvements to the overall setup experience. The key changes include: 1. Implementing a function to find an available subnet that is not already in use by the system or other Docker networks. This helps ensure the Pterodactyl network does not conflict with existing network configurations. 2. Calculating the gateway IP address for the selected subnet, which is then used when creating the Docker network. 3. Enhancing the `create_pterodactyl_network()` function to handle network creation with proper error checking and verification. 4. Refactoring the `configure_network()` function to orchestrate the entire network configuration process, including subnet discovery, gateway calculation, and network creation. 5. Adding detailed comments to explain the purpose and flow of the network configuration logic. 6. Providing better error handling and feedback when finding an available subnet fails. 7. Displaying a success message when the Docker network is created successfully. 8. Enhancing the quick setup option by using a spinner to show the progress of chown commands. 9. Improving the formatting and messaging throughout the script for better readability and user experience. These changes improve the reliability and robustness of the Pterodactyl setup by ensuring the network is properly configured and does not interfere with existing network resources. Additionally, the improvements to the setup process provide a more user-friendly experience for the end-user. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced script with improved user interaction - Added colored output and spinner for long-running operations - Expanded welcome message with support links - **Bug Fixes** - Improved input validation - Updated network configuration logic - Enhanced error handling and feedback messages - **Documentation** - Added clearer comments for network configuration functions - Improved script readability and user guidance <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/big-bear-scripts#31
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?