From 542e89536c524cdb2215a48384af7ef6fad2c443 Mon Sep 17 00:00:00 2001
From: Quentin McGaw <quentin.mcgaw@gmail.com>
Date: Mon, 6 May 2024 11:13:07 +0000
Subject: [PATCH] fix(noip): useproviderip and no ip returned case

---
 internal/provider/providers/noip/provider.go | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/internal/provider/providers/noip/provider.go b/internal/provider/providers/noip/provider.go
index 7f83abdd..43154017 100644
--- a/internal/provider/providers/noip/provider.go
+++ b/internal/provider/providers/noip/provider.go
@@ -177,7 +177,11 @@ func (p *Provider) Update(ctx context.Context, client *http.Client, ip netip.Add
 		ips = ipextract.IPv6(s)
 	}
 
-	if !useProviderIP && len(ips) == 0 {
+	if len(ips) == 0 {
+		if useProviderIP {
+			// No returned ip address from noip server
+			return ip, nil
+		}
 		return netip.Addr{}, fmt.Errorf("%w", errors.ErrReceivedNoIP)
 	}