From 860bc02e2e31d22f544c5351bf728e7d598f2a2f Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Tue, 13 Oct 2020 01:10:22 +0000 Subject: [PATCH] VSCode development container changes - SSH bind mount as read write - More Golang linters --- .devcontainer/devcontainer.json | 52 ++++++++++++++++++++++++++++++-- .devcontainer/docker-compose.yml | 4 +-- 2 files changed, 52 insertions(+), 4 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index e21a3d5e..c053d4a7 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -46,14 +46,24 @@ "go.lintFlags": [ "--fast", "--enable", - "rowserrcheck", + "asciicheck", "--enable", "bodyclose", "--enable", + "deadcode", + "--enable", "dogsled", "--enable", "dupl", "--enable", + "errcheck", + "--enable", + "exhaustive", + "--enable", + "exportloopref", + "--enable", + "gci", + "--enable", "gochecknoglobals", "--enable", "gochecknoinits", @@ -66,29 +76,67 @@ "--enable", "gocyclo", "--enable", + "godot", + "--enable", + "goerr113", + "--enable", + "goheader", + "--enable", "goimports", "--enable", "golint", "--enable", + "gomnd", + "--enable", + "goprintffuncname", + "--enable", "gosec", "--enable", + "gosimple", + "--enable", + "govet", + "--enable", + "ineffassign", + "--enable", "interfacer", "--enable", + "lll", + "--enable", "maligned", "--enable", "misspell", "--enable", "nakedret", "--enable", + "nestif", + "--enable", + "noctx", + "--enable", + "nolintlint", + "--enable", "prealloc", "--enable", + "rowserrcheck", + "--enable", "scopelint", "--enable", + "sqlclosecheck", + "--enable", + "staticcheck", + "--enable", + "structcheck", + "--enable", + "typecheck", + "--enable", "unconvert", "--enable", "unparam", "--enable", - "whitespace" + "unused", + "--enable", + "varcheck", + "--enable", + "whitespace", ], // Golang on save "go.buildOnSave": "workspace", diff --git a/.devcontainer/docker-compose.yml b/.devcontainer/docker-compose.yml index 1c6ef133..d0c09bb1 100644 --- a/.devcontainer/docker-compose.yml +++ b/.devcontainer/docker-compose.yml @@ -5,8 +5,8 @@ services: image: qmcgaw/godevcontainer volumes: - ../:/workspace - - ~/.ssh:/home/vscode/.ssh:ro - - ~/.ssh:/root/.ssh:ro + - ~/.ssh:/home/vscode/.ssh + - ~/.ssh:/root/.ssh - /var/run/docker.sock:/var/run/docker.sock cap_add: - SYS_PTRACE