starred/ddns-updater
1
0
Fork 0
mirror of https://github.com/qdm12/ddns-updater.git synced 2026-08-02 10:38:41 -04:00
Code Issues 312 Packages Projects Releases 10 Wiki Activity

Bug: GoDaddy Error Malformed Secret #102

New Issue
Closed
opened 2025-11-20 04:20:16 -05:00 by saavagebueno · 5 comments
saavagebueno commented 2025-11-20 04:20:16 -05:00
Owner
Copy Link

Originally created by @IonCharge on GitHub (Feb 12, 2021).

Originally assigned to: @qdm12 on GitHub.

TLDR: GoDaddy does not work. Error shows malformed secret

  1. Is this urgent: Yes
  2. DNS provider(s) you use: GoDaddy
  3. Program version: Running version latest built on 2021-02-11T13:41:05Z (commit caa4840)
  4. What are you using to run the container: docker-compose
  5. Extra information

Logs:

ddns-updater    | =========================================
ddns-updater    | =========================================
ddns-updater    | ========= DDNS Universal Updater ========
ddns-updater    | =========================================
ddns-updater    | === Made with ❤️  by github.com/qdm12 ====
ddns-updater    | =========================================
ddns-updater    |
ddns-updater    | Running version latest built on 2021-02-11T13:41:05Z (commit caa4840)
ddns-updater    |
ddns-updater    |
ddns-updater    | 🔧  Need help? https://github.com/qdm12/ddns-updater/issues/new
ddns-updater    | 💻  Email? quentin.mcgaw@gmail.com
ddns-updater    | ☕  Slack? Join from the Slack button on Github
ddns-updater    | 💸  Help me? https://github.com/sponsors/qdm12
ddns-updater    | 2021-02-12T04:43:46.066Z      ERROR   malformed secret
ddns-updater exited with code 1

Configuration file (remove your credentials!):

{
  "settings": [
    {
      "provider": "godaddy",
      "domain": "ABCD.org",
      "host": "@",
      "key": "key",
      "secret": "secret",
      "ip_version": "ipv4"
    }
  ]
}

Host OS: Ubuntu 18.04 LTS

Note: I know my API key works. There is an example CURL command here: https://developer.godaddy.com/getstarted

curl -X GET -H"Authorization: sso-key [API_KEY]:[API_SECRET]" "https://api.godaddy.com/v1/domains/available?domain=example.guru"
Originally created by @IonCharge on GitHub (Feb 12, 2021). Originally assigned to: @qdm12 on GitHub. **TLDR**: GoDaddy does not work. Error shows malformed secret 1. Is this urgent: Yes 2. DNS provider(s) you use: GoDaddy 3. Program version: Running version latest built on 2021-02-11T13:41:05Z (commit caa4840) 4. What are you using to run the container: docker-compose 5. Extra information Logs: ``` ddns-updater | ========================================= ddns-updater | ========================================= ddns-updater | ========= DDNS Universal Updater ======== ddns-updater | ========================================= ddns-updater | === Made with ❤️ by github.com/qdm12 ==== ddns-updater | ========================================= ddns-updater | ddns-updater | Running version latest built on 2021-02-11T13:41:05Z (commit caa4840) ddns-updater | ddns-updater | ddns-updater | 🔧 Need help? https://github.com/qdm12/ddns-updater/issues/new ddns-updater | 💻 Email? quentin.mcgaw@gmail.com ddns-updater | ☕ Slack? Join from the Slack button on Github ddns-updater | 💸 Help me? https://github.com/sponsors/qdm12 ddns-updater | 2021-02-12T04:43:46.066Z ERROR malformed secret ddns-updater exited with code 1 ``` Configuration file (**remove your credentials!**): ``` { "settings": [ { "provider": "godaddy", "domain": "ABCD.org", "host": "@", "key": "key", "secret": "secret", "ip_version": "ipv4" } ] } ``` Host OS: Ubuntu 18.04 LTS Note: I know my API key works. There is an example CURL command here: https://developer.godaddy.com/getstarted ``` curl -X GET -H"Authorization: sso-key [API_KEY]:[API_SECRET]" "https://api.godaddy.com/v1/domains/available?domain=example.guru" ```
saavagebueno commented 2025-11-20 04:20:17 -05:00
Author
Owner
Copy Link

@IonCharge commented on GitHub (Feb 12, 2021):

My Secret key is actually 21 characters. Not sure if that is because it is an older key.

I assume the issue is caused by the following line:
caa4840a61/internal/regex/regex.go (L33) #

I believe this can be fixed easily with the following change:

matcher.goDaddySecret, err = regexp.Compile(`^[A-Za-z0-9]{21,22}$`)

@IonCharge commented on GitHub (Feb 12, 2021): My Secret key is actually **21** characters. Not sure if that is because it is an older key. I assume the issue is caused by the following line: https://github.com/qdm12/ddns-updater/blob/caa4840a6107b58b8d2e86a70771718743726623/internal/regex/regex.go#L33 # I believe this can be fixed easily with the following change: ``` matcher.goDaddySecret, err = regexp.Compile(`^[A-Za-z0-9]{21,22}$`) ```
saavagebueno commented 2025-11-20 04:20:17 -05:00
Author
Owner
Copy Link

@qdm12 commented on GitHub (Feb 12, 2021):

Indeed, thanks for digging in the code! Should now be fixed in :latest once it's built. Feel free to comment if it does/doesn't work 👍

@qdm12 commented on GitHub (Feb 12, 2021): Indeed, thanks for digging in the code! Should now be fixed in `:latest` once it's built. Feel free to comment if it does/doesn't work 👍
saavagebueno commented 2025-11-20 04:20:17 -05:00
Author
Owner
Copy Link

@IonCharge commented on GitHub (Feb 13, 2021):

@qdm12

I pulled the latest build this morning to try out and I am still having the error. See below:

Version: latest built on 2021-02-12T14:39:59Z (commit c985595)

ddns-updater    | =========================================
ddns-updater    | =========================================
ddns-updater    | ========= DDNS Universal Updater ========
ddns-updater    | =========================================
ddns-updater    | === Made with ❤️  by github.com/qdm12 ====
ddns-updater    | =========================================
ddns-updater    |
ddns-updater    | Running version latest built on 2021-02-12T14:39:59Z (commit c985595)
ddns-updater    |
ddns-updater    |
ddns-updater    | 🔧  Need help? https://github.com/qdm12/ddns-updater/issues/new
ddns-updater    | 💻  Email? quentin.mcgaw@gmail.com
ddns-updater    | ☕  Slack? Join from the Slack button on Github
ddns-updater    | 💸  Help me? https://github.com/sponsors/qdm12
ddns-updater    | 2021-02-13T20:13:54.811Z      ERROR   malformed secret

It is still showing a malformed secret error.

@IonCharge commented on GitHub (Feb 13, 2021): @qdm12 I pulled the latest build this morning to try out and I am still having the error. See below: Version: latest built on 2021-02-12T14:39:59Z (commit c985595) ``` ddns-updater | ========================================= ddns-updater | ========================================= ddns-updater | ========= DDNS Universal Updater ======== ddns-updater | ========================================= ddns-updater | === Made with ❤️ by github.com/qdm12 ==== ddns-updater | ========================================= ddns-updater | ddns-updater | Running version latest built on 2021-02-12T14:39:59Z (commit c985595) ddns-updater | ddns-updater | ddns-updater | 🔧 Need help? https://github.com/qdm12/ddns-updater/issues/new ddns-updater | 💻 Email? quentin.mcgaw@gmail.com ddns-updater | ☕ Slack? Join from the Slack button on Github ddns-updater | 💸 Help me? https://github.com/sponsors/qdm12 ddns-updater | 2021-02-13T20:13:54.811Z ERROR malformed secret ``` It is still showing a malformed secret error.
saavagebueno commented 2025-11-20 04:20:17 -05:00
Author
Owner
Copy Link

@qdm12 commented on GitHub (Feb 13, 2021):

I removed the check entirely for now (except check it's not empty) in 2e5b3c7924

Please wait for the build to complete (check Github Actions) and then try by pulling it again 😉

@qdm12 commented on GitHub (Feb 13, 2021): I removed the check entirely for now (except check it's not empty) in 2e5b3c79240888d0c3189223fe78d1b3ddab68a5 Please wait for the build to complete (check Github Actions) and then try by pulling it again 😉
saavagebueno commented 2025-11-20 04:20:18 -05:00
Author
Owner
Copy Link

@IonCharge commented on GitHub (Feb 13, 2021):

It works!

ddns-updater    | =========================================
ddns-updater    | =========================================
ddns-updater    | ========= DDNS Universal Updater ========
ddns-updater    | =========================================
ddns-updater    | === Made with ❤️  by github.com/qdm12 ====
ddns-updater    | =========================================
ddns-updater    |
ddns-updater    | Running version latest built on 2021-02-13T20:30:07Z (commit 2e5b3c7)
ddns-updater    |
ddns-updater    |
ddns-updater    | 🔧  Need help? https://github.com/qdm12/ddns-updater/issues/new
ddns-updater    | 💻  Email? quentin.mcgaw@gmail.com
ddns-updater    | ☕  Slack? Join from the Slack button on Github
ddns-updater    | 💸  Help me? https://github.com/sponsors/qdm12
ddns-updater    | 2021-02-13T22:12:05.311Z      INFO    Found single setting to update record
ddns-updater    | 2021-02-13T22:12:05.509Z      INFO    Reading history from database: domain ABCD.org host XYZ
ddns-updater    | 2021-02-13T22:12:05.510Z      INFO    healthcheck server: listening on 127.0.0.1:9999
ddns-updater    | 2021-02-13T22:12:05.510Z      INFO    http server: listening on 0.0.0.0:8000
ddns-updater    | 2021-02-13T22:12:05.510Z      INFO    backup: disabled

I sanitized the domain and host in the log output. Thank you so much. Let me know if you need an example of my 21 character secret key to fix the main cause.

@IonCharge commented on GitHub (Feb 13, 2021): It works! ``` ddns-updater | ========================================= ddns-updater | ========================================= ddns-updater | ========= DDNS Universal Updater ======== ddns-updater | ========================================= ddns-updater | === Made with ❤️ by github.com/qdm12 ==== ddns-updater | ========================================= ddns-updater | ddns-updater | Running version latest built on 2021-02-13T20:30:07Z (commit 2e5b3c7) ddns-updater | ddns-updater | ddns-updater | 🔧 Need help? https://github.com/qdm12/ddns-updater/issues/new ddns-updater | 💻 Email? quentin.mcgaw@gmail.com ddns-updater | ☕ Slack? Join from the Slack button on Github ddns-updater | 💸 Help me? https://github.com/sponsors/qdm12 ddns-updater | 2021-02-13T22:12:05.311Z INFO Found single setting to update record ddns-updater | 2021-02-13T22:12:05.509Z INFO Reading history from database: domain ABCD.org host XYZ ddns-updater | 2021-02-13T22:12:05.510Z INFO healthcheck server: listening on 127.0.0.1:9999 ddns-updater | 2021-02-13T22:12:05.510Z INFO http server: listening on 0.0.0.0:8000 ddns-updater | 2021-02-13T22:12:05.510Z INFO backup: disabled ``` I sanitized the domain and host in the log output. Thank you so much. Let me know if you need an example of my 21 character secret key to fix the main cause.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Category: Config problem 📝
Category: Database 🗃️
Category: Documentation ✒️
Category: Foolproof settings 👼
Category: Good idea 🎯
Category: Healthcheck 🩺
Category: IP fetching 📥
Category: Label missing ❗
Category: Maintenance ⛓️
Category: Motivated! 🙌
Category: New provider 🆕
Category: Provider update ♻️
Category: Shoutrrr 📢
Category: Web UI 🖱️
Category: Wildcard 🃏
Closed: ⚰️ Inactive
Closed: 👥 Duplicate
Closed: 🗑️ Bad issue
Complexity: ☣️ Hard to do
Complexity: 🟩 Easy to do
Priority: 💤 Low priority
Priority: 🚨 Urgent
pull-request
Mirrored from GitHub Pull Request
 Status: 🔒 After next release
Status: 🔴 Blocked
Status: 🗯️ Waiting for feedback
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ddns-updater#102
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?