mirror of
https://github.com/qdm12/ddns-updater.git
synced 2026-07-30 01:22:38 -04:00
Bug: in dd24 provider - update not possible - ERROR bad authentication #134
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kreditor0815 on GitHub (Aug 24, 2021).
Originally assigned to: @qdm12 on GitHub.
TLDR: The plugin for dd24 seems to be broken. No update is possible ("ERROR bad authentication"). It seems, there is a typo or copy&paste error in source @ the if/else near
51dd14cb66/internal/settings/providers/dd24/provider.go (L102-L106)Is this urgent: Yes
DNS provider(s) you use: dd24
Program version:
Running version latest built on 2021-08-16T12:40:55Z (commit 51dd14c)What are you using to run the container: docker-compose
Logs:
Noticed the IP-Address in the GET Request? I think that was placed in the wrong field.
Configuration file (remove your credentials!):
Host OS:
some kind of ubuntu
I think one possible source of this problem can be found in setting variables in this if/else:
51dd14cb66/internal/settings/providers/dd24/provider.go (L102-L106)But that variable already got set with the correct value @
51dd14cb66/internal/settings/providers/dd24/provider.go (L100)I'm pretty confident that this should not set the value of the hostname-variable but the ip-variable (as stated in the documentation: https://www.domaindiscount24.com/faq/en/dynamic-dns).
As this lines are not avoidable and are overwriting the hostname-variable, this plugin seems completely broken to me.
@qdm12 commented on GitHub (Aug 24, 2021):
You totally nailed down the issue, thanks!!
Indeed the implementation was faulty from the start, sorry I did not have feedback from the user who requested it when it got added. Let me know if it works for you, thanks!
@kreditor0815 commented on GitHub (Aug 24, 2021):
Hi @qdm12,
I just wanted to let you know that commit
c584f9b3d5totally fixed it for me.Thank you very much for your help :)