mirror of
https://github.com/qdm12/ddns-updater.git
synced 2026-08-02 10:38:41 -04:00
Feature request: LISTENING_ADDRESS variable #341
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @edaubert on GitHub (Jan 4, 2024).
Currently we can specify the TCP port used to provide the Web UI (
LSITENING_PORT) and all the IP addresses of the host are used as available addresses to connect on this port.I would like to be able to specify the address on which the UI is available.
For example, I only want the Web UI on a specific sub network.
I saw on the code that you were planning at some point to replace
LISTENING_PORTby something likeLISTENIING_ADDRESSor to add this variable and keep the other.I can do a proposal about it but before that, I would like to know your thoughts about it.
LISTENING_PORTfor backward compatibility ?@qdm12 commented on GitHub (Jan 16, 2024):
Thanks for the suggestion!
I did it myself since I wanted to upgrade a settings reading library dependency before doing it (
ab6908b8cc), now it's sitting in PR https://github.com/qdm12/ddns-updater/pull/590/filesIt's possible, it would take me a few minutes, but the code would get rather ugly (need to run N parallel http servers in goroutines) so I would rather avoid. Would you have a use case for this? 🤔
@edaubert commented on GitHub (Jan 17, 2024):
Hi,
Your PR seems good to me and better than what I have started 😄
No specific use case for multiple addresses, it was a simple question to know what I should have as requirement if I provide a PR.
Hope to see your PR soon on a release 👍
@qdm12 commented on GitHub (Jan 18, 2024):
Merged! So, no use case for multiple addresses then right?