mirror of
https://github.com/qdm12/ddns-updater.git
synced 2026-08-02 10:38:41 -04:00
Feature request: rename host -> owner
#360
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @qdm12 on GitHub (Feb 3, 2024).
The current parameter
hostis a computer name in a network and is not a perfect name, despite being used by a few providers on their Web UI.subdomainis problematic/misleading since for examplea.b.c.comis a subdomain ofb.c.com, despite the domain beingc.com; plus@or*are not really subdomains. The technical DNS name for this left part for a certain domain isowner, and we should use it to avoid confusion.@Peronia commented on GitHub (Feb 16, 2024):
Well, I think
owneris not really better thanhost. I agree with you,hosthave nothing todo with this parameter. But in my viewowneris very technically. In my case I have a lot of confusion even when I found that issue, see here.I would suggest a name like
prefix/domainprefixorsubpart. Yeah I know this terms are not 100% correct, but my case is about understanding. And I agree also with you thatsubdomaincan be misleading.I could add a part at the readme that add more explanation, when you want I can open a PR.
@qdm12 commented on GitHub (Feb 19, 2024):
Why not otherwise have domain accept forms such as
*.domain.com,domain.comandabc.domain.com, and remove (keep it for retro compat) thehostfield? 🤔@Peronia commented on GitHub (Feb 20, 2024):
Well, thats the best way of understanding. But is this technically possible? I know you are the maintainer so you don't suggest things that won't work I think. Do we need this
host/ownervalue as a seperate info?@qdm12 commented on GitHub (Feb 29, 2024):
In general, domains are of the form
domain.tld. It's possible maybe to havedo.main.tldbut it's rather uncommon. If one uses such form, he/she can set the owner in the old (kept for retro-compatibility)"host"field to make sure ddns-updater understandsdo.main.tldis the domain and notmain.tld. Not something I want to document unless someone raises an issue about this, since I have never seen such case. So in general it will bes.u.bdomain.domain.tldand ddns-updater will understands.u.bdomainas the owner anddomain.tldas the domain.Overall I think what's needed:
ownerfield to mimic thehostfield, and replace host with owner in the documentation. Just plain bad naming that needs to go away. Add a note to remove the host field in a future breaking changes v3 release. We may want to keep the owner field for weird edge cases where the (dns technical sense) domain has more than 1 dot.optional.domain.com. The owner can be empty (->@) if the domain is justdomain.com.ownerfielddomainfieldSo in the end, we would just have the
"domain"field, except for the weird domain names where"owner"may come into play, but we keep it secret 😄@Peronia commented on GitHub (Mar 4, 2024):
Okay, got it. But why remove the documentation? Then we have an undocumentated field, that is not very nice. I would suggest to move the documentation to another plac, like archive or something like that.
@qdm12 commented on GitHub (Mar 7, 2024):
Because the code would still be functional with the older host field, and I hope we wouldn't need it going forward. Older documentation can still be accessed by accessing release tagged trees on github (or specific commits). If people already using the program can migrate to the newer format, that's also better for a smoother migration to a v3 release 😉
@Peronia commented on GitHub (Mar 10, 2024):
I'm still not convinced about having an undocumented field, but it's not my project, I would solve it differently.
The github tree thing sounds more complicated, I'm not familiar with it anyway.
@qdm12 commented on GitHub (Jun 27, 2024):
55d8c0d703added versioned readme+docs/ links to the readme32fafeca95hostrenamed toownerin documentation, code, and config.json. This is retro-compatible with the JSONhostfield key still.07d7645d78bothhostandownerremoved in favor of getting the owner and "eTLD+1" from the domain field value, using golang.org/x/net/publicsuffix and a bit of string manipulation logic. This is still retro-compatible with both thehostandownerJSON config field keys, which takes precedence if set to a non empty string.Closing this since all these points should resolve this 😉